Index: /trunk/doc/misc/parseErrorCodes.pl
===================================================================
--- /trunk/doc/misc/parseErrorCodes.pl	(revision 2381)
+++ /trunk/doc/misc/parseErrorCodes.pl	(revision 2382)
@@ -1,11 +1,20 @@
 #!/usr/bin/perl
+
+# Copyright (C) 2004  Somebody
+#
+# $somekeyword$
+
+use strict;
+use warnings;
 
 # Provides functions for handling long command line options
 use Getopt::Long;
 
-my @ErrorCodes        = ();
-my @ErrorDescriptions = ();
+my @errorCodes;
+my @errorDescriptions;
 
 my $data = "psErrorCodes.dat";
+my $verbose;
+my $help;
 
 # Assign variables based on the presence of command line options to the script
@@ -18,80 +27,73 @@
 if ($help) {
     print "Usage: parseErrorCodes ", "[--data=$data] ", "[--help] ",
-      "[--verbose] filename [filename ...]\n\n";
+        "[--verbose] filename [filename ...]\n\n";
     exit(0);
 }
 
 print "Using data file '$data'\n" if $verbose;
-unless ( open( DATAFILE, "<", $data ) ) {
-    die "Can not open data file $data.";
-}
+open(my $dataFile, "<", $data) or die "Can not open data file $data";
 
 print "Datafile:\n" if $verbose;
-while (<DATAFILE>) {
-    chop;
-    if (/^\s*\#/) {
-        print "C $_\n" if $verbose;
-    }
-    else {
-        if (/^\s*(\w+)\s+([\%\w].*)/) {
-            my $ErrorCode        = $1;
-            my $ErrorDescription = $2;
-            print "  $ErrorCode: '$ErrorDescription'\n" if $verbose;
-            push( @ErrorCodes,        $ErrorCode );
-            push( @ErrorDescriptions, $ErrorDescription );
+foreach my $record (<$dataFile>) {
+    chop $record;
+    if ($record =~ /^\s*\#/) {
+        print "C $record\n" if $verbose;
+    } else {
+        if ($record =~ /^\s*(\w+)\s+([\%\w].*)/) {
+            my $errorCode        = $1;
+            my $errorDescription = $2;
+            print "  $errorCode: '$errorDescription'\n" if $verbose;
+            push(@errorCodes,        $errorCode);
+            push(@errorDescriptions, $errorDescription);
         } else {
-            print "I $_\n" if $verbose;
+            print "I $record\n" if $verbose;
         }
     }
 }
-close(DATAFILE);
+close($dataFile) or die "Can not close file $data";
 
-my $found = $#ErrorCodes + 1;
+my $found = $#errorCodes + 1;
 print "\nFound $found error codes.\n" if $verbose;
 
-foreach (@ARGV) {
-    my $filename = $_;
-    my @result   = ();
+foreach my $filename (@ARGV) {
+    my @result;
 
-    die "Failed to open input file"
-      if !open( INFILE, "<", $filename );
+    open(my $inFile, "<", $filename) or die "Failed to open input file";
 
     print "\nOutput File:\n" if $verbose;
-    while (<INFILE>) {
-        chop;
-        push( @result, $_ );
-        if (/^\s*\/\/~Start(.*)$/) {
-            $line = $1;
-            for ( $n = 0 ; $n < $found ; $n++ ) {
-                $_ = $line;
-                s/\$1/$ErrorCodes[$n]/g;
-                s/\$2/$ErrorDescriptions[$n]/g;
-                s/\$n/$n/g;
-                push( @result, $_ );
-                print "$_\n" if $verbose;
+    foreach my $record (<$inFile>) {
+        chop $record;
+        push(@result, $record);
+        if ($record =~ /^\s*\/\/~Start(.*)$/) {
+            my $line = $1;
+            for (my $n = 0; $n < $found; $n++) {
+                $line =~ s/\$1/$errorCodes[$n]/g;
+                $line =~ s/\$2/$errorDescriptions[$n]/g;
+                $line =~ s/\$n/$n/g;
+                push(@result, $line);
+                print "$line\n" if $verbose;
             }
 
-            $break = 0;
-            while ( ( $break == 0 ) && ( $_ = <INFILE> ) ) {
-                if (/^\s*\/\/~End/) {
+            my $break = 0;
+            while (($break == 0) && (my $record = <$inFile>)) {
+                if ($record =~ /^\s*\/\/~End/) {
                     $break = 1;
                 }
             }
             chop;
-            push( @result, $_ );
+            push(@result, $record);
         }
     }
 
-    close(INFILE);
+    close($inFile) or die "Can not close file $filename";
 
-    die "Failed to overwrite input file"
-      if !open( OUTFILE, ">", $filename );
+    open(my $outFile, ">", $filename) or die "Failed to overwrite input file";
 
-    foreach (@result) {
-        print OUTFILE "$_\n";
-        print "$_\n" if $verbose;
+    foreach my $res (@result) {
+        print $outFile, "$res\n";
+        print "$res\n" if $verbose;
     }
 
-    close(OUTFILE);
+    close($outFile) or die "Can not close file $filename";
 
 }