Index: trunk/ippconfig/gpc1/ppImage.config =================================================================== --- trunk/ippconfig/gpc1/ppImage.config (revision 35530) +++ trunk/ippconfig/gpc1/ppImage.config (revision 35531) @@ -30,4 +30,7 @@ USE.VIDEO.MASK BOOL TRUE # Use a video mask if we have video data? +# aditional auxillary mask applied to corners of all chips in video cells. +# Is only applied if MASK.AUXMASK and USE.VIDEO.MASK are both true +AUX.VIDEO.MASK STR neb://any/gpc1/auxmask/mpg.20130506/mask_video_cell_corners.fits @@ -150,5 +153,5 @@ FRINGE.FILTERS STR y.00000 -# Standard chip processing +# Standard chip processing (NOTE: when changing this be sure to check whether changes should be applied toCHIP_BGPRESEVE and/or CHIP_AUXMASK CHIP METADATA BASE.FITS BOOL FALSE # Save base detrended image? @@ -169,4 +172,5 @@ MASK.BUILD BOOL TRUE # Build internal mask? MASK.BURNTOOL BOOL TRUE # Mask potential burntool trails + MASK.AUXMASK BOOL FALSE # augment with more restrictive auxillary mask PATTERN.ROW BOOL TRUE # Row pattern correction PATTERN.CELL BOOL FALSE # Cell pattern correction @@ -1220,4 +1224,37 @@ END +# Standard chip processing + auxillary mask +CHIP_AUXMASK METADATA + BASE.FITS BOOL FALSE # Save base detrended image? + BASE.MASK.FITS BOOL FALSE # Save base detrended image? + BASE.VARIANCE.FITS BOOL FALSE # Save base detrended image? + CHIP.FITS BOOL TRUE # Save chip-mosaic-ed image? + CHIP.MASK.FITS BOOL TRUE # Save chip-mosaic-ed image? + CHIP.VARIANCE.FITS BOOL TRUE # Save chip-mosaic-ed image? + OVERSCAN BOOL TRUE # Overscan subtraction + NONLIN BOOL TRUE # apply non-linearity correction + BIAS BOOL FALSE # Bias subtraction + DARK BOOL TRUE # Dark subtraction + NOISEMAP BOOL TRUE + REMNANCE BOOL FALSE # Remnance masking + SHUTTER BOOL FALSE # Shutter correction + FLAT BOOL TRUE # Flat-field normalisation + MASK BOOL TRUE # Mask bad pixels + MASK.BUILD BOOL TRUE # Build internal mask? + MASK.BURNTOOL BOOL TRUE # Mask potential burntool trails + MASK.AUXMASK BOOL TRUE # augment with more restrictive auxillary mask + PATTERN.ROW BOOL TRUE # Row pattern correction + PATTERN.CELL BOOL FALSE # Cell pattern correction + PATTERN.CONTINUITY BOOL TRUE # Cell pattern correction using edge continuity + FRINGE BOOL TRUE # Fringe subtraction + BIN1.FITS BOOL TRUE # Save 1st binned chip image? + BIN2.FITS BOOL TRUE # Save 2nd binned chip image? + PHOTOM BOOL TRUE # Source identification and photometry + ASTROM.CHIP BOOL FALSE # Astrometry per chip? + ASTROM.MOSAIC BOOL FALSE # Astrometry for mosaic? + BACKGROUND BOOL TRUE # Subtract background? + CROSSTALK.MEASURE BOOL TRUE # Subtract model background? +END + # Standard chip processing without any background removal CHIP_PRESERVE_BG METADATA @@ -1239,4 +1276,5 @@ MASK.BUILD BOOL TRUE # Build internal mask? MASK.BURNTOOL BOOL TRUE # Mask potential burntool trails + MASK.AUXMASK BOOL TRUE # augment with more restrictive auxillary mask PATTERN.ROW BOOL FALSE # Row pattern correction PATTERN.CELL BOOL FALSE # Cell pattern correction Index: trunk/ippconfig/recipes/ppImage.config =================================================================== --- trunk/ippconfig/recipes/ppImage.config (revision 35530) +++ trunk/ippconfig/recipes/ppImage.config (revision 35531) @@ -17,4 +17,6 @@ MASK.LOW BOOL TRUE # Mask pixels below valid range MASK.BURNTOOL BOOL FALSE # Mask potential burntool trails +MASK.AUXMASK BOOL FALSE # augment mask with auxillary mask +AUX.VIDEO.MASK STR NULL VARIANCE.BUILD BOOL FALSE # Build internal variance image ADDNOISE BOOL FALSE # Add noise to degrade an MD image to a 3pi image? @@ -168,4 +170,29 @@ # Standard chip processing CHIP METADATA + BASE.FITS BOOL FALSE # Save base detrended image? + BASE.MASK.FITS BOOL FALSE # Save base detrended image? + BASE.VARIANCE.FITS BOOL FALSE # Save base detrended image? + CHIP.FITS BOOL TRUE # Save chip-mosaic-ed image? + CHIP.MASK.FITS BOOL TRUE # Save chip-mosaic-ed image? + CHIP.VARIANCE.FITS BOOL TRUE # Save chip-mosaic-ed image? + OVERSCAN BOOL TRUE # Overscan subtraction + NONLIN BOOL FALSE # Non-linearity correction; not implemented + BIAS BOOL TRUE # Bias subtraction + DARK BOOL TRUE # Dark subtraction + SHUTTER BOOL FALSE # Shutter correction + FLAT BOOL TRUE # Flat-field normalisation + MASK BOOL TRUE # Mask bad pixels + FRINGE BOOL TRUE # Fringe subtraction + BIN1.FITS BOOL TRUE # Save 1st binned chip image? + BIN2.FITS BOOL TRUE # Save 2nd binned chip image? + PHOTOM BOOL TRUE # Source identification and photometry + ASTROM.CHIP BOOL FALSE # Astrometry per chip? + ASTROM.MOSAIC BOOL FALSE # Astrometry for mosaic? + BACKGROUND BOOL TRUE # Subtract background? + MASK.STATS BOOL TRUE # Calculate Mask statistics. +END + +# Standard chip processing +CHIP_AUXMASK METADATA BASE.FITS BOOL FALSE # Save base detrended image? BASE.MASK.FITS BOOL FALSE # Save base detrended image? Index: trunk/ippconfig/recipes/reductionClasses.mdc =================================================================== --- trunk/ippconfig/recipes/reductionClasses.mdc (revision 35530) +++ trunk/ippconfig/recipes/reductionClasses.mdc (revision 35531) @@ -1007,5 +1007,5 @@ STS_DATASET METADATA - CHIP_PPIMAGE STR CHIP + CHIP_PPIMAGE STR CHIP_AUXMASK CHIP_PSPHOT STR CHIP WARP_PSWARP STR WARP @@ -1023,4 +1023,28 @@ END +M31_DATASET METADATA + CHIP_PPIMAGE STR CHIP_AUXMASK + CHIP_PSPHOT STR CHIP + WARP_PSWARP STR WARP + STACK_PPSTACK STR STACK + STACK_PPSUB STR STACK + STACK_PSPHOT STR STACK + DIFF_PPSUB STR DIFF + DIFF_PSPHOT STR DIFF + JPEG_BIN1 STR PPIMAGE_J1 + JPEG_BIN2 STR PPIMAGE_J2 + FAKEPHOT STR FAKEPHOT + ADDSTAR STR ADDSTAR + PSASTRO STR DEFAULT_RECIPE + STACKPHOT_PSPHOT STR STACKPHOT + STACKPHOT_PPSUB STR STACKPHOT + STACKPHOT_PPSTACK STR STACKPHOT + STACKPHOT_SINGLE_PSPHOT STR STACKPHOT_SINGLE + BACKGROUND_PPBACKGROUND STR BACKGROUND + BACKGROUND_PSWARP STR BACKGROUND + PSVIDEOPHOT STR PSVIDEOPHOT + STATICSKY_CALIBRATION STR STATICSKY_CAL +END + CNP_DATASET METADATA CHIP_PPIMAGE STR CHIP Index: trunk/ppImage/src/Makefile.am =================================================================== --- trunk/ppImage/src/Makefile.am (revision 35530) +++ trunk/ppImage/src/Makefile.am (revision 35531) @@ -65,5 +65,6 @@ ppImageMemory.c \ ppImageAddNoise.c \ - ppImageRandomGaussian.c + ppImageRandomGaussian.c \ + ppImageAuxiliaryMask.c CLEANFILES = *~ Index: trunk/ppImage/src/ppImage.h =================================================================== --- trunk/ppImage/src/ppImage.h (revision 35530) +++ trunk/ppImage/src/ppImage.h (revision 35531) @@ -30,4 +30,5 @@ bool doMaskLow; // mask low pixels bool doMask; // Mask bad pixels + bool doAuxMask; // apply auxillary mask bool doNonLin; // Non-linearity correction bool doOverscan; // Overscan subtraction @@ -126,4 +127,6 @@ psU16 maskstat_magic; psU16 maskstat_advisory; + + psString auxVideoMask; // auxillary video mask file } ppImageOptions; @@ -312,4 +315,5 @@ void ppImageRandomGaussianFree(void); +bool ppImageAuxiliaryMask(pmConfig *config, const pmFPAview *view, const ppImageOptions *options); #endif Index: trunk/ppImage/src/ppImageAuxiliaryMask.c =================================================================== --- trunk/ppImage/src/ppImageAuxiliaryMask.c (revision 35530) +++ trunk/ppImage/src/ppImageAuxiliaryMask.c (revision 35531) @@ -40,4 +40,16 @@ } +bool recordFileInHeader(pmChip *chip, psString tag, psString desc, psString filename) +{ + pmHDU *hdu = pmHDUGetHighest(chip->parent, chip, NULL); + + // strip off the directories and nebulous bits + char *base = filename; + for (char *new = base; (new = strpbrk(base, "/:")); base = new + 1); + + psMetadataAddStr(hdu->header, PS_LIST_TAIL, tag, PS_META_DUPLICATE_OK, desc, base); + return true; +} + // In this function, we augment the mask with the more conservative auxiliary mask bool ppImageAuxiliaryMask(pmConfig *config, const pmFPAview *view, const ppImageOptions *options) @@ -51,5 +63,6 @@ } - bool status; // Status of MD lookup + bool status; + // Our target chip pmFPAfile *input = psMetadataLookupPtr(&status, config->files, "PPIMAGE.CHIP"); // File to correct if (!status) { @@ -58,4 +71,6 @@ } + // Find a suitable detRun with type AUXMASK + psTime *time = psMetadataLookupPtr(NULL, input->fpa->concepts, "FPA.TIME"); if (time->sec == 0 && time->nsec == 0) { @@ -63,5 +78,4 @@ } - // XXX careful about this: is this set correctly in the camera.config files? char *cameraName = psMetadataLookupStr(NULL, input->fpa->concepts, "FPA.CAMERA"); pmDetrendSelectOptions *detrendOptions = pmDetrendSelectOptionsAlloc(cameraName, *time, PM_DETREND_TYPE_AUXMASK); @@ -80,18 +94,6 @@ } -#ifdef notdef - psMetadata *ppImageRecipe = psMetadataLookupPtr(NULL, config->recipes, RECIPE_NAME); - psAssert(ppImageRecipe, "Need PPIMAGE recipe"); - psMetadata *psphotRecipe = psMetadataLookupPtr(NULL, config->recipes, PSPHOT_RECIPE); - psAssert(psphotRecipe, "Need PSPHOT recipe"); - - // XXX Should this be options->maskValue or options->maskValue & ~options->satMask? - // The latter will leave saturated pixels high - psImageMaskType maskVal = options->maskValue; - - // user-defined masks to test for good/bad pixels (build from recipe list if not yet set) - psMetadataAddImageMask(psphotRecipe, PS_LIST_TAIL, "MASK.PSPHOT", PS_META_REPLACE, "user-defined mask", maskVal); -#endif - + // Go find the readout + // code to find the readouts was adapted from ppImageSubtractBackground // XXX: shouldn't most of these psWarnings be psAsserts? @@ -129,5 +131,5 @@ psImage *mask = ro->mask; - // now read the mask file + // now read the auxiliary mask file psString class_id = psMetadataLookupStr(NULL, chip->concepts, "CHIP.NAME"); @@ -139,9 +141,13 @@ psFree(results); + // record that we read this file in the config dump file. + // Note: this value isn't used during updates though. + pmConfigRunFilenameAddRead(config, "PPIMAGE.AUXMASK", auxMaskFileName); + recordFileInHeader(chip, "DETREND.AUXMASK", "auxiliary mask", auxMaskFileName); psImage *auxMask = readAuxiliaryMask(config, auxMaskFileName); psFree(auxMaskFileName); if (!auxMask) { - // readAuxiliaryMask prints enough diagnostic information + psError(PS_ERR_UNKNOWN, false, "failed to read auxiliary mask file"); return false; } @@ -151,7 +157,11 @@ psImage *videoMask = readAuxiliaryMask(config, options->auxVideoMask); if (!videoMask) { + psError(PS_ERR_UNKNOWN, false, "failed to read auxiliary video mask file"); return false; } - // auxMask *= videoMask + pmConfigRunFilenameAddRead(config, "PPIMAGE.AUXVIDEOMASK", options->auxVideoMask); + recordFileInHeader(chip, "DETREND.AUXVIDEOMASK", "auxiliary video mask", options->auxVideoMask); + + // compute auxMask *= videoMask if (!psBinaryOp(auxMask, auxMask, "*", videoMask)) { psError(PS_ERR_UNKNOWN, false, "mulitplication of auxiliary mask and auxiliary video mask failed"); Index: trunk/ppImage/src/ppImageDetrendReadout.c =================================================================== --- trunk/ppImage/src/ppImageDetrendReadout.c (revision 35530) +++ trunk/ppImage/src/ppImageDetrendReadout.c (revision 35531) @@ -50,5 +50,5 @@ char *Vptr = strchr(psMetadataLookupStr(NULL,input->parent->parent->hdu->header,"CELLMODE"),'V'); if (Vptr) { - hasVideo = true; + hasVideo = options->hasVideo = true; psLogMsg ("ppImage.detrend", PS_LOG_INFO, "VIDEO: %d %d %d\n",(int) options->hasVideo,(int) options->useVideoDark, (int) options->useVideoMask); } Index: trunk/ppImage/src/ppImageLoop.c =================================================================== --- trunk/ppImage/src/ppImageLoop.c (revision 35530) +++ trunk/ppImage/src/ppImageLoop.c (revision 35531) @@ -188,4 +188,9 @@ ESCAPE("Unable to mosaic chip"); } + + if (!ppImageAuxiliaryMask(config, view, options)) { + ESCAPE("Unable to apply auxiliary mask"); + } + timeDetrend += psTimerClear(TIMER_DETREND); Index: trunk/ppImage/src/ppImageOptions.c =================================================================== --- trunk/ppImage/src/ppImageOptions.c (revision 35530) +++ trunk/ppImage/src/ppImageOptions.c (revision 35531) @@ -10,4 +10,5 @@ // psFree(options->nonLinearData); // psFree(options->nonLinearSource); + psFree(options->auxVideoMask); } @@ -24,4 +25,5 @@ options->doVarianceBuild = false; // Build internal variance options->doMask = false; // Mask bad pixels + options->doAuxMask = false; // apply auxillary mask options->doNonLin = false; // Non-linearity correction options->doOverscan = false; // Overscan subtraction @@ -116,4 +118,6 @@ options->normClass = NULL; // per-class normalizations refer to this class + options->auxVideoMask = NULL; // auxillary video mask file name + return options; } @@ -228,4 +232,14 @@ options->doMaskBurntool = psMetadataLookupBool(NULL, recipe, "MASK.BURNTOOL"); options->doVarianceBuild = psMetadataLookupBool(NULL, recipe, "VARIANCE.BUILD"); + options->doAuxMask = psMetadataLookupBool(NULL, recipe, "MASK.AUXMASK"); + if (options->doAuxMask) { + // if we are applying an auxiliary mask we can optionally apply another + // mask to video cells only. + psString auxVideoMask = psMetadataLookupStr(NULL, recipe, "AUX.VIDEO.MASK"); + // save the value if defined and not the value "NULL" + if (auxVideoMask && strcmp(auxVideoMask, "NULL")) { + options->auxVideoMask = psStringCopy(auxVideoMask); + } + } // Mask recipe options (note that mask bit values are set in ppImageSetMaskBits.c) Index: trunk/psModules/src/detrend/pmDetrendDB.c =================================================================== --- trunk/psModules/src/detrend/pmDetrendDB.c (revision 35530) +++ trunk/psModules/src/detrend/pmDetrendDB.c (revision 35531) @@ -110,4 +110,5 @@ DETREND_STRING_CASE(VIDEODARK); DETREND_STRING_CASE(LINEARITY); + DETREND_STRING_CASE(AUXMASK); default: return NULL; Index: trunk/psModules/src/detrend/pmDetrendDB.h =================================================================== --- trunk/psModules/src/detrend/pmDetrendDB.h (revision 35530) +++ trunk/psModules/src/detrend/pmDetrendDB.h (revision 35531) @@ -39,4 +39,5 @@ PM_DETREND_TYPE_VIDEODARK, PM_DETREND_TYPE_LINEARITY, + PM_DETREND_TYPE_AUXMASK, } pmDetrendType;