# # ChangeLog for trunk # # Generated by Trac 1.6 # Jul 23, 2026, 1:41:44 PM Sat, 09 Aug 2008 01:48:28 GMT bills [18986] * trunk/pstamp/scripts/pstamp_results_file.pl (modified) * trunk/pstamp/scripts/pstamp_runcommand.sh (modified) * trunk/pstamp/scripts/pstamp_webrequest.pl (modified) pass along verbose if provided Sat, 09 Aug 2008 01:47:34 GMT bills [18985] * trunk/pstamp/scripts/pstampparse.pl (modified) Major re-work to get image data from the database. Supports looking ... Sat, 09 Aug 2008 01:46:22 GMT bills [18984] * trunk/pstamp/scripts/request_finish.pl (modified) add request file paramters to results Sat, 09 Aug 2008 01:45:45 GMT bills [18983] * trunk/pstamp/scripts/pstamp_finish.pl (modified) add request parameters from request file to the results file Sat, 09 Aug 2008 01:44:11 GMT bills [18982] * trunk/pstamp/scripts/dquery_finish.pl (modified) use :standard to import symbols add -req_file arg Sat, 09 Aug 2008 01:43:20 GMT bills [18981] * trunk/pstamp/src/ppstampMakeStamp.c (modified) simplify the extractStamp function to prepare to move it to pslib, ... Sat, 09 Aug 2008 01:42:38 GMT bills [18980] * trunk/pstamp/src/ppstampArguments.c (modified) added arguments for mask and weight images. Not used yet Sat, 09 Aug 2008 01:39:04 GMT bills [18979] * trunk/pstamp/lib (added) * trunk/pstamp/lib/PStamp (added) * trunk/pstamp/lib/PStamp.pm (added) * trunk/pstamp/lib/PStamp/Job.pm (added) * trunk/pstamp/lib/PStamp/RequestFile.pm (added) Adding a perl module to support the Postage Stamp Server Sat, 09 Aug 2008 01:14:06 GMT Paul Price [18978] * trunk/ippconfig/recipes/ppImage.config (modified) * trunk/ippconfig/sdssmosaic/camera.config (modified) * trunk/ippconfig/sdssmosaic/format.config (modified) * trunk/ippconfig/sdssmosaic/ppImage.config (modified) * trunk/ippconfig/sdssmosaic/psastro.config (modified) Merging Sebastian's tree: config file changes to ... Sat, 09 Aug 2008 01:12:17 GMT Paul Price [18977] * trunk/psconfig/INSTALL (modified) * trunk/psconfig/psconfig.bash.in (modified) Merging Sebastian's tree: added '-f' to all csh calls to make startup ... Fri, 08 Aug 2008 23:23:42 GMT bills [18976] * trunk/ippTools/src/chiptool.c (modified) * trunk/ippTools/src/chiptoolConfig.c (modified) * trunk/ippTools/src/difftool.c (modified) * trunk/ippTools/src/difftoolConfig.c (modified) * trunk/ippTools/src/stacktool.c (modified) * trunk/ippTools/src/stacktoolConfig.c (modified) * trunk/ippTools/src/warptool.c (modified) * trunk/ippTools/src/warptoolConfig.c (modified) in lookup modes allow selecting by exp_name Fri, 08 Aug 2008 22:37:49 GMT bills [18975] * trunk/ippTools/share/difftool_skyfile.sql (modified) * trunk/ippTools/share/stacktool_sumskyfile.sql (modified) * trunk/ippTools/share/warptool_warped.sql (modified) * trunk/ippTools/src/difftool.c (modified) * trunk/ippTools/src/difftoolConfig.c (modified) * trunk/ippTools/src/stacktool.c (modified) * trunk/ippTools/src/stacktoolConfig.c (modified) * trunk/ippTools/src/warptool.c (modified) In the modes for difftool, stacktool, and warptool that print out ... Fri, 08 Aug 2008 22:37:00 GMT bills [18974] * trunk/ippTools/src/pstamptool.c (modified) * trunk/ippTools/src/pstamptoolConfig.c (modified) ds_id is an int not a string Fri, 08 Aug 2008 19:46:24 GMT eugene [18973] * trunk/psphot/src/psphotReadout.c (modified) test save ignored Fri, 08 Aug 2008 19:42:36 GMT eugene [18972] * trunk/psModules/src/camera/pmFPAMosaic.c (modified) skipping video cells Fri, 08 Aug 2008 19:41:56 GMT eugene [18971] * trunk/psModules/src/astrom/pmAstrometryTable.c (modified) * trunk/psModules/src/objects/pmPeaks.c (modified) * trunk/psModules/src/objects/pmPeaks.h (modified) insignificant Fri, 08 Aug 2008 19:01:19 GMT eugene [18970] * trunk/ippMonitor/def/camPendingExp.d (modified) * trunk/ippMonitor/def/camProcessedExp.d (modified) * trunk/ippMonitor/def/camProcessedExp_NoImages.d (modified) * trunk/ippMonitor/def/camProcessedExp_failure.d (modified) * trunk/ippMonitor/def/camStageExp.d (modified) * trunk/ippMonitor/def/chipPendingExp.d (modified) * trunk/ippMonitor/def/chipPendingImfile.d (modified) * trunk/ippMonitor/def/chipProcessedImfile.d (modified) * trunk/ippMonitor/def/chipProcessedImfile_failure.d (modified) * trunk/ippMonitor/raw/ipp.php (modified) various updates Fri, 08 Aug 2008 19:00:55 GMT eugene [18969] * branches/eam_branch_20080719/psModules/src/camera/pmFPAMosaic.c (modified) * trunk/ppImage/src/ppImageDetrendFringe.c (modified) * trunk/ppImage/src/ppImageLoop.c (modified) * trunk/ppStats/src/ppStatsChip.c (modified) skipping video cells Fri, 08 Aug 2008 18:17:42 GMT Paul Price [18968] * trunk/ippconfig/recipes/ppSub.config (modified) Multiple rejections are generally unnecessary now. Fri, 08 Aug 2008 18:17:12 GMT Paul Price [18967] * trunk/ppMerge/src/ppMerge.h (modified) * trunk/ppMerge/src/ppMergeArguments.c (modified) * trunk/ppMerge/src/ppMergeCamera.c (modified) * trunk/ppMerge/src/ppMergeLoop_Threaded.c (modified) * trunk/ppMerge/src/ppMergeReadChunk.c (modified) * trunk/ppMerge/src/ppMergeSetThreads.c (modified) * trunk/pswarp/src/pswarpTransformReadout.c (modified) Fixing following changes to psThread. Fri, 08 Aug 2008 18:16:18 GMT Paul Price [18966] * trunk/pswarp/src/pswarpSetThreads.c (modified) Fixing memork leak. Fri, 08 Aug 2008 18:14:28 GMT Paul Price [18965] * trunk/pswarp/src/pswarpTransformReadout_Threaded.c (modified) psThreadPoolWait requires parameter now. Fri, 08 Aug 2008 18:13:56 GMT Paul Price [18964] * trunk/pswarp/src/pswarpTransformReadout_Threaded.c (modified) Need to free job, following changes to psThread. Fri, 08 Aug 2008 18:12:50 GMT Paul Price [18963] * trunk/ppSub/src/ppSubArguments.c (modified) Adding threading support. Fri, 08 Aug 2008 18:10:29 GMT Paul Price [18962] * trunk/psModules/src/imcombine/Makefile.am (modified) * trunk/psModules/src/imcombine/pmSubtraction.c (modified) * trunk/psModules/src/imcombine/pmSubtractionEquation.c (modified) * trunk/psModules/src/imcombine/pmSubtractionEquation.h (modified) * trunk/psModules/src/imcombine/pmSubtractionMatch.c (modified) * trunk/psModules/src/imcombine/pmSubtractionMatch.h (modified) * trunk/psModules/src/imcombine/pmSubtractionThreads.c (added) * trunk/psModules/src/imcombine/pmSubtractionThreads.h (added) * trunk/psModules/src/psmodules.h (modified) Adding threads to pmSubtractionCalculateEquation and ... Fri, 08 Aug 2008 18:09:29 GMT Paul Price [18961] * trunk/psModules/src/config/pmConfigMask.c (modified) Fixing memory leak. Fri, 08 Aug 2008 18:09:07 GMT Paul Price [18960] * trunk/psModules/src/detrend/pmBias.c (modified) * trunk/psModules/src/detrend/pmBias.h (modified) * trunk/psModules/src/detrend/pmDark.c (modified) * trunk/psModules/src/detrend/pmDark.h (modified) * trunk/psModules/src/detrend/pmDetrendThreads.c (modified) * trunk/psModules/src/detrend/pmFlatField.c (modified) * trunk/psModules/src/detrend/pmFlatField.h (modified) * trunk/psModules/src/detrend/pmShutterCorrection.c (modified) * trunk/psModules/src/detrend/pmShutterCorrection.h (modified) Fixing to match slight differences in psThread Fri, 08 Aug 2008 18:08:00 GMT Paul Price [18959] * trunk/psLib/configure.ac (modified) Adding support for FFTW threading. Fri, 08 Aug 2008 18:07:49 GMT Paul Price [18958] * trunk/psLib/src/pslib_strict.h (modified) Adding FFT threading header. Fri, 08 Aug 2008 18:07:30 GMT Paul Price [18957] * trunk/psLib/src/imageops/psImageConvolve.c (modified) Working psImageConvolveMask into threads, since it can take a while. Fri, 08 Aug 2008 18:06:51 GMT Paul Price [18956] * trunk/psLib/src/fft/Makefile.am (modified) * trunk/psLib/src/fft/psFFT.c (added) * trunk/psLib/src/fft/psFFT.h (added) Adding function to initiate FFT threading. Fri, 08 Aug 2008 18:06:27 GMT Paul Price [18955] * trunk/psLib/src/types/psList.c (modified) * trunk/psLib/src/types/psList.h (modified) Fixing memory problem with psListGetAndRemove. This function must ... Fri, 08 Aug 2008 18:05:34 GMT Paul Price [18954] * trunk/psLib/src/types/psArray.h (modified) Adding PS_ARRAY_ADD_SCALAR Fri, 08 Aug 2008 18:05:09 GMT Paul Price [18953] * trunk/psLib/src/sys/psConfigure.c (modified) * trunk/psLib/src/sys/psThread.c (modified) * trunk/psLib/src/sys/psThread.h (modified) Cleaning up thread functions, documenting header. Added 'harvest' ... Fri, 08 Aug 2008 03:53:09 GMT bills [18952] * trunk/ippTools/share/difftool_skyfile.sql (modified) if it isn't tested it doesn't work Fri, 08 Aug 2008 03:41:36 GMT bills [18951] * trunk/ippTools/share/stacktool_sumskyfile.sql (modified) in mode -sumskyfile don't require state to be run and output the state Fri, 08 Aug 2008 03:40:54 GMT bills [18950] * trunk/ippTools/share/warptool_warped.sql (modified) in mode -warped don't require state to be 'run' and output the state Fri, 08 Aug 2008 03:40:18 GMT bills [18949] * trunk/ippTools/share/difftool_skyfile.sql (modified) For mode -diffskyfile don't require state to be run, output the state Fri, 08 Aug 2008 03:32:05 GMT bills [18948] * trunk/ippTools/share/chiptool_processedimfile.sql (modified) Add chipRun.state to the output of -processedimfile Thu, 07 Aug 2008 20:24:19 GMT bills [18947] * trunk/ippTasks/site.mhpcc.pro (modified) Stop using ipp005 and ipp016 jobs since they're out of chiphosts ... Thu, 07 Aug 2008 20:22:28 GMT bills [18946] * trunk/ippTasks/chiphosts.mhpcc.config (modified) Rebalancing of the chiphosts Stop using ipp005 since it's flaky ... Wed, 06 Aug 2008 21:57:29 GMT Paul Price [18944] * trunk/psModules/src/config/pmConfigCamera.c (modified) pmConfigCameraSkycellVersion went AWOL when I was editing. Wed, 06 Aug 2008 03:40:45 GMT Paul Price [18939] * trunk/psModules/src/config/pmConfigCamera.c (modified) * trunk/psModules/src/config/pmConfigCamera.h (modified) * trunk/psModules/src/config/pmConfigDump.c (modified) Don't get rid of derivative cameras when culling in preparation for dump. Wed, 06 Aug 2008 03:09:23 GMT Paul Price [18938] * trunk/ippTools/src/dettoolConfig.c (modified) det_id isn't required for dettool -revertprocessedimfile. Wed, 06 Aug 2008 03:07:36 GMT Paul Price [18937] * trunk/psModules/src/config/pmConfigCommand.c (modified) Switching over to new system, using pmConfigUserSite. Wed, 06 Aug 2008 03:04:42 GMT Paul Price [18935] * trunk/ippTasks/detrend.process.pro (modified) --verbose is added by add_standard_args Wed, 06 Aug 2008 03:02:24 GMT Paul Price [18934] * trunk/ippScripts/scripts/warp_skycell.pl (modified) Log, not trace. Wed, 06 Aug 2008 02:49:37 GMT Paul Price [18933] * trunk/Ohana/configure.tcsh (modified) Need to initialise variable. Wed, 06 Aug 2008 02:35:40 GMT Paul Price [18932] * trunk/PS-IPP-Config/lib/PS/IPP/Metadata/Stats.pm (modified) Another. Wed, 06 Aug 2008 02:24:14 GMT Paul Price [18931] * trunk/PS-IPP-Config/lib/PS/IPP/Metadata/Stats.pm (modified) Suppress error: Use of uninitialized value in multiplication (*) at ... Wed, 06 Aug 2008 02:08:29 GMT Paul Price [18930] * trunk/ppMerge/src/ppMergeScaleZero.c (modified) Mask value isn't available until images have been read in. Wed, 06 Aug 2008 01:42:49 GMT Paul Price [18929] * trunk/ippconfig/site.config.in (modified) Adding database port. Wed, 06 Aug 2008 01:21:49 GMT jhoblitt [18928] * trunk/ippTools/src/pzgetexp.c (modified) increase memory table size limit Wed, 06 Aug 2008 01:13:35 GMT Paul Price [18927] * trunk/ippTools/src/pxadmin.c (modified) * trunk/ippTools/src/pxadminConfig.c (modified) Using new function to get database details from user/site configuration. Wed, 06 Aug 2008 01:13:14 GMT Paul Price [18926] * trunk/psModules/src/config/pmConfig.c (modified) * trunk/psModules/src/config/pmConfig.h (modified) Adding function pmConfigUserSite to get values from the user/site ... Wed, 06 Aug 2008 01:08:20 GMT Paul Price [18925] * trunk/psconfig/psbuild (modified) In bash, aliases are not interpolated after the file is read, so we ... Wed, 06 Aug 2008 00:39:59 GMT Paul Price [18924] * trunk/pswarp/src/pswarp.c (modified) * trunk/pswarp/src/pswarpArguments.c (modified) * trunk/pswarp/src/pswarpLoop.c (modified) * trunk/pswarp/src/pswarpParseCamera.c (modified) Adding configuration dumping. Required reorganisation of how recipe ... Tue, 05 Aug 2008 22:23:33 GMT Paul Price [18921] * trunk/psModules/src/config/pmConfig.c (modified) Take database information from user or site configuration. Tue, 05 Aug 2008 21:52:02 GMT Paul Price [18920] * trunk/ppSub/src/ppSubArguments.c (modified) * trunk/ppSub/src/ppSubCamera.c (modified) * trunk/ppSub/src/ppSubLoop.c (modified) * trunk/ppSub/src/ppSubReadout.c (modified) Adding configuration dumping. Required reorganisation of how recipe ... Tue, 05 Aug 2008 21:28:13 GMT jhoblitt [18919] * trunk/ippTools/src/pzgetexp.c (modified) * trunk/ippTools/src/pzgetexpConfig.c (modified) add -all opt Tue, 05 Aug 2008 21:18:27 GMT Paul Price [18918] * trunk/ppStack/src/ppStackArguments.c (modified) * trunk/ppStack/src/ppStackLoop.c (modified) * trunk/ppStack/src/ppStackMatch.c (modified) * trunk/ppStack/src/ppStackPSF.c (modified) * trunk/ppStack/src/ppStackReadout.c (modified) * trunk/ppStack/src/ppStackSources.c (modified) Adding configuration dumping. Required reorganisation of how recipe ... Tue, 05 Aug 2008 20:25:15 GMT Paul Price [18917] * trunk/ppImage/src/ppImageLoop.c (modified) No need for #ifdef. Tue, 05 Aug 2008 20:10:53 GMT Paul Price [18916] * trunk/ippTasks/warp.pro (modified) Fixing output directory name so it's not just a number. Tue, 05 Aug 2008 20:10:36 GMT Paul Price [18915] * trunk/ippTools/share/warptool_tooverlap.sql (modified) Want exp_tag for output directory name. Tue, 05 Aug 2008 19:19:40 GMT Paul Price [18914] * trunk/ppConfigDump/src/ppConfigDump.c (modified) * trunk/psastro/src/psastroLoadRefstars.c (modified) * trunk/psphot/src/psphotOutput.c (modified) * trunk/pswarp/src/pswarpDefineSkycell.c (modified) config->complete has been removed. Tue, 05 Aug 2008 16:55:45 GMT bills [18913] * trunk/DataStore/lib/DataStore/Utils.pm (modified) Add Fileset type OOF Tue, 05 Aug 2008 03:47:15 GMT Paul Price [18909] * trunk/ppImage/src/ppImageLoop.c (modified) Dump configuration. Tue, 05 Aug 2008 03:45:56 GMT Paul Price [18908] * trunk/psModules/src/camera/pmFPAfileDefine.c (modified) * trunk/psModules/src/config/pmConfig.c (modified) * trunk/psModules/src/config/pmConfig.h (modified) * trunk/psModules/src/config/pmConfigCommand.c (modified) * trunk/psModules/src/config/pmConfigDump.c (modified) * trunk/psModules/src/config/pmConfigRecipes.c (modified) Removing use of pmConfig.complete in favour of proper use of what's ... Tue, 05 Aug 2008 02:36:25 GMT Paul Price [18907] * trunk/psModules/src/objects/pmFootprintFind.c (modified) Casting away const to satisfy compiler. Tue, 05 Aug 2008 02:16:32 GMT Paul Price [18906] * trunk/ippconfig/system.config (modified) Adding file naming rules for configuration dumps. Tue, 05 Aug 2008 02:16:06 GMT Paul Price [18905] * trunk/psModules/src/camera/pmFPAview.c (modified) * trunk/psModules/src/camera/pmFPAview.h (modified) * trunk/psModules/src/config/Makefile.am (modified) * trunk/psModules/src/config/pmConfig.c (modified) * trunk/psModules/src/config/pmConfig.h (modified) * trunk/psModules/src/config/pmConfigDump.c (added) * trunk/psModules/src/config/pmConfigDump.h (added) * trunk/psModules/src/psmodules.h (modified) Adding functions to dump configuration to an MDC file on disk, so we ... Tue, 05 Aug 2008 02:13:25 GMT bills [18904] * trunk/ippTasks/summit.copy.pro (modified) Add timeout to pzgetexp and extend the task's timeout value Tue, 05 Aug 2008 02:12:55 GMT bills [18903] * trunk/ippTasks/pstamp.pro (modified) remove an echo Tue, 05 Aug 2008 02:09:30 GMT Paul Price [18902] * trunk/psModules/src/objects/pmFootprintFind.c (modified) Fixing compilation error. Tue, 05 Aug 2008 02:08:44 GMT Paul Price [18901] * trunk/psModules/src/objects/pmFootprintFind.c (modified) Support for other image types (esp U8 which now comes from having ... Tue, 05 Aug 2008 01:51:57 GMT Paul Price [18900] * trunk/psModules/src/objects/pmFootprintArrayGrow.c (modified) Removing need for additional image allocation. Tue, 05 Aug 2008 01:41:15 GMT eugene [18899] * trunk/doc/plan/ipp.status.2008.08.txt (modified) adding update work from PAP and WS Tue, 05 Aug 2008 01:36:17 GMT Paul Price [18898] * trunk/psModules/src/objects/pmFootprintArrayGrow.c (modified) Wrong operation! Tue, 05 Aug 2008 01:26:25 GMT eugene [18897] * trunk/ippconfig/recipes/ppImage.config (modified) adding recipe option to control number of rows processed per thread Tue, 05 Aug 2008 01:25:58 GMT eugene [18896] * trunk/ppImage/src/ppImageParseCamera.c (modified) turning on multithreads if desired Tue, 05 Aug 2008 01:25:43 GMT eugene [18895] * trunk/ppImage/src/ppImageArguments.c (modified) adding -threads option for multithreading Tue, 05 Aug 2008 01:25:20 GMT eugene [18894] * trunk/ppImage/src/ppImageLoop_Threaded.c (modified) moving threading down into psModules functions Tue, 05 Aug 2008 01:24:47 GMT eugene [18893] * trunk/psModules/src/detrend/Makefile.am (modified) * trunk/psModules/src/detrend/pmBias.c (modified) * trunk/psModules/src/detrend/pmBias.h (modified) * trunk/psModules/src/detrend/pmDark.c (modified) * trunk/psModules/src/detrend/pmDark.h (modified) * trunk/psModules/src/detrend/pmDetrendThreads.c (added) * trunk/psModules/src/detrend/pmDetrendThreads.h (added) * trunk/psModules/src/detrend/pmFlatField.c (modified) * trunk/psModules/src/detrend/pmFlatField.h (modified) * trunk/psModules/src/detrend/pmShutterCorrection.c (modified) * trunk/psModules/src/detrend/pmShutterCorrection.h (modified) * trunk/psModules/src/psmodules.h (modified) adding threaded and unthreaded versions of the detrend application ... Tue, 05 Aug 2008 01:23:59 GMT eugene [18892] * trunk/psLib/src/mathtypes/psScalar.h (modified) adding a macro for looking up data on a scalar Mon, 04 Aug 2008 22:45:42 GMT Paul Price [18891] * trunk/psLib/m4/ipp_stdopts.m4 (modified) Quote so that comma is not interpreted as a break. Mon, 04 Aug 2008 21:50:51 GMT Paul Price [18890] * trunk/pswarp/src/pswarpTransformTile.c (modified) Bounds for iteration were broken: was getting SEGV when running with ... Mon, 04 Aug 2008 21:49:55 GMT Paul Price [18889] * trunk/ippTools/src/warptool.c (modified) Fixing: "Failed to execute SQL query. Error: Column 'fault' in where ... Mon, 04 Aug 2008 21:48:50 GMT bills [18888] * trunk/ippTools/src/chiptool.c (modified) one more fix Mon, 04 Aug 2008 21:38:07 GMT bills [18887] * trunk/ippTools/src/chiptool.c (modified) fixed a couple more bugs in chiptool -processedimfile Mon, 04 Aug 2008 21:31:29 GMT bills [18886] * trunk/ippTools/share/chiptool_processedimfile.sql (modified) add exp_id to output of chiptool -processedimfile Mon, 04 Aug 2008 21:31:02 GMT jhoblitt [18885] * trunk/ippTools/src/chiptool.c (modified) bug fix Mon, 04 Aug 2008 21:12:16 GMT Paul Price [18884] * trunk/pswarp/src/pswarpTransformReadout.c (modified) * trunk/pswarp/src/pswarpTransformReadout_Threaded.c (modified) Removing print to stderr outside of trace. Mon, 04 Aug 2008 21:06:47 GMT Paul Price [18883] * trunk/ippconfig/megacam/pswarp.config (modified) Source for astrometry should be camera level --> PSASTRO.OUTPUT.MEF. Mon, 04 Aug 2008 20:33:26 GMT Paul Price [18882] * trunk/ippconfig/recipes/reductionClasses.mdc (modified) Need FAKEPHOT in each reduction class. Mon, 04 Aug 2008 18:43:58 GMT eugene [18881] * trunk/doc/plan/ipp.status.2008.08.txt (modified) updated notes on current status Mon, 04 Aug 2008 03:26:21 GMT eugene [18878] * trunk/Ohana/configure.tcsh (modified) * trunk/psconfig/psbuild (modified) adding options for profiler code Mon, 04 Aug 2008 03:25:07 GMT eugene [18877] * trunk/ippScripts/scripts/detrend_norm_apply.pl (modified) * trunk/ippScripts/scripts/detrend_stack.pl (modified) using clipped mean for detrend normalization Sun, 03 Aug 2008 20:55:09 GMT eugene [18876] * trunk/psLib/src/math/psStats.c (modified) * trunk/psLib/src/math/psStats.h (modified) added a tmpData and tmpMask element to psStats for multithreading ... Sat, 02 Aug 2008 03:07:13 GMT Paul Price [18871] * trunk/ippTools/src/chiptool.c (modified) Search for files to revert based on fault code. Sat, 02 Aug 2008 02:53:02 GMT Paul Price [18870] * trunk/psphot/src/psphotSourceSize.c (modified) Can't convolve mask in-place if values to set contains values to ...