id	summary	reporter	owner	description	type	status	priority	milestone	component	version	severity	resolution	keywords	cc
404	psConstants.h defines unnecessary constants	Paul Price	robert.desonia@…	"psConstants.h contains the following definitions:

> #define PS_ONE 1.0
> #define PS_PI   3.1415926535897932384626433832795029  /* pi */
> #define PS_PI_2 1.5707963267948966192313216916397514  /* pi/2 */
> #define PS_PI_4 0.7853981633974483096156608458198757  /* pi/4 */
> #define PS_1_PI 0.3183098861837906715377675267450287  /* 1/pi */
> #define PS_2_PI 0.6366197723675813430755350534900574  /* 2/pi */
> #define PS_COT(X) (1.0 / atan(X))

* It is unnecessary to define the value of 1.
* The multiples of pi are generally available in math.h (M_PI; though this may
be an extension).
* The definition of the co-tangent is incorrect --- it should be 1/tan(x)."	defect	closed	low		types	0.5.0	trivial	fixed