IPP Software Navigation Tools IPP Links Communication Pan-STARRS Links

Ticket #386: pmObjects-notes.txt

File pmObjects-notes.txt, 2.4 KB (added by eugene, 21 years ago)

changes made to pmObjects.c

Line 
1* pmObjects.c:
2
3 - changed psModel.params & psModel.dparams to psVector
4 - adjusted pmModelAlloc to match
5 - added default to source->type (pmSourceAlloc)
6 - changed return value for pmFindImagePeaks to psArray from psList
7 - changed MyListAddPeak to reflect change to psArray
8 - fixed error in pmFindImagePeaks:
9 tmpRow = p_psGetRowVectorFromImage((psImage *) image, row);
10 changed '0' to 'row'
11 NOTE: also fixed by George
12 - added pmPeaksSubset to replace pmCullPeaks: returns a new array
13 with a subset of the peaks.
14 - added tests in pmSourceLocalSky to keep subimage on main image
15 NOTE: also fixed by George
16 - CheckRadius2 seems inefficient, but I did not change it
17 (function should be inlined; we should store and compare against
18 radius2, not radius)
19 NOTE: looks like these were changed to macros
20 - added code to pmSourceMoments to do the second-order moments in
21 two passes rather than one, but since it made no impact, it is
22 ifdef'ed out.
23 - forced the Sx,Sy values in pmSourceMoments to bottom-out at 0.0
24 - added pmComparePeakAscend and pmComparePeakDescend functions
25 (used by pmSourceRoughClass)
26 - implemented the pmSourceRoughClass as I envisioned it
27 - added tests in pmSourceSetPixelCircle to keep subimage on main image
28 - fixed definitions of radius in pmSourceSetPixelsCircle
29 NOTE: also fixed by George
30 - inverted meaning of mask in pmSourceSetPixelsCircle
31 (0 - valid, 1 - invalid)
32 - changed source->models->params to vectors in pmSourceModelGuess,
33 - changed source->models->params to vectors in evalModel
34 - evalModel declared static
35 - findValue declared static
36 - modified default TOLERANCE, NUM_ITERATIONS in pmSourceFitModel
37 - added the yErr entry to the model fit
38 (yErr is currently set approximately -- needs GAIN & RDNOISE)
39 - changed the psMinimizeLMChi2 calls to work with the psF64 versions
40 of the models rather than the _Vec versions (to match the API for
41 psMinimizeLMChi2)
42 - added elements nDOF and nIter to pmModel
43 - set nDOF and nIter after fit result
44
45 * for all of the models:
46 - dropped the input checking for speed
47 (allow for #ifdef in/out?)
48 (these functions are only called by psMinimizeLMChi2, so should already be valid)
49 - dropped the _Vec versions of the model functions
50 - changed return type of scalar versions of functions to psF64
51 (allows the cast of psMinimizeLMChi2Func to be dropped in
52 pmSourceFit)