Changeset 10546 for trunk/Nebulous/lib

Timestamp:

Dec 7, 2006, 5:29:19 PM (20 years ago)

Author:

jhoblitt

Message:

change Nebulous::Server instantiate objects (init -> new) instead of working with class data
add a DESTROY method to Nebulous::Server to tear down the database connection

File:

• trunk/Nebulous/lib/Nebulous/Server.pm (modified) (18 diffs)

trunk/Nebulous/lib/Nebulous/Server.pm

@@ -1 +1 @@
 # Copyright (c) 2004  Joshua Hoblitt
 #
-# $Id: Server.pm,v 1.19 2005-12-03 02:32:56 jhoblitt Exp $
+# $Id: Server.pm,v 1.20 2006-12-08 03:29:19 jhoblitt Exp $
 
 package Nebulous::Server;
@@ -8 +8 @@
 use warnings FATAL => qw( all );
 
-our $VERSION = '0.02';
+our $VERSION = '0.03';
+
+use base qw( Class::Accessor::Fast );
 
 use DBI;
@@ -18 +20 @@
 use Params::Validate qw( validate_pos SCALAR );
 
-my $log;
-my $sql;
-my $db;
-
-sub init {
-    my $self = shift;
+__PACKAGE__->mk_accessors(qw( log sql db ));
+
+sub new {
+    my $class = shift;
 
     # let Nebulous::Server::Config validate our params
@@ -31 +31 @@
     Nebulous::Server::Log->init;
 
-    $log = Log::Log4perl::get_logger( "Nebulous::Server" );
-    $sql = Nebulous::Server::SQL->new;
-
-    $log->debug( "entered - @_" );
-
+    my $log = Log::Log4perl::get_logger( "Nebulous::Server" );
+    my $sql = Nebulous::Server::SQL->new;
+
+    $log->debug( "entered - @_" );
+
+    my $db;
     eval {
         $db = DBI->connect(
@@ -61 +62 @@
     $log->debug( "leaving" );
 
-    return 1;
+    my $self = bless {}, ref $class || $class;
+    $self->log($log);
+    $self->sql($sql);
+    $self->db($db);
+
+    return $self;
 }
 
@@ -76 +82 @@
                 'is + integer' => sub { $_[0] =~ /^\d+$/ },
                 # check that the class requested is valid
-                'is valid class id' => sub { _is_valid_class_id( $_[0] ) },
+                'is valid class id' => sub { $self->_is_valid_class_id( $_[0] ) },
             },
             default     => 0,
@@ -84 +90 @@
             callbacks   => {
                 # check that the volume requested is valid
-                'is valid volume name' => sub { _is_valid_volume_name($_[0]) },
+                'is valid volume name' => sub { $self->_is_valid_volume_name($_[0]) },
             },
             optional    => 1,
@@ -98 +104 @@
     );
 
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
+
     $log->debug( "entered - @_" );
 
     # TODO do some intelligent volume allocated 
     # add hooks to make this decision based on avaiable space
-    $volume = _get_storage_volume( $volume );
+    $volume = $self->_get_storage_volume( $volume );
 
     my $uri;
@@ -194 +204 @@
     );
 
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
+
     $log->debug( "entered - @_" );
 
     # TODO
-    $volume = _get_storage_volume();
+    $volume = $self->_get_storage_volume();
 
     my $path;
@@ -277 +291 @@
         },
     );
+
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
 
     $log->debug( "entered - @_" );
@@ -393 +411 @@
     );
 
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
+
     $log->debug( "entered - @_" );
 
@@ -514 +536 @@
     );
 
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
+
     $log->debug( "entered - @_" );
 
@@ -548 +574 @@
         },
     );
+
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
 
     $log->debug( "entered - @_" );
@@ -622 +652 @@
     );
 
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
+
     $log->debug( "entered - @_" );
 
@@ -649 +683 @@
 
 sub _get_storage_volume {
+    my $self = shift;
+
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
+
     no warnings qw( uninitialized );
     $log->debug( "entered - @_" );
@@ -690 +730 @@
 
 sub _is_valid_class_id {
-    my $class_id = shift;
+    my ($self, $class_id) = @_;
+
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  = $self->db;
 
     my $class;
@@ -709 +753 @@
 
 sub _is_valid_volume_name  {
-    my $vol_name = shift;
+    my ($self, $vol_name) = @_;
+
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
 
     my $volume;
     eval {
-        my $query = $db->prepare_cached( $sql->get_volume_by_name  ); 
+        my $query = $db->prepare_cached( $sql->get_volume_by_name ); 
         $query->execute( $vol_name );
         ( $volume ) = $query->fetchrow_array;
@@ -727 +775 @@
 }
 
+sub DESTROY {
+    my $self = shift;
+
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
+
+    $log->debug( "entered" );
+
+    $self->db->disconnect;        
+
+    $log->debug( "disconnected from database: ", sub { $db->data_sources; } );
+
+    $log->debug( "leaving" );
+}
+
 1;