Changeset 10719

Timestamp:

Dec 13, 2006, 10:29:46 PM (20 years ago)

Author:

eugene

Message:

rewrite tests to avoid div by zero

Location:

trunk/ippScripts/scripts

Files:

• detrend_reject_exp.pl (modified) (4 diffs)
• detrend_reject_imfile.pl (modified) (4 diffs)

trunk/ippScripts/scripts/detrend_reject_exp.pl

@@ -73 +73 @@
     push @means, $exposure->{bg};
     push @stdevs, $exposure->{bg_stdev};
-    push @meanStdevs, $exposure->{bg_mean_stdev} / $exposure->{bg};
+    # XXX why are we using mean_stdev / bd?
+    # push @meanStdevs, $exposure->{bg_mean_stdev} / $exposure->{bg};
+    push @meanStdevs, $exposure->{bg_mean_stdev};
     push @variances, $exposure->{bg_stdev}**2;
     push @accept, $exposure->{accept};
@@ -113 +115 @@
 
     if ($reject_mean and defined $meanStats->standard_deviation() ) {
-        my $nSigma = abs($means[$i] - $meanStats->mean() ) / $meanStats->standard_deviation();
-        if ($nSigma > $reject_mean) {
+        my $dMean = abs($means[$i] - $meanStats->mean()) ;
+        if ($dMean > ($reject_mean * $meanStats->standard_deviation())) {
             print "Rejecting $expTag based on outlier mean value: " .
-                "$means[$i] --> $nSigma sigma vs " . $reject_mean . "\n";
+                "$means[$i] --> $dMean vs " . $reject_mean * $meanStats->standard_deviation() . "\n";
             $reject = 1;
             goto UPDATE;
@@ -125 +127 @@
 
     if ($reject_stdev and defined $stdevStats->standard_deviation() > 0) {
-        my $nSigma = abs($stdevs[$i] - $stdevStats->mean() ) / $stdevStats->standard_deviation();
-        if ($nSigma > $reject_stdev) {
+        my $dMean = abs($stdevs[$i] - $stdevStats->mean());
+        if ($dMean > ($reject_stdev * $stdevStats->standard_deviation())) {
             print "Rejecting $expTag based on outlier stdev: " .
-                $stdevs[$i] . " --> $nSigma sigma vs " . $reject_stdev . "\n";
+                $stdevs[$i] . " --> $dMean sigma vs " . $reject_stdev . "\n";
             $reject = 1;
             goto UPDATE;
@@ -137 +139 @@
     
     if ($reject_meanstdev and defined $meanStdevStats->standard_deviation() > 0) {
-        my $nSigma = abs($meanStdevs[$i] - $meanStdevStats->mean() ) / $meanStdevStats->standard_deviation();
-        if ($nSigma > $reject_meanstdev) {
+        my $dMean = abs($meanStdevs[$i] - $meanStdevStats->mean());
+        if ($dMean > ($reject_meanstdev * $meanStdevStats->standard_deviation())) {
             print "Rejecting $expTag based on outlier mean stdev: " .
-                $meanStdevs[$i] . " --> $nSigma sigma vs " . $reject_meanstdev . "\n";
+                $meanStdevs[$i] . " --> $dMean sigma vs " . $reject_meanstdev . "\n";
             $reject = 1;
             goto UPDATE;

trunk/ippScripts/scripts/detrend_reject_imfile.pl

@@ -162 +162 @@
     }
     if ($reject_imfile_sn) {
-        if ($mean / $stdev < $reject_imfile_sn) {
-            print "Rejecting exposure based on bad imfile S/N for imfile $i: " .
-                $mean / $stdev . " vs " . $reject_imfile_sn . "\n";
+        if ($mean < $stdev * $reject_imfile_sn) {
+            print "Rejecting exposure based on bad imfile S/N for imfile $i: \n";
+            print "mean: " . $mean . " vs " . "stdev*SNlimit: " . $stdev * $reject_imfile_sn . "\n";
             $reject = 1;
             last;
@@ -193 +193 @@
 if ($reject_exp_mean) {
     if (abs($mean) > $reject_exp_mean * $stdev) {
-        print "Rejecting exposure based on bad mean: " . ($mean / $stdev) . " vs " .
-            $reject_exp_mean . "\n";
+        print "Rejecting exposure based on bad mean: \n";
+        print "mean: $mean, stdev: $stdev (limit is: % $reject_exp_mean\n";
         $reject = 1;
     } 
@@ -222 +222 @@
 # reject if the signal-to-noise is insufficient
 if ($reject_exp_sn) {
-    if ($mean / $stdev < $reject_exp_sn) {
-        print "Rejecting exposure based on poor S/N: " . $mean / $stdev . " vs " . 
-            $reject_exp_sn . "\n";
+    if ($mean < $stdev * $reject_exp_sn) {
+        print "Rejecting exposure based on poor S/N: \n";
+        print "signal: $mean vs noise: $stdev (s/n limit is: $reject_exp_sn)\n";
         $reject = 1;
     }
@@ -306 +306 @@
 ## the same logical cuts above can be applied to components in an
 ## imfile, imfiles in an exposure, and exposures in a stack
+
+### this function needs to avoid div by zero: compare Signal vs Noise*limit