Changeset 11686 for trunk/psLib/src/sys

Timestamp:

Feb 7, 2007, 1:52:54 PM (20 years ago)

Author:

jhoblitt

Message:

update psAbort() API:

add noreturn attribute
remove unneeded 'name' params
turn into a macro so file/line/func are automatiically passed

Location:

trunk/psLib/src/sys

Files:

• psAbort.c (modified) (3 diffs)
• psAbort.h (modified) (3 diffs)
• psError.c (modified) (4 diffs)
• psString.c (modified) (2 diffs)

trunk/psLib/src/sys/psAbort.c

@@ -9 +9 @@
  *
  *  @author Eric Van Alst, MHPCC
+ *  @author Joshua Hoblitt, University of Hawaii
  *   
- *  @version $Revision: 1.14 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2007-01-09 22:38:53 $
+ *  @version $Revision: 1.15 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2007-02-07 23:52:54 $
  *
  *  Copyright 2004-2005 Maui High Performance Computing Center, University of Hawaii
@@ -22 +23 @@
 #include <stdarg.h>
 #include <stdlib.h>
+
 #include "psAbort.h"
 #include "psError.h"
 #include "psLogMsg.h"
 
-void psAbort(const char *name, const char *format, ...)
+void p_psAbort(const char *file,
+               unsigned int lineno,
+               const char *func,
+               const char *format,
+               ...)
 {
     psErrorStackPrint(stderr, "Aborting. Error stack:");
@@ -35 +41 @@
 
     // Call logging function with PS_LOG_ABORT level
-    psLogMsgV(name, PS_LOG_ABORT, format, argPtr);
+    psLogMsgV("psLib.sys", PS_LOG_ABORT, format, argPtr);
 
     // Clean up stack after variable arguement has been used

trunk/psLib/src/sys/psAbort.h

@@ -8 +8 @@
  *
  *  @author Eric Van Alst, MHPCC
+ *  @author Joshua Hoblitt, University of Hawaii
  *
- *  $Revision: 1.13 $ $Name: not supported by cvs2svn $
- *  $Date: 2007-01-23 22:47:23 $
+ *  $Revision: 1.14 $ $Name: not supported by cvs2svn $
+ *  $Date: 2007-02-07 23:52:54 $
  *  Copyright 2004-2005 Maui High Performance Computing Center, University of Hawaii
  */
@@ -19 +20 @@
 /// @addtogroup SysUtils System Utilities
 /// @{
+
+#include <stdarg.h>
 
 /** Reports an abort message to logging facility
@@ -30 +33 @@
  *
  */
-#ifdef __GNUC__
+#ifdef DOXYGEN
 void psAbort(
-    const char *name,                  ///< Source of abort such as file or function detected
-    const char *format,                   ///< A printf style formatting statement defining msg
-    ...
-) __attribute__((format(printf, 2, 3)));
-#else // __GNUC__
-void psAbort(
-    const char *name,                  ///< Source of abort such as file or function detected
-    const char *format,                   ///< A printf style formatting statement defining msg
+    const char *format,                 ///< A printf style formatting statement
     ...
 );
-#endif // __GNUC__
+#else // ifdef DOXYGEN
+void p_psAbort(
+    const char *file,                   ///< File of caller
+    unsigned int lineno,                ///< Line number of caller
+    const char *func,                   ///< Function name of caller
+    const char *format,                 ///< A printf style formatting statement
+    ...
+#ifdef __GNUC__
+) __attribute__((format(printf, 4, 5), noreturn));
+#else // ifdef __GNUC__
+);
+#endif // ifdef __GNUC__
+#ifndef SWIG
+#define psAbort(...) \
+      p_psAbort(__FILE__, __LINE__, __func__, __VA_ARGS__)
+#endif // iddef SWIG
+#endif // ifdef DOXYGEN
 
 /// @}

trunk/psLib/src/sys/psError.c

@@ -11 +11 @@
  *  @author Eric Van Alst, MHPCC
  *
- *  @version $Revision: 1.44 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2007-02-07 01:15:49 $
+ *  @version $Revision: 1.45 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2007-02-07 23:52:54 $
  *
  *  Copyright 2004-2005 Maui High Performance Computing Center, University of Hawaii
@@ -65 +65 @@
         psArrayAdd(errorStack, 0, err);
     } else {
-        psAbort(__func__, "attempt to exceed maximum error stack depth of %ld",
+        psAbort("attempt to exceed maximum error stack depth of %ld",
                 (long)MAX_ERROR_STACK_SIZE);
     }
@@ -78 +78 @@
         // thread exits
         if (pthread_key_create(&errorStack_key, psFreeWrapper)) {
-            psAbort(__func__, "pthread_key_create() failed");
+            psAbort("pthread_key_create failed()");
         }
         errorStackKeyInitialized = true;
@@ -95 +95 @@
         // param
         if (pthread_setspecific(errorStack_key, errorStack)) {
-            psAbort(__func__, "pthread_setspecific() failed");
+            psAbort("pthread_setspecific() failed");
         }
     }

trunk/psLib/src/sys/psString.c

@@ -13 +13 @@
  *  @author David Robbins, MHPCC
  *
- *  @version $Revision: 1.50 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2007-02-03 06:01:42 $
+ *  @version $Revision: 1.51 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2007-02-07 23:52:54 $
  *
  *  Copyright 2004-2005 Maui High Performance Computing Center, University of Hawaii
@@ -339 +339 @@
     }
 
-    psAbort(__func__, "Should never get here.\n");
+    psAbort("Should never get here.\n");
     return 0;
 }