Changeset 12390

Timestamp:

Mar 9, 2007, 2:56:02 PM (19 years ago)

Author:

jhoblitt

Message:

correctly compare float/double NAN values

File:

• trunk/psLib/test/pstap/src/pstap.h (modified) (5 diffs)

trunk/psLib/test/pstap/src/pstap.h

@@ +1 @@
+#include <math.h>
+
 #include <pslib.h>
 
@@ -22 +24 @@
 
 // use to test the value of a float
-# define ok_float(VALUE, EXPECT, ...)\
+# define ok_float(VALUE, EXPECT, ...) \
 { \
-    bool status = (fabsf(VALUE - EXPECT) < FLT_EPSILON); \
+    bool status = false; \
+    if (isnan(EXPECT)) { \
+        status = isnan(VALUE); \
+    } else { \
+        status = (fabsf(VALUE - EXPECT) < FLT_EPSILON); \
+    } \
     ok(status, __VA_ARGS__); \
     if (!status) { \
@@ -36 +43 @@
 # define ok_float_tol(VALUE,EXPECT,TOL,...)\
 { \
-    bool status = (fabsf((VALUE) - (EXPECT)) < (TOL)); \
+    bool status = false; \
+    if (isnan(EXPECT)) { \
+        status = isnan(VALUE); \
+    } else { \
+        status = (fabsf((VALUE) - (EXPECT)) < (TOL)); \
+    } \
     ok(status, __VA_ARGS__); \
     if (!status) { \
@@ -47 +59 @@
 # define ok_double(VALUE,EXPECT,...)\
 { \
-    bool status = (fabs(VALUE - EXPECT) < DBL_EPSILON); \
+    bool status = false; \
+    if (isnan(EXPECT)) { \
+        status = isnan(VALUE); \
+    } else { \
+        status = (fabs(VALUE - EXPECT) < DBL_EPSILON); \
+    } \
     ok(status, __VA_ARGS__); \
     if (!status) { \
@@ -55 +72 @@
 }
 
-// use to test the value of a float
-# define ok_float_tol(VALUE,EXPECT,TOL, ...)\
-{ \
-    bool status = (fabsf((VALUE) - (EXPECT)) < (TOL)); \
-    ok(status, __VA_ARGS__); \
-    if (!status) { \
-        diag("         got: '%f'", VALUE); \
-        diag("    expected: '%f' +/- %f", EXPECT, TOL); \
-    } \
-}
-
 // use to test the value of a double
 # define ok_double_tol(VALUE,EXPECT,TOL, ...)\
 { \
-    bool status = (fabs((VALUE) - (EXPECT)) < (TOL)); \
+    bool status = false; \
+    if (isnan(EXPECT)) { \
+        status = isnan(VALUE); \
+    } else { \
+        status = (fabs((VALUE) - (EXPECT)) < (TOL)); \
+    } \
     ok(status, __VA_ARGS__); \
     if (!status) { \