Changeset 13173 for trunk/Nebulous/lib

Timestamp:

May 2, 2007, 3:44:24 PM (19 years ago)

Author:

jhoblitt

Message:

better paramter checking
overhaul instance table
add ->_is_valid_object_key() method
change ->find_instances() to check it's params and only return instances on mounted & available volumes

Location:

trunk/Nebulous/lib/Nebulous

Files:

• Server.pm (modified) (7 diffs)
• Server/SQL.pm (modified) (3 diffs)

trunk/Nebulous/lib/Nebulous/Server.pm

@@ -1 +1 @@
 # Copyright (c) 2004  Joshua Hoblitt
 #
-# $Id: Server.pm,v 1.31 2007-05-02 20:53:42 jhoblitt Exp $
+# $Id: Server.pm,v 1.32 2007-05-03 01:44:23 jhoblitt Exp $
 
 package Nebulous::Server;
@@ -283 +283 @@
     my $self = shift;
 
-    my ($key, $volume) = validate_pos(@_,
-        {
-            type        => SCALAR,
-        },
-        {
-            type        => SCALAR,
+    my ($key, $vol_name) = validate_pos(@_,
+        {
+            type        => SCALAR,
+            callbacks   => {
+                'is valid object key' => sub { $self->_is_valid_object_key($_[0]) },
+            },
+        },
+        {
+            type        => SCALAR,
+            callbacks   => {
+                # check that the volume name requested is valid
+                'is valid volume name' => sub { $self->_is_valid_volume_name($_[0]) },
+            },
             optional    => 1,
         },
@@ -301 +308 @@
     my ($vol_id, $vol_path);
     eval {
-        ($vol_id, $vol_path) = $self->_get_storage_volume($volume);
+        ($vol_id, $vol_path) = $self->_get_storage_volume($vol_name);
     };
     if ($@) {
@@ -312 +319 @@
         {
             my $query = $db->prepare_cached( $sql->get_object_instances );
-            my $rows = $query->execute( $key );
+            my $rows = $query->execute($key, 1);
 
             unless ( $rows > 0 ) {
@@ -866 +873 @@
     my $self = shift;
 
-    my ( $key, $volume ) = validate_pos( @_,
-        {
-            type        => SCALAR,
-        },
-        {
-            type        => SCALAR,
+    my ($key, $vol_name) = validate_pos(@_,
+        {
+            type        => SCALAR,
+            callbacks   => {
+                'is valid object key' => sub { $self->_is_valid_object_key($_[0]) },
+            },
+        },
+        {
+            type        => SCALAR,
+            callbacks   => {
+                # check that the volume name requested is valid
+                'is valid volume name' => sub { $self->_is_valid_volume_name($_[0]) },
+            },
             optional    => 1,
         },
@@ -880 +894 @@
     my $db  =$self->db;
 
-    $log->debug( "entered - @_" );
-
-    # TODO restrict search to a volume
+    $log->debug("entered - @_");
 
     my $query;
-
-    eval {
-        $query = $db->prepare_cached( $sql->get_object_instances );
-        $query->execute( $key );
-    };
-    $log->logdie( "database error: $@" ) if $@;
+    eval {
+        {
+            # ask the db to generate the table of mounted Nebulous volume 
+            my $query = $db->prepare_cached("call getmountedvol()");
+            $query->execute();
+        }
+
+        if ($vol_name) {
+            $query = $db->prepare_cached( $sql->get_object_instances_by_vol_name );
+            # ext_id, name, available
+            my $rows = $query->execute($key, $vol_name, 1);
+            unless ($rows > 0) {
+                $query->finish;
+                $log->logdie("no instances on storage volume: $vol_name or volume is not available");
+            }
+        } else {
+            $query = $db->prepare_cached( $sql->get_object_instances );
+            # ext_id, available
+            my $rows = $query->execute($key, 1);
+            unless ($rows > 0) {
+                $query->finish;
+                $log->logdie("no instances available");
+            }
+        }
+    };
+    $log->logdie("database error: $@") if $@;
 
     my @locations;
 
-    while ( my $row = $query->fetchrow_hashref ) {
+    while (my $row = $query->fetchrow_hashref) {
         my $instance = $row->{ 'uri' };
         push @locations, $instance if $instance;
     }
 
-    $log->logdie( "no instances found" ) unless ( scalar @locations );
-
-    $log->debug( "leaving" );
+    # XXX remove this?
+    $log->logdie("no instances found") unless (scalar @locations);
+
+    $log->debug("leaving");
 
     return \@locations;
@@ -1089 +1122 @@
 }
 
+sub _is_valid_object_key  {
+    my ($self, $key) = @_;
+
+    my $log = $self->log;
+    my $sql = $self->sql;
+    my $db  =$self->db;
+
+    my $ext_id;
+    eval {
+        my $query = $db->prepare_cached( $sql->get_object ); 
+        $query->execute($key);
+        ($ext_id) = $query->fetchrow_array;
+        $query->finish;
+    };
+    if ($@) {
+        $db->rollback;
+        $log->logdie( "database error: $@" );
+    }
+
+    if (defined $ext_id) {
+        return 1;
+    } 
+
+    return;
+}
+
 sub _is_valid_volume_name  {
     my ($self, $vol_name) = @_;

trunk/Nebulous/lib/Nebulous/Server/SQL.pm

@@ -1 +1 @@
 # Copyright (c) 2004  Joshua Hoblitt
 #
-# $Id: SQL.pm,v 1.33 2007-05-02 20:53:42 jhoblitt Exp $
+# $Id: SQL.pm,v 1.34 2007-05-03 01:44:24 jhoblitt Exp $
 
 package Nebulous::Server::SQL;
@@ -144 +144 @@
         WHERE so_id = ?
     },
-    get_object_instances        => qq{
-        SELECT storage_object.so_id,
-            uri, assigned_location
-        FROM storage_object
-        LEFT JOIN instance
-        USING (so_id)
-        WHERE ext_id = ?
+    get_object_instances    => qq{
+        SELECT
+            storage_object.so_id,
+            uri,
+            assigned_vol_id
+        FROM storage_object
+        JOIN instance
+            USING (so_id)
+        JOIN mountedvol
+            USING(vol_id)
+        WHERE ext_id = ?
+            AND available = ?
+    },
+    get_object_instances_by_vol_name => qq{
+        SELECT
+            storage_object.so_id,
+            uri,
+            assigned_vol_id
+        FROM storage_object
+        JOIN instance
+            USING (so_id)
+        JOIN mountedvol
+            USING(vol_id)
+        WHERE ext_id = ?
+            AND name = ?
+            AND available = ?
     },
     get_storage_volume_byname   => qq{
@@ -284 +303 @@
     uri VARCHAR(255) NOT NULL,
     sha1sum CHAR(40) ASCII,
-    assigned_location BOOL,
+    assigned_vol_id INT,
     epoch TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
     mtime TIMESTAMP,