Changeset 1542

Timestamp:

Aug 13, 2004, 3:48:45 PM (22 years ago)

Author:

desonia

Message:

found some points where the mutex is not released upon certain error conditions.

Location:

trunk/psLib/src

Files:

• collections/psList.c (modified) (4 diffs)
• types/psList.c (modified) (4 diffs)

trunk/psLib/src/collections/psList.c

@@ -7 +7 @@
  *  @author Robert Daniel DeSonia, MHPCC
  *
- *  @version $Revision: 1.15 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2004-08-09 23:34:57 $
+ *  @version $Revision: 1.16 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2004-08-14 01:48:45 $
  *
  *  Copyright 2004 Maui High Performance Computing Center, University of Hawaii
@@ -196 +196 @@
         if (which == PS_LIST_UNKNOWN) {
             psError(__func__, "Failed to find item in given psList.");
+            pthread_mutex_unlock(&list->lock)
+            ;
             return false;
         }
@@ -206 +208 @@
     if (elem == NULL) {
         psError(__func__, "Couldn't position to given index (%d) to remove element from list.", which);
+        pthread_mutex_unlock(&list->lock)
+        ;
         return false;
     }
@@ -270 +274 @@
     if (where >= (int)list->size) {
         list->iter = NULL;
+        if (lockList) {
+            pthread_mutex_unlock(&list->lock)
+            ;
+        }
         return;
     }

trunk/psLib/src/types/psList.c

@@ -7 +7 @@
  *  @author Robert Daniel DeSonia, MHPCC
  *
- *  @version $Revision: 1.15 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2004-08-09 23:34:57 $
+ *  @version $Revision: 1.16 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2004-08-14 01:48:45 $
  *
  *  Copyright 2004 Maui High Performance Computing Center, University of Hawaii
@@ -196 +196 @@
         if (which == PS_LIST_UNKNOWN) {
             psError(__func__, "Failed to find item in given psList.");
+            pthread_mutex_unlock(&list->lock)
+            ;
             return false;
         }
@@ -206 +208 @@
     if (elem == NULL) {
         psError(__func__, "Couldn't position to given index (%d) to remove element from list.", which);
+        pthread_mutex_unlock(&list->lock)
+        ;
         return false;
     }
@@ -270 +274 @@
     if (where >= (int)list->size) {
         list->iter = NULL;
+        if (lockList) {
+            pthread_mutex_unlock(&list->lock)
+            ;
+        }
         return;
     }