Changeset 23487 for trunk/pswarp

Timestamp:

Mar 23, 2009, 9:42:42 AM (17 years ago)

Author:

Paul Price

Message:

Functions declared as 'type function()' cause errors with the Intel compiler ('error #310: old-style parameter list (anachronism)'), which wants 'type function()'. These instances haven't caused problems yet, and I'm trying to avoid that.

Location:

trunk/pswarp/src

Files:

• pswarp.h (modified) (3 diffs)
• pswarpMapGrid.c (modified) (9 diffs)
• pswarpSetThreads.c (modified) (1 diff)
• pswarpTransformTile.c (modified) (1 diff)

trunk/pswarp/src/pswarp.h

@@ -72 +72 @@
 } pswarpTransformTileArgs;
 
-pswarpTransformTileArgs *pswarpTransformTileArgsAlloc();
+pswarpTransformTileArgs *pswarpTransformTileArgsAlloc(void);
 bool pswarpTransformTile (pswarpTransformTileArgs *args);
 
@@ -87 +87 @@
 bool pswarpMatchRange (int *minX, int *minY, int *maxX, int *maxY, pmReadout *dest, pmReadout *src);
 
-pswarpMap *pswarpMapAlloc ();
+pswarpMap *pswarpMapAlloc (void);
 pswarpMapGrid *pswarpMapGridAlloc (int Nx, int Ny);
 
@@ -111 +111 @@
  * define threads for this program
  */
-bool pswarpSetThreads ();
+bool pswarpSetThreads (void);
 
 /// Return software version

trunk/pswarp/src/pswarpMapGrid.c

@@ -43 +43 @@
     // measure the map for the center of each superpixel
     for (ni = 0, i = xMin; ni < nXpts; i += nXpix, ni++) {
-        for (nj = 0, j = yMin; nj < nYpts; j += nYpix, nj++) {
-            pswarpMapSetLocalModel (grid->maps[ni][nj], dest, src, i, j);
-        }
+        for (nj = 0, j = yMin; nj < nYpts; j += nYpix, nj++) {
+            pswarpMapSetLocalModel (grid->maps[ni][nj], dest, src, i, j);
+        }
     }
-            
+
     grid->nXpix = nXpix;
     grid->nYpix = nYpix;
@@ -112 +112 @@
 
     for (int i = 0; i < grid->nXpts - 1; i++) {
-        for (int j = 0; j < grid->nYpts - 1; j++) {
-
-            // measure the output coordinates for the next grid position using the current grid map
-            // compare with the coordinates measured using the next grid map
-            pswarpMapApply (&xRaw, &yRaw, grid->maps[i][j], grid->maps[i][j]->xo + grid->nXpix, grid->maps[i][j]->yo);
-            pswarpMapApply (&xRef, &yRef, grid->maps[i+1][j], grid->maps[i][j]->xo + grid->nXpix, grid->maps[i][j]->yo);
-
-            double posError = hypot (xRaw-xRef, yRaw-yRef);
-            maxError = PS_MAX (maxError, posError);
-        }
-    }   
+        for (int j = 0; j < grid->nYpts - 1; j++) {
+
+            // measure the output coordinates for the next grid position using the current grid map
+            // compare with the coordinates measured using the next grid map
+            pswarpMapApply (&xRaw, &yRaw, grid->maps[i][j], grid->maps[i][j]->xo + grid->nXpix, grid->maps[i][j]->yo);
+            pswarpMapApply (&xRef, &yRef, grid->maps[i+1][j], grid->maps[i][j]->xo + grid->nXpix, grid->maps[i][j]->yo);
+
+            double posError = hypot (xRaw-xRef, yRaw-yRef);
+            maxError = PS_MAX (maxError, posError);
+        }
+    }
     return maxError;
 }
@@ -176 +176 @@
     psPlaneTransformApply (FP, fpaDest->fromTPA, TP);
     psPlaneTransformApply (V00, chipDest->fromFPA, FP);
-    
+
     /** V(1,0) position */
     offset->x = ix + 1;
@@ -186 +186 @@
     psPlaneTransformApply (FP, fpaDest->fromTPA, TP);
     psPlaneTransformApply (V10, chipDest->fromFPA, FP);
-    
+
     /** V(0,1) position */
     offset->x = ix;
@@ -204 +204 @@
     map->Yy = V01->y - V00->y;
     map->Yo = V00->y - map->Yx*ix - map->Yy*iy;
- 
+
     map->xo = ix;
     map->yo = iy;
@@ -224 +224 @@
 }
 
-pswarpMap *pswarpMapAlloc () {
+pswarpMap *pswarpMapAlloc(void) {
 
   pswarpMap *map = (pswarpMap *) psAlloc (sizeof(pswarpMap));
@@ -238 +238 @@
 
     for (int i = 0; i < grid->nXpts; i++) {
-        for (int j = 0; j < grid->nYpts; j++) {
-            psFree (grid->maps[i][j]);
-        }
-        psFree (grid->maps[i]);
+        for (int j = 0; j < grid->nYpts; j++) {
+            psFree (grid->maps[i][j]);
+        }
+        psFree (grid->maps[i]);
     }
     psFree (grid->maps);
@@ -256 +256 @@
       grid->maps[i] = psAlloc (nYpts*sizeof(void *));
       for (int j = 0; j < nYpts; j++) {
-          grid->maps[i][j] = pswarpMapAlloc();
+          grid->maps[i][j] = pswarpMapAlloc();
       }
   }
@@ -264 +264 @@
   grid->nXpix = 0;
   grid->nYpix = 0;
-  
+
   return grid;
 }

trunk/pswarp/src/pswarpSetThreads.c

@@ -23 +23 @@
 }
 
-bool pswarpSetThreads () {
+bool pswarpSetThreads(void) {
 
     psThreadTask *task = NULL;

trunk/pswarp/src/pswarpTransformTile.c

@@ -24 +24 @@
 }
 
-pswarpTransformTileArgs *pswarpTransformTileArgsAlloc()
+pswarpTransformTileArgs *pswarpTransformTileArgsAlloc(void)
 {
     pswarpTransformTileArgs *args = psAlloc(sizeof(pswarpTransformTileArgs));