Changeset 27491 for trunk/Ohana

Timestamp:

Mar 27, 2010, 5:27:25 PM (16 years ago)

Author:

eugene

Message:

various little issues from --pedantic

Location:

trunk/Ohana/src

Files:

• gastro2/src/lumfunc.c (modified) (1 diff)
• kapa2/src/DrawObjects.c (modified) (1 diff)
• kapa2/src/InterpretPresses.c (modified) (1 diff)
• libdvo/src/LoadPhotcodesFITS.c (modified) (1 diff)
• libdvo/src/dvo_convert_PS1_DEV_3.c (modified) (1 diff)
• libohana/src/ohana_allocate.c (modified) (1 diff)
• opihi/cmd.astro/coords.c (modified) (1 diff)
• opihi/cmd.astro/galradius.c (modified) (1 diff)
• opihi/cmd.astro/petrosian.c (modified) (1 diff)
• opihi/cmd.basic/run_while.c (modified) (1 diff)
• opihi/cmd.data/section.c (modified) (1 diff)
• opihi/cmd.data/subset.c (modified) (1 diff)
• opihi/dvo/ImageOps.c (modified) (1 diff)
• opihi/dvo/dbCmdlineFields.c (modified) (1 diff)
• opihi/lib.shell/expand_vectors.c (modified) (1 diff)
• opihi/lib.shell/parse.c (modified) (1 diff)
• opihi/pantasks/ControllerOps.c (modified) (1 diff)
• skycalc/src/astro.c (modified) (1 diff)
• tools/src/csystem.c (modified) (1 diff)
• tools/src/fhead.c (modified) (1 diff)
• tools/src/fields.c (modified) (1 diff)
• tools/src/fits_insert.c (modified) (1 diff)
• tools/src/precess.c (modified) (2 diffs)

trunk/Ohana/src/gastro2/src/lumfunc.c

@@ -46 +46 @@
     }
   }
+  Nb = MAX(1, Nb);
 
   /* find max & min mag bins */

trunk/Ohana/src/kapa2/src/DrawObjects.c

@@ -244 +244 @@
   
   /* continue with rest of points */
+  sxo = syo = 0;
   for (i++; i < object[0].Npts; i++) {
     if (!(finite(x[i]) && finite(y[i]))) continue;

trunk/Ohana/src/kapa2/src/InterpretPresses.c

@@ -24 +24 @@
 
     sprintf (name, "Button%d", event[0].button);
+    Z = 0;
     if (graph) {
       X = (event[0].x - graph[0].axis[0].fx)*(graph[0].axis[0].max - graph[0].axis[0].min)/graph[0].axis[0].dfx + graph[0].axis[0].min;

trunk/Ohana/src/libdvo/src/LoadPhotcodesFITS.c

@@ -7 +7 @@
 
   PhotCodeData *table = NULL;
-  PhotCode *photcode;
+  PhotCode *photcode = NULL;
   FITS_DB db;
   char extname[80];

trunk/Ohana/src/libdvo/src/dvo_convert_PS1_DEV_3.c

@@ -15 +15 @@
     memcpy (&out[i].coords, &in[i].coords, sizeof(Coords));
 
-    strncpy (out[i].name, in[i].name, 127); // out[128], in[128]
-    out[i].name[127] = 0; // force termination
+    strncpy (out[i].name, in[i].name, 120); // out[121], in[121]
+    out[i].name[120] = 0; // force termination
 
     out[i].tzero            = in[i].tzero;

trunk/Ohana/src/libohana/src/ohana_allocate.c

@@ -254 +254 @@
 void ohana_memdump_func (int allmemory) {
 
-  int i, Ns[3], N;
-  char S[3];
+  int i, Ns[4], N;
+  char S[4];
 
   if (Nmemlist == 0) {

trunk/Ohana/src/opihi/cmd.astro/coords.c

@@ -10 +10 @@
   Coords coords, moscoords;
   Buffer *buf, *mosbuffer;
-  Vector *xvec, *yvec;
+  Vector *xvec = NULL;
+  Vector *yvec = NULL;
 
   MOSAIC = NULL;

trunk/Ohana/src/opihi/cmd.astro/galradius.c

@@ -99 +99 @@
 
   above = TRUE;
+  Ro = 0;
   for (i = 0; i < Nout; i++) {
 

trunk/Ohana/src/opihi/cmd.astro/petrosian.c

@@ -39 +39 @@
   ResetVector (Avec, OPIHI_FLT, fvec[0].Nelements);
 
+  flux_90 = rad_90 = 0.0;
   R_90 = 0.1;
   above = TRUE;

trunk/Ohana/src/opihi/cmd.basic/run_while.c

@@ -83 +83 @@
 
   /* execute for loop */
+  status = FALSE;
   while (logic) { 
     status = exec_loop (&loop);

trunk/Ohana/src/opihi/cmd.data/section.c

@@ -6 +6 @@
   
   int N, action, kapa;
-  char *name, *location;
   Graphdata graphmode;
   KapaSection section;
+  char *name = NULL;
+  char *location = NULL;
 
   action = NONE;

trunk/Ohana/src/opihi/cmd.data/subset.c

@@ -11 +11 @@
   out = NULL;
   ivec = ovec = tvec = NULL;
+  Npts = 0;
 
   valid = TRUE;

trunk/Ohana/src/opihi/dvo/ImageOps.c

@@ -26 +26 @@
   }
 
+  patch.Rmin = 0;
+  patch.Rmax = 0;
+  patch.Dmin = 0;
+  patch.Dmax = 0;
   if (selection->useSkyregion) {
     double Rs, Re, Ds, De;

trunk/Ohana/src/opihi/dvo/dbCmdlineFields.c

@@ -54 +54 @@
   ALLOCATE (fields, dbField, NFIELDS);
   dbInitField (&fields[0]);
+
+  status = FALSE;
 
   // examine each argv[i] entry until we reach a 'where' or a 'matched' 

trunk/Ohana/src/opihi/lib.shell/expand_vectors.c

@@ -27 +27 @@
   strncpy (newline, line, n);
   N = newline + n;
+  J = 0;
   while (1) {
     /* find square-bracket pair [..] */

trunk/Ohana/src/opihi/lib.shell/parse.c

@@ -11 +11 @@
   Buffer *buf;
 
+  Ny = 0;
   val = V0 = NULL;
 

trunk/Ohana/src/opihi/pantasks/ControllerOps.c

@@ -624 +624 @@
   InitIOBuffer (&buffer, 0x100);
 
+  status = TRUE;
+
   // XXX lock the host table? no: that would risk a dead lock between client and controller threads:
   gprint (GP_ERR, "pcontrol restarted, reloading hosts\n");

trunk/Ohana/src/skycalc/src/astro.c

@@ -148 +148 @@
   short i;
 
+  delt = 0.0;
   year = 1900. + (jd - 2415019.5) / 365.25;
 

trunk/Ohana/src/tools/src/csystem.c

@@ -10 +10 @@
   double sin_x, sin_y, cos_x, cos_y;
   
+  phi = xo = Xo = 0.0;
+
   if (((argc == 3) && ((argv[1][0] == 'E') || (argv[2][0] == 'E'))) || 
       ((argc == 4) && ((argv[1][0] != 'E') && (argv[2][0] != 'E'))) ||

trunk/Ohana/src/tools/src/fhead.c

@@ -11 +11 @@
 
   Extend = FALSE;
+  Nextend = 0;
   if ((N = get_argument (argc, argv, "-x"))) {
     Extend = TRUE;

trunk/Ohana/src/tools/src/fields.c

@@ -25 +25 @@
   off_t Nbytes;
   regex_t preg;
+
+  Nextend = 0;
+  GotExtension = FALSE;
 
   if (get_argument (argc, argv, "-h")) usage();

trunk/Ohana/src/tools/src/fits_insert.c

@@ -15 +15 @@
   int COMMENT, Cnumber;
   char *Cline;
+
+  Cline = NULL;
+  Cnumber = 0;
+  DeleteStart = DeleteStop = 0;
 
   /* check for command line options */

trunk/Ohana/src/tools/src/precess.c

@@ -10 +10 @@
   double SA, CA, SD, CD;
   int Julian, Besselian;
+
+  in_epoch = 2000.0;
+  out_epoch = 2000.0;
 
   Besselian = Julian = 0;
@@ -88 +91 @@
   double epoch;
 
+  epoch = 2000.0;
   done = FALSE;
   if (in_epoch[0] == 'B') {