Changeset 2902 for trunk/Nebulous/lib

Timestamp:

Jan 4, 2005, 5:19:12 PM (22 years ago)

Author:

jhoblitt

Message:

remove raw SQl from _get_storage_volume

Location:

trunk/Nebulous/lib/Nebulous

Files:

• Server.pm (modified) (2 diffs)
• Server/SQL.pm (modified) (3 diffs)

trunk/Nebulous/lib/Nebulous/Server.pm

@@ -1 +1 @@
 # Copyright (c) 2004  Joshua Hoblitt
 #
-# $Id: Server.pm,v 1.4 2005-01-05 03:10:08 jhoblitt Exp $
+# $Id: Server.pm,v 1.5 2005-01-05 03:19:12 jhoblitt Exp $
 
 package PS::IPP::IData::Server;
@@ -631 +631 @@
             my $rows;
             if ( $name ) {
-                $query = $db->prepare( qq{ SELECT uri FROM volume WHERE name = ? ORDER BY rand() LIMIT 1 } );
+                $query = $db->prepare( $sql->get_storage_volume_byname );
                 $rows = $query->execute( $name );
             } else {
-                $query = $db->prepare( qq{ SELECT uri FROM volume ORDER BY rand() LIMIT 1 } );
+                $query = $db->prepare( $sql->get_storage_volume );
                 $rows = $query->execute;
             }

trunk/Nebulous/lib/Nebulous/Server/SQL.pm

@@ -1 +1 @@
 # Copyright (c) 2004  Joshua Hoblitt
 #
-# $Id: SQL.pm,v 1.2 2005-01-05 02:44:54 jhoblitt Exp $
+# $Id: SQL.pm,v 1.3 2005-01-05 03:19:12 jhoblitt Exp $
 
 package PS::IPP::IData::Server::SQL;
@@ -83 +83 @@
         WHERE so_id = ?
     },
-    get_object_instances    => qq{
+    get_object_instances        => qq{
         SELECT storage_object.so_id, uri, assigned_location
         FROM storage_object
@@ -89 +89 @@
         USING (so_id)
         WHERE storage_object.ext_id = ?
+    },
+    get_storage_volume_byname   => qq{
+        SELECT uri FROM volume WHERE name = ? ORDER BY rand() LIMIT 1 
+    },
+    get_storage_volume          => qq{
+        SELECT uri FROM volume ORDER BY rand() LIMIT 1
     },
 );