Changeset 3209

Timestamp:

Feb 13, 2005, 12:23:07 PM (21 years ago)

Author:

jhoblitt

Message:

merge psDBGenerateSelectColumnSQL() & psDBGenerateSelectRowsSQL() into psDBGenerateSelectRowSQL()

File:

• trunk/archive/psdb/psDB.c (modified) (6 diffs)

trunk/archive/psdb/psDB.c

@@ -8 +8 @@
  *  @author Joshua Hoblitt
  *
- *  @version $Revision: 1.20 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2005-02-13 22:09:46 $
+ *  @version $Revision: 1.21 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2005-02-13 22:23:07 $
  *
  *  Copyright 2005 Joshua Hoblitt, University of Hawaii
@@ -62 +62 @@
 static char    *psDBGenerateInsertRowSQL(const char *tableName, psMetadata *row);
 static char    *psDBGenerateCreateTableSQL(const char *tableName, psMetadata *where);
-static char    *psDBGenerateSelectColumnSQL(const char *tableName, const char *col, const psU64 limit);
-static char    *psDBGenerateSelectRowsSQL(const char *tableName, psMetadata *where);
+static char    *psDBGenerateSelectRowSQL(const char *tableName, const char *col, psMetadata *where, const psU64 limit);
 static char    *psDBGenerateUpdateRowSQL(const char *tableName, psMetadata *where, psMetadata *values);
 static char    *psDBGenerateSetSQL(psMetadata *set);
@@ -192 +191 @@
     psPtr           data;               // copy of result field
 
-    query = psDBGenerateSelectColumnSQL(tableName, col, limit);
+    query = psDBGenerateSelectRowSQL(tableName, col, NULL, limit);
     if (!query) {
         return NULL;
@@ -354 +353 @@
     psPtr           data;               // copy of result field
 
-    query = psDBGenerateSelectRowsSQL(tableName, where);
+    query = psDBGenerateSelectRowSQL(tableName, NULL, where, 0);
     if (!query) {
         return NULL;
@@ -979 +978 @@
 }
 
-static char *psDBGenerateSelectColumnSQL(const char *tableName, const char *col, const psU64 limit)
+static char *psDBGenerateSelectRowSQL(const char *tableName, const char *col, psMetadata *where, const psU64 limit)
 {
     char            *query = NULL;
+    char            *whereSQL;
     char            *limitString;
 
-    psStringAppend(&query, "SELECT %s FROM %s", col, tableName);
+    // select all columns if col is NULL
+    if (col) {
+        psStringAppend(&query, "SELECT %s FROM %s", col, tableName);
+    } else {
+        psStringAppend(&query, "SELECT * FROM %s", tableName);
+    }
+
+    // select all rows if where is NULL
+    if (where) {
+        whereSQL = psDBGenerateWhereSQL(where);
+        if (!whereSQL) {
+            psFree(query);
+
+            return NULL;
+        }
+        psStringAppend(&query, " %s", whereSQL);
+        psFree(whereSQL);
+    }
 
     // treat limit == 0 as "no limit"
@@ -991 +1008 @@
         psStringAppend(&query, " LIMIT %s", limitString);
         psFree(limitString);
-    }
-
-    return query;
-}
-
-static char *psDBGenerateSelectRowsSQL(const char *tableName, psMetadata *where)
-{
-    char            *query = NULL;
-    char            *whereSQL;
-
-    psStringAppend(&query, "SELECT * FROM %s", tableName);
-
-    // select everything if where is NULL
-    if (where) {
-        whereSQL = psDBGenerateWhereSQL(where);
-        if (!whereSQL) {
-            psFree(query);
-
-            return NULL;
-        }
-        psStringAppend(&query, " %s", whereSQL);
-        psFree(whereSQL);
     }