Changeset 34089 for trunk/ppStack

Timestamp:

Jun 26, 2012, 11:47:13 AM (14 years ago)

Author:

eugene

Message:

changes to support pedantic gcc warnings; add configure option for debug-build and no-as-needed

Location:

trunk/ppStack

Files:

• configure.ac (modified) (2 diffs)
• src/ppStackConvolve.c (modified) (2 diffs)
• src/ppStackFinish.c (modified) (1 diff)
• src/ppStackMatch.c (modified) (1 diff)
• src/ppStackTarget.c (modified) (1 diff)

trunk/ppStack/configure.ac

@@ -8 +8 @@
 AM_MAINTAINER_MODE
 
-IPP_STDCFLAGS
+IPP_STDLDFLAGS
 
 AC_LANG(C)
@@ -28 +28 @@
 
 IPP_STDOPTS
-CFLAGS="${CFLAGS=} -Wall -Werror"
+IPP_STDCFLAGS
 
 IPP_VERSION

trunk/ppStack/src/ppStackConvolve.c

@@ -7 +7 @@
         psMetadataItem *item = psMetadataLookup(SOURCE->concepts, NAME); \
         psAssert(item, "Concept should be present");                    \
-        psAssert(item->type == PS_TYPE_F32, "Concept should be F32");   \
+        psAssert(item->type == PS_DATA_F32, "Concept should be F32");   \
         item->data.F32 = VALUE;                                         \
     }
@@ -101 +101 @@
         if (!ppStackMatch(readout, target, options, i, config)) {
             // XXX many things can cause a failure of ppStackMatch -- should some be handled differently?
-            psErrorCode error = psErrorCodeLast(); // Error code
+
+            // gcc -Wswitch complains here if err is declared as type psErrorCode
+            // the collection of ps*ErrorCode values are enums defined separately for 
+            // each module (psphot, pswarp, etc).  the lowest type, psErrorCode is only the base set and does
+            // not include the possible psphot values
+
+            // for now, to get around this, we just use an int for the switch
+
+            // psErrorCode error = psErrorCodeLast(); // Error code
+            int error = psErrorCodeLast(); // Error code
             switch (error) {
                 // Fatal errors

trunk/ppStack/src/ppStackFinish.c

@@ -45 +45 @@
     }
 
-    psErrorCode errorCode = psErrorCodeLast(); // Error code
+    // gcc -Wswitch complains here if err is declared as type psErrorCode
+    // the collection of ps*ErrorCode values are enums defined separately for 
+    // each module (psphot, pswarp, etc).  the lowest type, psErrorCode is only the base set and does
+    // not include the possible psphot values
+
+    // for now, to get around this, we just use an int for the switch
+
+    // psErrorCode errorCode = psErrorCodeLast(); // Error code
+    int errorCode = psErrorCodeLast(); // Error code
     if (errorCode == PS_ERR_NONE) {
         return exitValue;

trunk/ppStack/src/ppStackMatch.c

@@ -460 +460 @@
             psMetadataItem *item = NULL;// Item from iteration
             while ((item = psMetadataGetAndIncrement(iter))) {
-                assert(item->type == PS_TYPE_F32);
+                assert(item->type == PS_DATA_F32);
                 float norm = item->data.F32; // Normalisation
                 sum += norm;

trunk/ppStack/src/ppStackTarget.c

@@ -191 +191 @@
 
         float norm = powf(10.0, -0.4 * options->norm->data.F32[i]); // Normalisation from stars
-        float meanVariance = bg->robustMedian * PS_SQR(norm);       // Mean variance in normalised image
+        float meanVariance = mean * PS_SQR(norm);       // Mean variance in normalised image
 
         if (meanVariance < minVariance) {