Changeset 35868

Timestamp:

Jul 31, 2013, 12:53:02 PM (13 years ago)

Author:

watersc1

Message:

Fix SCL_ values to now have scale = 0.0 when an image is rejected. Fix covariance factor that was causing over-rejection on simple 1DG kernels.

Location:

trunk/ppStack/src

Files:

• ppStackMatch.c (modified) (1 diff)
• ppStackUpdateHeader.c (modified) (2 diffs)

trunk/ppStack/src/ppStackMatch.c

@@ -467 +467 @@
                 sum += kernels->rms;
                 num++;
-                //              psLogMsg("ppStack", PS_LOG_INFO, "KERNMATCHDUMP %d %d %g %g %g\n",
-                //                       index,num,kernels->mean,kernels->rms,sum);
+                //                              psLogMsg("ppStack", PS_LOG_INFO, "KERNMATCHDUMP %d %d %g %g %g %g\n",
+                //                                       index,num,kernels->mean,kernels->rms,sum,psImageCovarianceFactor(readout->covariance));
             }
             psFree(iter);
-            options->matchChi2->data.F32[index] = sum / (psImageCovarianceFactor(readout->covariance) * num);
+
+            // Apply the covariance factor to the chi^2 value
+            double covar_factor = 1.0;
+            if (type != PM_SUBTRACTION_KERNEL_SIMPLE) { // Except if we're using simple kernels.
+              covar_factor = psImageCovarianceFactor(readout->covariance);
+            }
+            options->matchChi2->data.F32[index] = sum / (covar_factor * num);
 
         }

trunk/ppStack/src/ppStackUpdateHeader.c

@@ -98 +98 @@
 
         float value = options->norm ? pow(10.0, -0.4*options->norm->data.F32[i]) : NAN;
+        if ((options->inputMask)&&(options->inputMask->data.PS_TYPE_VECTOR_MASK_DATA[i])) {
+          value = 0.0; // If this is NAN, then it's recorded in the header as a character string instead of a float.
+        }
         snprintf (field, 64, "SCL_%04d", i);
         psMetadataAddF32(hdu->header, PS_LIST_TAIL, field, PS_META_REPLACE, "input image scale factor", value);
@@ -132 +135 @@
         expROhdu->header = psMetadataAlloc();
       }
+
       expRO->parent->parent->parent->hdu->header = psMetadataCopy(expRO->parent->parent->parent->hdu->header,
                                                                   outRO->parent->parent->parent->hdu->header);