Changeset 37966

Timestamp:

Mar 11, 2015, 7:38:53 PM (11 years ago)

Author:

eugene

Message:

add checkFileruleFileSave to use the value of FILERULE:FILE.SAVE to set i/o option; set the warp-to-chip map info

Location:

trunk/ppSub/src

Files:

• ppSubCamera.c (modified) (17 diffs)
• ppSubDefineOutput.c (modified) (6 diffs)
• ppSubReadoutPhotometry.c (modified) (1 diff)

trunk/ppSub/src/ppSubCamera.c

@@ -22 +22 @@
 #include "ppSub.h"
 
+bool checkFileruleFileSave (pmFPAfile *file, pmConfig *config) {
+
+  bool status;
+
+  psMetadata *filerule = pmConfigFileRule(config, file->camera, file->name); // File rule
+  if (!filerule) return false;
+
+  char *myString = psMetadataLookupStr(&status, filerule, "FILE.SAVE");
+  if (!myString) return false;
+
+  // do not change the value from the default unless TRUE or FALSE are found
+  if (!strcasecmp(myString, "TRUE")) {
+    file->save = true;
+    return true;
+  } 
+  if (!strcasecmp(myString, "FALSE")) {
+    file->save = false;
+    return true;
+  } 
+ 
+  return false;
+}
+
 // Define an input file
 static pmFPAfile *defineInputFile(bool *success,
@@ -131 +154 @@
         }
         if (file) {
-            // It's an output
-            file->save = true;
+            // It's an output (respect filerules)
+          checkFileruleFileSave(file, config); 
         }
     }
@@ -244 +267 @@
         return false;
     }
+    // these ->save values below are set by command-line arguments (in ppSubArguments.c) : -save-inconv, -save-refconv
     inConvImage->save = data->saveInConv;
     inConvMask->save = data->saveInConv;
@@ -283 +307 @@
         return false;
     }
-    output->save = true;
-    outMask->save = true;
+    checkFileruleFileSave (output, config);
+    checkFileruleFileSave (outMask, config);
     if (inVar && refVar) {
         pmFPAfile *outVar = defineOutputFile(config, output, false, "PPSUB.OUTPUT.VARIANCE",
@@ -292 +316 @@
             return false;
         }
-        outVar->save = true;
+        checkFileruleFileSave (outVar, config);
     }
 
@@ -305 +329 @@
             return false;
         }
-        inverse->save = true;
-        invMask->save = true;
+        checkFileruleFileSave (inverse, config);
+        checkFileruleFileSave (invMask, config);
         if (inVar && refVar) {
             pmFPAfile *invVar = defineOutputFile(config, inverse, false, "PPSUB.INVERSE.VARIANCE",
@@ -314 +338 @@
                 return false;
             }
-            invVar->save = true;
+            checkFileruleFileSave(invVar, config);
         }
     }
@@ -329 +353 @@
         return false;
     }
-    jpeg1->save = true;
+    checkFileruleFileSave(jpeg1, config);
     pmFPAfile *jpeg2 = pmFPAfileDefineOutput(config, NULL, "PPSUB.OUTPUT.JPEG2");
     if (!jpeg2) {
@@ -339 +363 @@
         return false;
     }
-    jpeg2->save = true;
+    checkFileruleFileSave(jpeg2, config);
 
     // Output residual JPEG
@@ -351 +375 @@
         return false;
     }
-    jpeg3->save = true;
+    checkFileruleFileSave(jpeg3, config);
 
     // Output subtraction kernel
@@ -395 +419 @@
         // Deactivate psphot output sources --- we want to define output source files of our own
         pmFPAfile *psphotOutput = pmFPAfileSelectSingle(config->files, "PSPHOT.OUTPUT", 0);
-        psphotOutput->save = false;
+        psphotOutput->save = false;  // this one should NOT be set
 
         pmFPAfile *outSources = defineOutputFile(config, output, false, "PPSUB.OUTPUT.SOURCES",
@@ -403 +427 @@
             return false;
         }
-        outSources->save = true;
+        checkFileruleFileSave(outSources, config);
 
         if (data->inverse) {
@@ -412 +436 @@
                 return false;
             }
-            invSources->save = true;
+            checkFileruleFileSave(invSources, config);
         }
 
@@ -423 +447 @@
                 return false;
             }
-            posSources1->save = true;
+            checkFileruleFileSave(posSources1, config);
 
             // this pmFPAfile is used to carry sources detected in the diff image @ the positions from positive image #1
@@ -431 +455 @@
                 return false;
             }
-            frcSources1->save = true;
+            checkFileruleFileSave(frcSources1, config);
         }
 
@@ -441 +465 @@
                 return false;
             }
-            posSources2->save = true;
+            checkFileruleFileSave(posSources2, config);
 
             // this pmFPAfile is used to carry sources detected in the diff image @ the positions from positive image #2
@@ -449 +473 @@
                 return false;
             }
-            frcSources2->save = true;
+            checkFileruleFileSave(frcSources2, config);
         }
     }

trunk/ppSub/src/ppSubDefineOutput.c

@@ -22 +22 @@
 #include "ppSub.h"
 
+bool ppSubCopyWarpToChip (psMetadata *tgtHeader, psMetadata *srcHeader);
+
 bool ppSubDefineOutput(const char *name, pmConfig *config)
 {
     psAssert(name, "Require name");
     psAssert(config, "Require configuration");
+
+    bool status = false;
 
     pmFPAview *view = ppSubViewReadout(); // View to readout
@@ -44 +48 @@
 
     // Convolved input images
-    psMetadata *recipe = psMetadataLookupPtr(NULL, config->recipes, PPSUB_RECIPE);
-    bool noConvolve = psMetadataLookupBool(NULL, recipe, "NOCONVOLVE"); // Do not use convolved images.
+    psMetadata *recipe = psMetadataLookupPtr(&status, config->recipes, PPSUB_RECIPE);
+    bool noConvolve = psMetadataLookupBool(&status, recipe, "NOCONVOLVE"); // Do not use convolved images.
+    bool reverse = psMetadataLookupBool(&status, config->arguments, "REVERSE"); // Reverse sense of subtraction?
+    bool mapFromPositive = psMetadataLookupBool(&status, config->arguments, "CHIP.MAP.FROM.POSITIVE"); 
+    // mapFromPositive = true means "always grab the warp->chip map from the positive image (eg, A for A - B, B for B - A)
+    // mapFromPositive = false means "always grab the warp->chip map from the first image (eg, PPSUB.INPUT if not 'reverse')
 
     pmReadout *inConv;
     if (noConvolve) {
       inConv = pmFPAfileThisReadout(config->files, view, "PPSUB.INPUT"); // Input readout
-    }
-    else {
+    } else {
       inConv = pmFPAfileThisReadout(config->files, view, "PPSUB.INPUT.CONV"); // Input readout
     }
@@ -57 +64 @@
     if (noConvolve) {
       refConv = pmFPAfileThisReadout(config->files, view, "PPSUB.REF"); // Reference readout
-    }
-    else {
+    } else {
       refConv = pmFPAfileThisReadout(config->files, view, "PPSUB.REF.CONV"); // Reference readout
     }
-    psFree(view);
 
     // Add kernel descrption to header.
@@ -78 +83 @@
         psError(PPSUB_ERR_UNKNOWN, true, "Unable to find SUBTRACTION.KERNEL");
         psFree(outRO);
+        psFree(view);
         return false;
     }
@@ -85 +91 @@
     }
     outHDU->header = psMetadataCopy(outHDU->header, hdu->header);
+
+    // in warp-stack mode, we should always use the warp 
+    // in warp-warp mode, we should use the positive warp for the positive subtraction
+
+    bool normalDiff = true;
+    if (!strcmp (name, "PPSUB.INVERSE"))  {
+      normalDiff = false;
+    }
+
+    if (reverse) {
+      // normal  = PPSUB.REF - PPSUB.INPUT
+      // inverse = PPSUB.INPUT - PPSUB.REF
+      if (mapFromPositive) {
+        pmCell *cell_Pos = normalDiff ? pmFPAfileThisCell(config->files, view, "PPSUB.REF") : pmFPAfileThisCell(config->files, view, "PPSUB.INPUT");
+        pmHDU *hdu_Pos = pmHDUFromCell(cell_Pos);
+        ppSubCopyWarpToChip (outHDU->header, hdu_Pos->header);
+      } else {
+        pmCell *cell_Pos = pmFPAfileThisCell(config->files, view, "PPSUB.REF");
+        pmHDU *hdu_Pos = pmHDUFromCell(cell_Pos);
+        ppSubCopyWarpToChip (outHDU->header, hdu_Pos->header);
+      }
+    } else {
+      // normal  = PPSUB.INPUT - PPSUB.REF
+      // inverse = PPSUB.REF - PPSUB.INPUT
+      if (mapFromPositive) {
+        pmCell *cell_Pos = normalDiff ? pmFPAfileThisCell(config->files, view, "PPSUB.INPUT") : pmFPAfileThisCell(config->files, view, "PPSUB.REF");
+        pmHDU *hdu_Pos = pmHDUFromCell(cell_Pos);
+        ppSubCopyWarpToChip (outHDU->header, hdu_Pos->header);
+      } else {
+        pmCell *cell_Pos = pmFPAfileThisCell(config->files, view, "PPSUB.INPUT");
+        pmHDU *hdu_Pos = pmHDUFromCell(cell_Pos);
+        ppSubCopyWarpToChip (outHDU->header, hdu_Pos->header);
+      }
+    }
 
     // Add additional data to the header
@@ -104 +144 @@
 
     psFree(outRO);
+    psFree(view);
 
     return true;
 }
+
+// we have 4 sets of header keywords to copy:
+// SRC_nnnn, SEC_nnnn, MPX_nnnn, MPY_nnnn
+
+bool ppSubCopyWarpToChip (psMetadata *tgtHeader, psMetadata *srcHeader) {
+
+  char keyword[80];
+
+  bool status = false;
+
+  int Nchip = 0;
+  while (true) {
+    snprintf (keyword, 80, "SRC_%04d", Nchip);
+    char *string = psMetadataLookupStr (&status, srcHeader, keyword);
+    if (!status) {
+      break;
+    }
+    psMetadataAddStr(tgtHeader, PS_LIST_TAIL, keyword, PS_META_REPLACE, "input image", string);
+    Nchip ++;
+  }
+    
+  for (int i = 0; i < Nchip; i++) {
+    snprintf (keyword, 80, "SEC_%04d", i);
+    char *string = psMetadataLookupStr (&status, srcHeader, keyword);
+    if (!status) {
+      psWarning ("cannot find keyword %s\n", keyword);
+      continue;
+    }
+    psMetadataAddStr(tgtHeader, PS_LIST_TAIL, keyword, PS_META_REPLACE, "input image", string);
+  }
+
+  for (int i = 0; i < Nchip; i++) {
+    snprintf (keyword, 80, "MPX_%04d", i);
+    char *string = psMetadataLookupStr (&status, srcHeader, keyword);
+    if (!status) {
+      psWarning ("cannot find keyword %s\n", keyword);
+      continue;
+    }
+    psMetadataAddStr(tgtHeader, PS_LIST_TAIL, keyword, PS_META_REPLACE, "input image", string);
+  }
+
+  for (int i = 0; i < Nchip; i++) {
+    snprintf (keyword, 80, "MPY_%04d", i);
+    char *string = psMetadataLookupStr (&status, srcHeader, keyword);
+    if (!status) {
+      psWarning ("cannot find keyword %s\n", keyword);
+      continue;
+    }
+    psMetadataAddStr(tgtHeader, PS_LIST_TAIL, keyword, PS_META_REPLACE, "input image", string);
+  }
+  return true;
+}
+
+bool ppSubCopyWarpToChip_Alt (psMetadata *tgtHeader, psMetadata *srcHeader, bool isPositive) {
+
+  char srcKeyword[80], tgtKeyword[80];
+
+  bool status = false;
+
+  int Nchip = 0;
+  while (true) {
+    snprintf (srcKeyword, 80, "SRC_%04d", Nchip);
+    if (isPositive) {
+      snprintf (tgtKeyword, 80, "SRCP_%03d", Nchip);
+    } else {
+      snprintf (tgtKeyword, 80, "SRCM_%03d", Nchip);
+    }
+
+    char *string = psMetadataLookupStr (&status, srcHeader, srcKeyword);
+    if (!status) {
+      break;
+    }
+    psMetadataAddStr(tgtHeader, PS_LIST_TAIL, srcKeyword, PS_META_REPLACE, "input image", string);
+    Nchip ++;
+  }
+    
+  for (int i = 0; i < Nchip; i++) {
+    snprintf (srcKeyword, 80, "SEC_%04d", i);
+    if (isPositive) {
+      snprintf (tgtKeyword, 80, "SECP_%03d", Nchip);
+    } else {
+      snprintf (tgtKeyword, 80, "SECM_%03d", Nchip);
+    }
+
+    char *string = psMetadataLookupStr (&status, srcHeader, srcKeyword);
+    if (!status) {
+      psWarning ("cannot find keyword %s\n", srcKeyword);
+      continue;
+    }
+    psMetadataAddStr(tgtHeader, PS_LIST_TAIL, srcKeyword, PS_META_REPLACE, "input image", string);
+  }
+
+  for (int i = 0; i < Nchip; i++) {
+    snprintf (srcKeyword, 80, "MPX_%04d", i);
+    if (isPositive) {
+      snprintf (tgtKeyword, 80, "MPXP_%03d", Nchip);
+    } else {
+      snprintf (tgtKeyword, 80, "MPXM_%03d", Nchip);
+    }
+
+    char *string = psMetadataLookupStr (&status, srcHeader, srcKeyword);
+    if (!status) {
+      psWarning ("cannot find keyword %s\n", srcKeyword);
+      continue;
+    }
+    psMetadataAddStr(tgtHeader, PS_LIST_TAIL, srcKeyword, PS_META_REPLACE, "input image", string);
+  }
+
+  for (int i = 0; i < Nchip; i++) {
+    snprintf (srcKeyword, 80, "MPY_%04d", i);
+    if (isPositive) {
+      snprintf (tgtKeyword, 80, "MPYP_%03d", Nchip);
+    } else {
+      snprintf (tgtKeyword, 80, "MPYM_%03d", Nchip);
+    }
+
+    char *string = psMetadataLookupStr (&status, srcHeader, srcKeyword);
+    if (!status) {
+      psWarning ("cannot find keyword %s\n", srcKeyword);
+      continue;
+    }
+    psMetadataAddStr(tgtHeader, PS_LIST_TAIL, srcKeyword, PS_META_REPLACE, "input image", string);
+  }
+  return true;
+}
+

trunk/ppSub/src/ppSubReadoutPhotometry.c

@@ -46 +46 @@
         psFree(view);
         return false;
+    }
+
+    // psphot may need the PHU header
+    if (!photFile->fpa->hdu) {
+      photFile->fpa->hdu = psMemIncrRefCounter (inFile->fpa->hdu);
     }