Changeset 3901

Timestamp:

May 11, 2005, 9:42:34 PM (21 years ago)

Author:

eugene

Message:

fixed memory leaks

Location:

trunk/Ohana/src/opihi/lib.shell

Files:

• BufferOps.c (modified) (3 diffs)
• VectorOps.c (modified) (3 diffs)
• command.c (modified) (3 diffs)
• dvomath.c (modified) (1 diff)

trunk/Ohana/src/opihi/lib.shell/BufferOps.c

@@ -137 +137 @@
   /* delete buffer entry from buffer list, if it exists */
   for (i = 0; (i < Nbuffers) && (in != buffers[i]); i++);
-  if (i == Nbuffers) return (TRUE);
+  if (i == Nbuffers) {
+    free (in);
+    return (TRUE);
+  }
 
   free (in);
@@ -157 +160 @@
   fits_free_header (&buffers[i][0].header);
   fits_free_matrix (&buffers[i][0].matrix);
+  free (buffers[i]);
 
   for (j = i; j < Nbuffers - 1; j++) buffers[j] = buffers[j + 1];
@@ -176 +180 @@
   fits_free_header (&buffers[i][0].header);
   fits_free_matrix (&buffers[i][0].matrix);
+  free (buffers[i]);
 
   for (j = i; j < Nbuffers - 1; j++) buffers[j] = buffers[j + 1];

trunk/Ohana/src/opihi/lib.shell/VectorOps.c

@@ -79 +79 @@
 
   free (vectors[i][0].elements);
+  free (vectors[i]);
   for (j = i; j < Nvectors - 1; j++) vectors[j] = vectors[j + 1];
 
@@ -96 +97 @@
 
   free (vectors[i][0].elements);
+  free (vectors[i]);
   for (j = i; j < Nvectors - 1; j++) vectors[j] = vectors[j + 1];
 
@@ -136 +138 @@
   /* delete vector entry from vector list, if it exists */
   for (i = 0; (i < Nvectors) && (in != vectors[i]); i++);
-  if (i == Nvectors) return (TRUE);
+  if (i == Nvectors) {
+    free (in);
+    return (TRUE);
+  }
 
   for (j = i; j < Nvectors - 1; j++) vectors[j] = vectors[j + 1];
   Nvectors -= 1;
   REALLOCATE (vectors, Vector *, MAX (Nvectors, 1));
+  free (in);
   return (TRUE);
 }

trunk/Ohana/src/opihi/lib.shell/command.c

@@ -1 +1 @@
 # include "opihi.h"
 # define VERBOSE 0
+
+static int Ncalls = 0;
 
 int command (char *line, char **outline) {
@@ -7 +9 @@
   char **argv, **targv;
   Command *cmd;
+
+  Ncalls ++;
 
   /* force a space between ! and first word: !ls becomes ! ls */
@@ -73 +77 @@
 
 }
+
+void print_ncals () {
+  fprintf (stderr, "Ncalls command: %d\n", Ncalls);
+}

trunk/Ohana/src/opihi/lib.shell/dvomath.c

@@ -68 +68 @@
     case 1:
       MoveVector (vec, stack[0].vector);
-      free (stack[0].vector);
       break;
   
     case 2:
       MoveBuffer (buf, stack[0].buffer);
-      free (stack[0].buffer);
       break;
   }