Changeset 40447

Timestamp:

Jun 11, 2018, 2:33:59 PM (8 years ago)

Author:

eugene

Message:

return false from psphotReadoutCleanup if quality is bad

Location:

trunk/psphot/src

Files:

• psphotReadout.c (modified) (1 diff)
• psphotReadoutCleanup.c (modified) (3 diffs)

trunk/psphot/src/psphotReadout.c

@@ -94 +94 @@
     // generate a background model (median, smoothed image)
     if (!psphotModelBackground (config, view, filerule)) {
+      // XXX this should result in a bad quality flag
         return psphotReadoutCleanup (config, view, filerule);
     }

trunk/psphot/src/psphotReadoutCleanup.c

@@ -55 +55 @@
     // XXX where do we free these, in here (psMetadataRemove?)
 
+    // XXX this is currently only set by psphotModelBackground / psphotModelBackgroundReadoutFileIndex / psphotModelBackgroundReadout
+    // if the image background cannot be measured (no valid pixels)
     int quality = psMetadataLookupS32 (&status, readout->analysis, "PSPHOT_QUALITY");
     if (quality) {
@@ -74 +76 @@
             return false;
         }
+    }
+
+    // Check to see if any sources were detected
+    // This is not necessarily a quality error: e.g., ppSub
+    if (0 && !psf && !sources) {
+      psError(PSPHOT_ERR_DATA, false, "Unable to detect sources in the image");
+      return false;
     }
 
@@ -115 +124 @@
 
     psFree (header);
+    if (quality) return false;
+
     return true;
 }