Changeset 40895

Timestamp:

Sep 24, 2019, 11:12:13 AM (7 years ago)

Author:

fairlamb

Message:

modified generic utils to throw ValidationErrors, also forgot to commit subprocess changes...

Location:

branches/ipp-132_automate_jira_conf_backups/utils/python

Files:

• generic_utils.py (added)
• generic_utils_test.py (added)
• subprocess_utils.py (modified) (2 diffs)

branches/ipp-132_automate_jira_conf_backups/utils/python/subprocess_utils.py

@@ -2 +2 @@
 
 # Plans are to flesh this out a bit more to make some smarter copying etc
+
+
+class SubprocessError(Exception):
+    """Errors in Popen stderr subprocess"""
+
+
+def _args_check(args, function_name):
+    if args is None:
+        print("Error: no arguments provided in ", function_name)
+        return 2
+    if type(args) != list or len(args) == 0:
+        print("Error: at least 1 arg must be given for ", function_name)
+        return 2
+    return 0
 
 
@@ -18 +32 @@
 
 
+def chmod_wrapper(args: [str]):
+    if args is None:
+        return 2
+    command_and_args = ["chmod"] + args
+    return simple_unix_wrapper(command_and_args)
+
+
 def simple_unix_wrapper(command_and_args: [str]):
-    if command_and_args is None:
-        print("error: unix wrapper needs some arguments")
-        return 2
-    if type(command_and_args) != list or len(command_and_args) == 0:
-        print("error: unix wrapper requires at least 1 arg")
-        return 2
+    """ This should provide the program name and all arguments in a list.
+
+Only a single command should be called.
+    """
+    arg_check = _args_check(command_and_args, simple_unix_wrapper.__name__)
+    if arg_check != 0:
+        return arg_check
 
     try: