Changeset 41168

Timestamp:

Nov 27, 2019, 11:25:02 AM (7 years ago)

Author:

eugene

Message:

add some comments

File:

• branches/eam_branches/ipp-20191011/ippToPsps/jython/stackbatch.py (modified) (1 diff)

branches/eam_branches/ipp-20191011/ippToPsps/jython/stackbatch.py

@@ -422 +422 @@
             sqlLine.group("a.dvoRegionID",             "b.catID")                       # this is not filter dependent, but is re-written for each filter (if data exists)
             sqlLine.group("a.primaryDetection",        "((b.flags & 0x10000) >> 16)")   # this is not filter dependent, but is re-written for each filter (if data exists)
+            ### XXX : primaryDetection is wrong: it should have calculated if (b.flags & 0x10000) was set for all filters
+            ### b.flags is the filter-dependent STACK_PRIMARY bit -- thus only true if the y-band is primary
+
             sqlLine.group("a.bestDetection",           "((b.objflags & 0x8000) >> 15)") # this is not filter dependent, but is re-written for each filter (if data exists)
+            ### XXX : bestDetection grabs the wrong bit.  It should have been (b.filtflags & 0x8000) or (b.objflags  & 0x10000000)
 
             sqlLine.group("a."+filter+"haveData",      "'1'")