Changeset 41498

Timestamp:

Feb 18, 2021, 11:10:42 AM (5 years ago)

Author:

eugene

Message:

count the number of chips which succeed and which fail, warn if too small a fraction succeed

File:

• trunk/psastro/src/psastroMosaicChipAstrom.c (modified) (3 diffs)

trunk/psastro/src/psastroMosaicChipAstrom.c

@@ -21 +21 @@
     pmReadout *readout = NULL;
     pmFPAview *view = pmFPAviewAlloc (0);
+
+    float minGoodChipFraction = psMetadataLookupF32 (&status, recipe, "PSASTRO.MOSAIC.MIN.GOOD.CHIP.FRACTION");
+    if (!status) { 
+      minGoodChipFraction = 0.1;      
+      psWarning ("failed to find PSASTRO.MOSAIC.MIN.GOOD.CHIP.FRACTION in recipe, assuming default of %f", minGoodChipFraction); 
+    }
+
+    int nChipGood = 0;
+    int nChipFail = 0;
 
     // this loop selects the matched stars for all chips
@@ -51 +60 @@
                     psErrorStackPrint(stderr, "failure for one chip\n");
                     psErrorClear();
+                    nChipFail ++;
                     continue;
                 }
@@ -60 +70 @@
                     psErrorStackPrint(stderr, "failure for one chip\n");
                     psErrorClear();
+                    nChipFail ++;
                     continue;
                 }
+                nChipGood ++;
             }
         }
     }
     psFree (view);
+
+    // if basically the entire exposure is bad, return false (calling function sets bad quality)
+    float fGood = nChipGood / ((float) (nChipGood + nChipFail));
+    if (fGood < minGoodChipFraction) {
+      psWarning ("Too few good chips (%d of %d = %.2f), setting bad quality for this exposure\n", nChipGood, (nChipGood + nChipFail), fGood);
+      // return false;
+    }
+
     return true;
 }
+
+// XXX count success and failures
+// XXX set bad quality if fraction of successes < threshold
+// XXX e.g., 5% success would mean 3 of 60 GPC1 chips are goo.
+// XXX or, 10% would be 6 of 60.
+// XXX seems like a good indicator of failure.
+// XXX also, test CERROR against a minimum value?