Changeset 41532 for trunk

Timestamp:

Apr 3, 2021, 2:18:12 PM (5 years ago)

Author:

eugene

Message:

minor comment changes

Location:

trunk/psLib/src

Files:

• math/psMinimizePolyFit.c (modified) (2 diffs)
• sys/psThread.c (modified) (1 diff)
• types/psMetadata.c (modified) (1 diff)

trunk/psLib/src/math/psMinimizePolyFit.c

@@ -19 +19 @@
  *  XXX: For clip-fit functions, what should we do if the mask is NULL?
  *
+ *  XXX: the sums are built for 2*(order + 1) elements, but it should be 2*order + 1
  */
 
@@ -2250 +2251 @@
         }
 
-        if (!psVectorStats (stats, resid, NULL, mask, maskValue)) {
+        if (!psVectorStats(stats, resid, NULL, mask, maskValue)) {
             psError(PS_ERR_UNKNOWN, false, "Could not compute statistics on the resid vector.  Returning NULL.\n");
             psFree(resid);

trunk/psLib/src/sys/psThread.c

@@ -296 +296 @@
     for (int i = 0; i < nThreads; i++) {
         psThread *thread = pool->data[i] = psThreadAlloc(); // Thread for pool
+        // XXX these threads are not destroyed, creating a minor leak
         if (pthread_create(&threads[i], NULL, psThreadLauncher, thread)) {
             psAbort("Unable to create thread");

trunk/psLib/src/types/psMetadata.c

@@ -1193 +1193 @@
         int regRtn = regcomp(newIter->regex, regex, 0);
         if (regRtn != 0) {
-            char errMsg[256];
+            char errMsg[256]; // fixed buffer length should match in call below
             regerror(regRtn, newIter->regex, errMsg, 256);
             psError(PS_ERR_BAD_PARAMETER_VALUE, true,