Changeset 41814 for branches/eam_branches/ipp-dev-20210817/psModules

Timestamp:

Sep 27, 2021, 8:16:29 AM (5 years ago)

Author:

eugene

Message:

adding stdev of median residual in bins as a more-robust measure of astrometry success

Location:

branches/eam_branches/ipp-dev-20210817/psModules/src/astrom

Files:

• pmAstrometryObjects.c (modified) (4 diffs)
• pmAstrometryObjects.h (modified) (1 diff)

branches/eam_branches/ipp-dev-20210817/psModules/src/astrom/pmAstrometryObjects.c

@@ -340 +340 @@
     psVector *yResGood = psVectorAllocEmpty (match->n, PS_TYPE_F32);
 
+    // we measure the stdev of the median residual in NxN bins.
+    // use only valid (not NAN) measurements
+    psVector *xPosValid = psVectorAllocEmpty (match->n, PS_TYPE_F32);
+    psVector *yPosValid = psVectorAllocEmpty (match->n, PS_TYPE_F32);
+    psVector *xResValid = psVectorAllocEmpty (match->n, PS_TYPE_F32);
+    psVector *yResValid = psVectorAllocEmpty (match->n, PS_TYPE_F32);
+
     for (int i = 0; i < match->n; i++) {
         if (mask->data.PS_TYPE_VECTOR_MASK_DATA[i]) continue;
@@ -345 +352 @@
         pmAstromObj *rawStar = raw->data[pair->raw];
         if (!isfinite(rawStar->dMag)) continue;
+
+        bool isValid = true;
+        isValid = isValid & isfinite (xFit->data.F32[i]);
+        isValid = isValid & isfinite (yFit->data.F32[i]);
+        isValid = isValid & isfinite (xRes->data.F32[i]);
+        isValid = isValid & isfinite (yRes->data.F32[i]);
+        if (isValid) {
+          psVectorAppend (xPosValid, xFit->data.F32[i]);
+          psVectorAppend (yPosValid, yFit->data.F32[i]);
+          psVectorAppend (xResValid, xRes->data.F32[i]);
+          psVectorAppend (yResValid, yRes->data.F32[i]);
+        }
+
+        // for the systematic error, use only high S/N stars
         if (rawStar->dMag > 0.02) continue;
 
@@ -377 +398 @@
       results->dYrange = pmAstromVectorRange (yResGood, 0.1, 0.9, results->yStats->clippedStdev);
 
-      results->dXstdev = pmAstrom2DSystematics (xFit, yFit, xRes);
-      results->dYstdev = pmAstrom2DSystematics (xFit, yFit, yRes);
-    }
-
-    psTrace ("psModules.astrom", 3, "dXsys: %f, dXrange: %f\n", results->dXsys, results->dXrange);
-    psTrace ("psModules.astrom", 3, "dYsys: %f, dYrange: %f\n", results->dYsys, results->dYrange);
+      results->dXstdev = pmAstrom2DSystematics (xPosValid, yPosValid, xResValid);
+      results->dYstdev = pmAstrom2DSystematics (xPosValid, yPosValid, yResValid);
+    }
+
+    psTrace ("psModules.astrom", 3, "dXsys: %f, dXrange: %f, dXstdev: %f\n", results->dXsys, results->dXrange, results->dXstdev);
+    psTrace ("psModules.astrom", 3, "dYsys: %f, dYrange: %f, dYstdev: %f\n", results->dYsys, results->dYrange, results->dYstdev);
 
     psFree (xErr);
@@ -390 +411 @@
     psFree (xResGood);
     psFree (yResGood);
+    psFree (xPosValid);
+    psFree (yPosValid);
+    psFree (xResValid);
+    psFree (yResValid);
 
     psFree (x);

branches/eam_branches/ipp-dev-20210817/psModules/src/astrom/pmAstrometryObjects.h

@@ -102 +102 @@
     double  dXrange;                    ///< 10% - 90% range X residuals (unmasked, high S/N)
     double  dYrange;                    ///< 10% - 90% range Y residuals (unmasked, high S/N)
+    double  dXstdev;                    ///< stdev of median residual in NxN bins
+    double  dYstdev;                    ///< stdev of median residual in NxN bins
 }
 pmAstromFitResults;