Changeset 41824 for branches/eam_branches/ipp-dev-20210817

Timestamp:

Sep 29, 2021, 12:05:40 PM (5 years ago)

Author:

eugene

Message:

fix the sense of the mask for the nan/inf values

File:

• branches/eam_branches/ipp-dev-20210817/Ohana/src/opihi/cmd.data/vstats.c (modified) (2 diffs)

branches/eam_branches/ipp-dev-20210817/Ohana/src/opihi/cmd.data/vstats.c

@@ -88 +88 @@
       mask[i] = 0; // do not mask unless we have a reason below
       if (tvec) {
-        // note the logical vector is 0 == bad (ignore)
+        // note the logical vector is 0 == bad (ignore) while mask[i] has the opposite sense (0 is good)
         mask[i] = (tvec->type == OPIHI_FLT) ? (tvec->elements.Flt[i] == 0.0) : (tvec->elements.Int[i] == 0);
       }
-      if (!finite (*X)) { mask[i] = 0; }
-      if (Ignore && (*X == IgnoreValue)) { mask[i] = 0; }
+      if (!finite (*X)) { mask[i] = 1; }
+      if (Ignore && (*X == IgnoreValue)) { mask[i] = 1; }
     }      
   } else {
@@ -99 +99 @@
       mask[i] = 0; // do not mask unless we have a reason below
       if (tvec) {
-        // note the logical vector is 0 == bad (ignore)
+        // note the logical vector is 0 == bad (ignore) while mask[i] has the opposite sense (0 is good)
         mask[i] = (tvec->type == OPIHI_FLT) ? (tvec->elements.Flt[i] == 0.0) : (tvec->elements.Int[i] == 0);
       }
-      if (!finite (*X)) { mask[i] = 0; }
-      if (Ignore && (*X == IgnoreValue)) { mask[i] = 0; }
+      if (!finite (*X)) { mask[i] = 1; }
+      if (Ignore && (*X == IgnoreValue)) { mask[i] = 1; }
     }      
   }