Changeset 41865 for branches/eam_branches/ipp-dev-20210817

Timestamp:

Oct 26, 2021, 6:39:43 AM (5 years ago)

Author:

eugene

Message:

PATTERN.ROW,.CELL,.CONTINUITY options moved after the top block of selections; PATTERN.ROW.THRESH reduced (20 -> 3) and .ITER set to 3; PATTERN.ROW.USE.BINNED, PATTERN.ROW.POISSON defined but not yet respected in code: this will allow future code to distinguish chipRuns using the old vs the new PATTERN.ROW code

File:

• branches/eam_branches/ipp-dev-20210817/ippconfig/recipes/ppImage.config (modified) (2 diffs)

branches/eam_branches/ipp-dev-20210817/ippconfig/recipes/ppImage.config

@@ -23 +23 @@
 VARIANCE.BUILD     BOOL    FALSE           # Build internal variance image
 ADDNOISE           BOOL    FALSE           # Add noise to degrade an MD image to a 3pi image?
-PATTERN.ROW        BOOL    FALSE           # Row pattern correction
-PATTERN.ROW.SUBSET METADATA                # Menu of chips and/or cells for row pattern correction
-END
-PATTERN.CELL       BOOL    FALSE           # Cell pattern correction
-PATTERN.CELL.SUBSET METADATA               # Menu of chips and/or cells for cell pattern correction
-END
-PATTERN.SUBSET     METADATA
-END
-PATTERN.CONTINUITY BOOL    FALSE
-PATTERN.CONTINUITY.WIDTH S32  50
-PATTERN.CONTINUITY.SUBSET METADATA         # Menu of chips and/or cells for cell pattern continuity correction
-END
+PATTERN.ROW        BOOL    FALSE           # Row pattern correction (see options below)
+PATTERN.CELL       BOOL    FALSE           # Cell pattern correction (see options below)
+PATTERN.CONTINUITY BOOL    FALSE           # continuity corrections (see options below)
 FRINGE             BOOL    FALSE           # Fringe subtraction
 PHOTOM             BOOL    FALSE           # Source identification and photometry
@@ -111 +102 @@
 OVERSCAN.VALUE          F32     0.0             # value to apply, if requested
 
-# Pattern subtraction options
+# Pattern Row subtraction options
 PATTERN.ROW.ORDER      S32     2               # Polynomial order for row pattern
-PATTERN.ROW.ITER       S32     4               # Rejection iterations for row pattern
+PATTERN.ROW.ITER       S32     3               # Rejection iterations for row pattern
 PATTERN.ROW.REJ        F32     2.5             # Rejection threshold for row pattern
-PATTERN.ROW.THRESH     F32     20.0            # Ignore threshold for row pattern
+PATTERN.ROW.THRESH     F32     3.0             # Ignore threshold for row pattern
 PATTERN.ROW.MEAN       STR     SAMPLE_MEAN     # Statistic for mean for row pattern
 PATTERN.ROW.STDEV      STR     SAMPLE_STDEV    # Statistic for standard deviation for row pattern
+PATTERN.ROW.USE.BINNED BOOL    TRUE            # pre-bin along the row before calculating (NOT yet respected r41656)
+PATTERN.ROW.POISSON    BOOL    TRUE            # use Poisson stats on the sky to set threshold (NOT yet respected r41656)
+
+PATTERN.ROW.SUBSET     METADATA                # Menu of chips and/or cells for row pattern correction
+END
+
+# NOTE: PATTERN.ROW.SUBSET is defined in the format_DATE.config files because
+# in different periods, the camera had different amounts of row-by-row bias drift
+# for a given cell.  It is necessary to make the choice of whether to correct the 
+# pattern based on the epoch the exposure was taken.
+
+# NOTE: if PATTERN.ROW.SUBSET entries are missing for a given chip, the default 
+# behavior is to NOT correct for the effect. (This makes sense since most camera
+# are not GPC1 and thus do not need the correction).
+
+# Pattern Cell options
 PATTERN.CELL.BG        STR     FITTED_MEAN     # Statistic for background for cell pattern
 PATTERN.CELL.MEAN      STR     SAMPLE_MEDIAN   # Statistic for mean for cell pattern
+PATTERN.CELL.SUBSET    METADATA                # Menu of chips and/or cells for cell pattern correction
+END
+
+# Pattern Continuity options
+PATTERN.CONTINUITY.WIDTH S32  50
+PATTERN.CONTINUITY.SUBSET METADATA         # Menu of chips and/or cells for cell pattern continuity correction
+END
+
+# r41656 : this does not appear to be used any more: superceded by PATTERN.ROW, .CELL, .CONTINUITY
+PATTERN.SUBSET     METADATA
+END
 
 # Fringe subtraction options