Changeset 42012 for branches/eam_branches/ipp-20211108

Timestamp:

Feb 6, 2022, 10:39:31 AM (4 years ago)

Author:

eugene

Message:

the model guess was using Mrf (1st radial moment) to set the ellipse
major axis size, but this value is often much too large. The
motivation to use Mrf was largely driven (if I remember correctly) by
the Mxx,Myy values sometimes being much too small for faint objects
(even negative). I decided that the Kron radius was more reliable at
the small / faint end.

I have now gone back to using (Mxx, Myy) to define the guess size, but
putting in two modifications. First, the major axis now has a lower
bound of 1.0 pixel. This avoids crazy small values. Second, the
major axis is calculated as the value predicted from Mxx scaled by
some factor. This is set to a value which is model dependent.

Note that the Mxx,Myy values are calculated with a Gaussian window, so
they are normally too small even for a Gaussian. Also, depending o
the model form, there is naturally a bias between the Mxx,Myy values
and the model major axis: only for Gaussians should they be exactly
the same.

Ideally, I should run some simulation to compare the measured Mxx,Myy
with the true major axis value as a function of model class, seeing,
etc. for now I just have some guesses.

Location:

branches/eam_branches/ipp-20211108/psModules/src/objects

Files:

• models/pmModel_GAUSS.c (modified) (1 diff)
• models/pmModel_HSC_V1.c (modified) (1 diff)
• models/pmModel_PGAUSS.c (modified) (1 diff)
• models/pmModel_PS1_V1.c (modified) (1 diff)
• models/pmModel_QGAUSS.c (modified) (1 diff)
• models/pmModel_RGAUSS.c (modified) (1 diff)
• pmModelUtils.c (modified) (2 diffs)
• pmModelUtils.h (modified) (1 diff)

branches/eam_branches/ipp-20211108/psModules/src/objects/models/pmModel_GAUSS.c

@@ -203 +203 @@
 
     // set the shape parameters
-    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false)) {
+    // the last parameter is the scaling factor for Moments to shape parameter radius guess
+    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false, 1.0)) {
       return false;
     }

branches/eam_branches/ipp-20211108/psModules/src/objects/models/pmModel_HSC_V1.c

@@ -223 +223 @@
 
     // set the shape parameters
-    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false)) {
+    // the last parameter is the scaling factor for Moments to shape parameter radius guess
+    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false, 1.0)) {
       return false;
     }

branches/eam_branches/ipp-20211108/psModules/src/objects/models/pmModel_PGAUSS.c

@@ -204 +204 @@
 
     // set the shape parameters
-    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false)) {
+    // the last parameter is the scaling factor for Moments to shape parameter radius guess
+    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false, 1.0)) {
       return false;
     }

branches/eam_branches/ipp-20211108/psModules/src/objects/models/pmModel_PS1_V1.c

@@ -223 +223 @@
 
     // set the shape parameters
-    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false)) {
+    // the last parameter is the scaling factor for Moments to shape parameter radius guess
+    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false, 1.0)) {
       return false;
     }

branches/eam_branches/ipp-20211108/psModules/src/objects/models/pmModel_QGAUSS.c

@@ -224 +224 @@
 
     // set the shape parameters
-    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false)) {
+    // the last parameter is the scaling factor for Moments to shape parameter radius guess
+    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false, 1.5)) {
       return false;
     }

branches/eam_branches/ipp-20211108/psModules/src/objects/models/pmModel_RGAUSS.c

@@ -213 +213 @@
 
     // set the shape parameters
-    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false)) {
+    // the last parameter is the scaling factor for Moments to shape parameter radius guess
+    if (!pmModelSetShape(&PAR[PM_PAR_SXX], &PAR[PM_PAR_SXY], &PAR[PM_PAR_SYY], source->moments, false, 2.0)) {
       return false;
     }

branches/eam_branches/ipp-20211108/psModules/src/objects/pmModelUtils.c

@@ -179 +179 @@
 // Reff says if this is a model which uses R_eff (like exp or dev) instead of Sigma
 // set the parameter values SXX, SXY, SYY
-bool pmModelSetShape (float *Sxx, float *Sxy, float *Syy, pmMoments *moments, bool useReff) {
+// Scale allows some models to increase the guess size relative to Mxx,Myy
+bool pmModelSetShape (float *Sxx, float *Sxy, float *Syy, pmMoments *moments, bool useReff, float Scale) {
 
     psEllipseMoments emoments;
@@ -190 +191 @@
 
     if (!isfinite(axes.major)) return false;
-    if (axes.major == 0) return false;
     if (!isfinite(axes.minor)) return false;
     if (!isfinite(axes.theta)) return false;
-    if (axes.major == 0) return false;
-
+
+    // set a lower limit to avoid absurd solutions..
+    // NOTE: I should set the lower limit based on the PSF size, if known
+    float Rmajor = PS_MAX(1.0, Scale * axes.major);
+    float Rminor = Rmajor * (axes.minor / axes.major);
+    axes.major = Rmajor;
+    axes.minor = Rminor;
+
+    // EAM 2022.02.05 : Mrf is often much too large, disable this for now
     // Mxx, Mxy, Myy define the elliptical shape, but Mrf defines the width 
-    float scale = (isfinite(moments->Mrf) && (moments->Mrf > 0.0)) ? moments->Mrf / axes.major : 1.0;
-    axes.major *= scale;
-    axes.minor *= scale;
+    // float scale = (isfinite(moments->Mrf) && (moments->Mrf > 0.0)) ? moments->Mrf / axes.major : 1.0;
+    // axes.major *= scale;
+    // axes.minor *= scale;
 
     pmModelAxesToParams (Sxx, Sxy, Syy, axes, useReff);

branches/eam_branches/ipp-20211108/psModules/src/objects/pmModelUtils.h

@@ -44 +44 @@
 bool pmModelSetPosition (float *Xo, float *Yo, pmSource *source);
 bool pmModelSetNorm (float *Io, pmSource *source);
-bool pmModelSetShape (float *Sxx, float *Sxy, float *Syy, pmMoments *moments, bool useReff);
+bool pmModelSetShape (float *Sxx, float *Sxy, float *Syy, pmMoments *moments, bool useReff, float Scale);
 
 bool pmModelUseReff (pmModelType type);