Changeset 42086

Timestamp:

Feb 28, 2022, 2:33:50 PM (4 years ago)

Author:

eugene

Message:

injected sources used for detection efficiency are rejected if the minimum radius is too small : ensure the source radius is never < 5 x smoothSigma * smoothNsigma

File:

• trunk/psphot/src/psphotEfficiency.c (modified) (6 diffs)

trunk/psphot/src/psphotEfficiency.c

@@ -3 +3 @@
 #define MODEL_MASK (PM_MODEL_STATUS_NONCONVERGE | PM_MODEL_STATUS_OFFIMAGE | \
                     PM_MODEL_STATUS_BADARGS | PM_MODEL_STATUS_LIMITS) // Mask to apply to models
-
-# define TESTING 0
 
 // Calculate the limiting magnitude for an image
@@ -122 +120 @@
              meanVar, *covarFactor, thresh, *norm, *magLim);
 
-    *radius = smoothSigma * smoothNsigma;
+    *radius = 5 * smoothSigma * smoothNsigma;
 
     *minFlux = 0.1 * sqrtf(meanVar);
+
+    psLogMsg ("psphot", PS_LOG_INFO, "Detection efficiency PSF radius: %d, minFlux: %f\n", *radius, *minFlux);
 
     return true;
@@ -291 +291 @@
     psphotRemoveAllSourcesByArray(realSources, recipe);
 
+# define TESTING 0
 #if TESTING
     {
@@ -340 +341 @@
     psphotSaveImage(NULL, readout->mask, "fake_mask.fits");
 #endif
+#undef TESTING
 
     // XXX Could speed this up significantly by only convolving the central pixels of each fake source
@@ -424 +426 @@
                     continue;
                 }
+
+                // XXX this radius is too small : for faint sources the modelSum < 0.8*modelNorm and the
+                // source is rejected.  Add a factor of 2.0 to be sure we get value fluxes
                 float sourceRadius = PS_MAX(radius, model->class->modelRadius(model->params, minFlux)); // Radius for source
                 psFree(model);
@@ -536 +541 @@
         psVectorInit(magMask, 0);
 
+# define TESTING 0
 #if TESTING
         psString name = NULL;