Changeset 42327

Timestamp:

Jan 26, 2023, 10:41:25 AM (3 years ago)

Author:

eugene

Message:

adding comments on Overscan; adding new nonlinearity correction

Location:

branches/eam_branches/psModules.20230123/src/detrend

Files:

• pmNewNonLinear.c (added)
• pmNewNonLinear.h (added)
• pmOverscan.c (modified) (1 diff)

branches/eam_branches/psModules.20230123/src/detrend/pmOverscan.c

@@ -136 +136 @@
         break;
       case PM_FIT_SPLINE:
-        // XXX I don't think psSpline1D is up to scratch yet --- it has no mask, and requires an
-        // input spline
+
+        // XXX I don't think psSpline1D is up to scratch yet --- it has no mask, and it assumes
+        // a knot for every input point.  it needs an argument like 'number of knots' for the
+        // output spline.  EAM: still true 2023.01.22
+
         overscanOpts->spline = psVectorFitSpline1D(reduced, ordinate);
         fitted = psSpline1DEvalVector(overscanOpts->spline, ordinate);