Changeset 42407 for trunk/psModules

Timestamp:

Mar 10, 2023, 9:46:16 AM (3 years ago)

Author:

eugene

Message:

do not attempt to free "results" before it is allocated

File:

• trunk/psModules/src/detrend/pmDetrendDB.c (modified) (3 diffs)

trunk/psModules/src/detrend/pmDetrendDB.c

@@ -143 +143 @@
         if (!type) {
           psError (PM_ERR_CONFIG, false, "unknown detrend type %d", options->type);
-          goto failure;
+          goto failure_v1; // this goto must NOT free 'results'
         }
     }
-    unsigned int nFail;
 
     pmDetrendSelectResults *results = pmDetrendSelectResultsAlloc();
@@ -229 +228 @@
     psTrace("psModules.detrend", 5, "got answer: %s\n", buffer->data);
 
-    nFail = 0;
+    unsigned int nFail = 0;
     answer = psMetadataConfigParse (NULL, &nFail, buffer->data, false);
     if (!answer) {
@@ -279 +278 @@
     return results;
 
-failure:
+ failure:
+    psFree (results);
+ failure_v1:
     psFree (answer);
-    psFree (results);
     psFree (pipe);
     psFree (buffer);