Changeset 42410

Timestamp:

Mar 13, 2023, 10:07:18 AM (3 years ago)

Author:

eugene

Message:

handle failurs in two additional cases as bad quality (including the issue mentioned by Bill Sweeney in r36581 & that from EAM in r37080)

File:

• branches/eam_branches/ipp-20230313/ppSub/src/ppSubMatchPSFs.c (modified) (2 diffs)

branches/eam_branches/ipp-20230313/ppSub/src/ppSubMatchPSFs.c

@@ -155 +155 @@
     }
     psLogMsg("ppSub", PS_LOG_INFO, "Input FWHM: %f\nReference FWHM: %f\n", inFWHM, refFWHM);
+
+# define SET_QUALITY_INSTEAD_OF_ERROR 
+    // Bill Sweeney added the following block to cleanly handle bad FWHMs as a bad quality
+    // instead of failing with a fault, but left the code inactive.  Activate it here
     if (!isfinite(inFWHM) || !isfinite(refFWHM)) {
 #ifdef SET_QUALITY_INSTEAD_OF_ERROR
@@ -458 +462 @@
             ppSubDataQuality(data, error, PPSUB_FILES_ALL);
             return true;
-        // XX } else if (error == PM_ERR_DATA) {
-        // XX     psErrorStackPrint(stderr, "Unable to solve for the kernel to match images");
-        // XX     psWarning("Failed to find PSF match kernel --- suspect bad data quality.");
-        // XX     ppSubDataQuality(data, error, PPSUB_FILES_ALL);
-        // XX     return true;
+        } else if (error == PM_ERR_DATA) {
+             psErrorStackPrint(stderr, "Unable to solve for the kernel to match images");
+             psWarning("Failed to find PSF match kernel --- suspect bad data quality.");
+             ppSubDataQuality(data, error, PPSUB_FILES_ALL);
+             return true;
         } else {
             psError(PPSUB_ERR_DATA, false, "Unable to match images.");