Changeset 42914

Timestamp:

Aug 24, 2025, 11:54:49 AM (11 months ago)

Author:

eugene

Message:

for some opihi shells, we do NOT want to save the history; if HISTORY is set to NONE or not set, do not call add_history. this avoids memory build up and general sluggishness

File:

• tags/ipp-unions-20250528/Ohana/src/opihi/lib.shell/opihi.c (modified) (3 diffs)

tags/ipp-unions-20250528/Ohana/src/opihi/lib.shell/opihi.c

@@ -4 +4 @@
 int opihi (int argc, char **argv) {
 
-  int Nbad;
   char *line, *prompt, *history;
   pid_t ppid;
@@ -15 +14 @@
   welcome ();
 
-  Nbad = 0;
+  // if HISTORY is defined, and does not have the value NONE, save history
+  int SaveHistory = TRUE;
+  if (!history || !strcasecmp(history, "none")) { SaveHistory = FALSE; }
+
+  int Nbad = 0;
   while (1) {  /** must exit with command "exit" or "quit" */
     if (Nbad == 10) exit (20);
@@ -40 +43 @@
     if (*line) {
       multicommand (line);
-      add_history (line);
+      if (SaveHistory) { add_history (line); }
 
 // the libedit version of readline does not support an incremental write to history file
 # ifdef RL_READLINE_VERSION
-      if (history != NULL) append_history (1, history);
+      if (SaveHistory) { append_history (1, history); }
 # endif