Changeset 42919

Timestamp:

Sep 2, 2025, 10:09:16 AM (11 months ago)

Author:

eugene

Message:

do not save pcontrol or pclient history to internal buffer; free "realhost" when freeing a job

Location:

trunk/Ohana/src/opihi

Files:

• lib.shell/opihi.c (modified) (3 diffs)
• pclient/pclient.c.in (modified) (1 diff)
• pcontrol/JobOps.c (modified) (1 diff)
• pcontrol/pcontrol.c.in (modified) (1 diff)

trunk/Ohana/src/opihi/lib.shell/opihi.c

@@ -4 +4 @@
 int opihi (int argc, char **argv) {
 
-  int Nbad;
   char *line, *prompt, *history;
   pid_t ppid;
@@ -15 +14 @@
   welcome ();
 
-  Nbad = 0;
+  // if HISTORY is defined, and does not have the value NONE, save history
+  int SaveHistory = TRUE;
+  if (!history || !strcasecmp(history, "none")) { SaveHistory = FALSE; }
+
+  int Nbad = 0;
   while (1) {  /** must exit with command "exit" or "quit" */
     if (Nbad == 10) exit (20);
@@ -40 +43 @@
     if (*line) {
       multicommand (line);
-      add_history (line);
+      if (SaveHistory) { add_history (line); }
 
 // the libedit version of readline does not support an incremental write to history file
 # ifdef RL_READLINE_VERSION
-      if (history != NULL) append_history (1, history);
+      if (SaveHistory) { append_history (1, history); }
 # endif
 

trunk/Ohana/src/opihi/pclient/pclient.c.in

@@ -4 +4 @@
 # define opihi_prompt "pclient: "
 # define opihi_description "pcontrol client shell\n"
-# define opihi_history ""
+# define opihi_history "NONE"
 # define opihi_rcfile ".pcontrolrc"
 

trunk/Ohana/src/opihi/pcontrol/JobOps.c

@@ -270 +270 @@
 
   FREE (job[0].hostname);
+  FREE (job[0].realhost);
   for (i = 0; i < job[0].argc; i++) {
     FREE (job[0].argv[i]);

trunk/Ohana/src/opihi/pcontrol/pcontrol.c.in

@@ -6 +6 @@
 # define opihi_prompt "pcontrol: "
 # define opihi_description "pcontrol client shell\n"
-# define opihi_history ".pcontrol"
+# define opihi_history "NONE"
 # define opihi_rcfile ".pcontrolrc"