Changeset 43095

Timestamp:

Sep 21, 2026, 4:31:49 PM (3 days ago)

Author:

cclin33

Message:

fix 0 good chip issue for ipp-2536

File:

• tags/ipp-ops-20220906/psastro/src/psastroMosaicChipAstrom.c (modified) (2 diffs)

tags/ipp-ops-20220906/psastro/src/psastroMosaicChipAstrom.c

@@ -79 +79 @@
 
     // if basically the entire exposure is bad, return false (calling function sets bad quality)
-    float fGood = nChipGood / ((float) nChipTotal);
+    float fGood = (nChipTotal > 0) ? nChipGood / ((float) nChipTotal) : 0.0;
     psLogMsg ("psastro", PS_LOG_INFO, "%d good chips of %d = %.2f\n", nChipGood, nChipTotal, fGood);
     if (fGood < minGoodChipFraction) {
@@ -89 +89 @@
     }
 
+    // IPP-2536: with no good chips at all, the boresite fit, the zero point and
+    // the FPA WCS have nothing to work from.  Running the downstream stages on
+    // that state produces "zero point NaN" and then dies on a signal, which
+    // camera_exp.pl reports as the generic "Unable to perform psastro: 4".
+    // Report the condition instead; psastroAnalysis() turns it into a clean
+    // bad-quality exit.
+
+    if (nChipGood == 0) {
+        psWarning ("No good chips for this exposure; stopping mosaic astrometry\n");
+        return false;
+    }
+
     return true;
 }