Changeset 43120

Timestamp:

Oct 15, 2026, 4:51:41 PM (41 hours ago)

Author:

eugene

Message:

add an error message for all failure modes

File:

• branches/eam_branches/ipp-pstamp-20260421/psphot/src/psphotForcedReadout.c (modified) (3 diffs)

branches/eam_branches/ipp-pstamp-20260421/psphot/src/psphotForcedReadout.c

@@ -1 +1 @@
 # include "psphotInternal.h"
+
+# define CLEANUP { \
+  bool cleanupStatus = psphotReadoutCleanup (config, view, filerule); \
+  if (!cleanupStatus) { \
+    psError(psErrorCodeLast(), false, "failure in psphotForcedReadout for chip %d, cell %d, readout %d\n", view->chip, view->cell, view->readout); \
+  } \
+  return cleanupStatus; }
 
 bool psphotForcedReadout(pmConfig *config, const pmFPAview *view, const char *filerule) {
@@ -31 +38 @@
     // Generate the mask and weight images, including the user-defined analysis region of interest
     psphotSetMaskAndVariance (config, view, filerule);
-    if (!strcasecmp (breakPt, "NOTHING")) {
-        return psphotReadoutCleanup (config, view, filerule);
-    }
+    if (!strcasecmp (breakPt, "NOTHING")) CLEANUP;
 
     // generate a background model (median, smoothed image)
-    if (!psphotModelBackground (config, view, filerule)) {
-        return psphotReadoutCleanup (config, view, filerule);
-    }
-    if (!psphotSubtractBackground (config, view, filerule)) {
-        return psphotReadoutCleanup (config, view, filerule);
-    }
-    if (!strcasecmp (breakPt, "BACKMDL")) {
-        return psphotReadoutCleanup (config, view, filerule);
-    }
+    if (!psphotModelBackground (config, view, filerule)) CLEANUP;
+    if (!psphotSubtractBackground (config, view, filerule)) CLEANUP;
+    if (!strcasecmp (breakPt, "BACKMDL")) CLEANUP;
 
     if (!psphotLoadPSF (config, view, filerule)) {
         // this only happens if we had a programming error in psphotLoadPSF
         psError (PSPHOT_ERR_UNKNOWN, false, "error loading psf model");
-        return psphotReadoutCleanup (config, view, filerule);
+        CLEANUP;
     }
 
@@ -87 +86 @@
 
     // create the exported-metadata and free local data
-    return psphotReadoutCleanup (config, view, filerule);
+    CLEANUP;
 }