Changeset 4671 for trunk/Nebulous/nebclient

Timestamp:

Jul 29, 2005, 1:12:44 PM (21 years ago)

Author:

jhoblitt

Message:

add rigorous parameter validation to most functions

File:

• trunk/Nebulous/nebclient/src/nebclient.c (modified) (22 diffs)

trunk/Nebulous/nebclient/src/nebclient.c

@@ -4 +4 @@
  * Copyright (C) 2005  Joshua Hoblitt
  *
- * $Id: nebclient.c,v 1.35 2005-07-29 02:31:56 jhoblitt Exp $
+ * $Id: nebclient.c,v 1.36 2005-07-29 23:12:44 jhoblitt Exp $
  */
 
@@ -31 +31 @@
     p_nebSetErr(__FILE__, __LINE__, __func__, server,__VA_ARGS__)
 
+// this is a slightly more useful error message than returned by assert()
+#define REQUIRE_SERVER \
+    if (!server) { \
+        fprintf(stderr, "parameter 'server' may not be NULL"); \
+        abort(); \
+    }
+
 static void p_nebSetErr(const char * filename, unsigned long lineno, const char *function, nebServer *server, const char *format, ...);
 static void nebSetServerErr(nebServer *server);
@@ -63 +70 @@
 void nebServerFree(nebServer *server)
 {
+    if (!server) {
+        return;
+    }
+
     soap_end(server->soap); // remove deserialized data and clean up
     soap_done(server->soap); // detach the gSOAP environment
@@ -78 +89 @@
     int             file;
 
+    REQUIRE_SERVER;
+
     if (!key) {
         nebSetErr(server, "parameter 'key' may not be NULL");
@@ -122 +135 @@
     char            *filename;
     int             sourceFH, destFH;
+
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return false;
+    }
 
     if (soap_call_ns1__replicate_USCOREobject(server->soap, server->endpoint,
@@ -184 +205 @@
     nebObjectInstances *locations;
 
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return false;
+    }
+
     locations = nebFindInstances(server, key, NULL);
     if (!locations) {
@@ -207 +236 @@
     char            *type;
     int             response;
+
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return false;
+    }
 
     type = flag == NEB_READ ? "read" : "write";
@@ -237 +274 @@
     int             response;
 
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return false;
+    }
+
     type = flag == NEB_READ ? "read" : "write";
 
@@ -261 +306 @@
     char            **resultArray;
     nebObjectInstances *locations = NULL;
+
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return NULL;
+    }
 
     // FIXME is this leaking memory when response goes out of scope?  the gsoap
@@ -293 +346 @@
 void nebObjectInstancesFree(nebObjectInstances *locations)
 {
-    if (locations) {
-        for (int i = 0; i < locations->n; i++) {
-            nebFree(locations->URI[i]);
-        }
-
-        nebFree(locations);
+    if (!locations) {
+        return;
+    }
+
+    for (int i = 0; i < locations->n; i++) {
+        nebFree(locations->URI[i]);
     }
 }
@@ -306 +359 @@
     nebObjectInstances *locations;
     char            *filename;
+
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return NULL;
+    }
     
     locations = nebFindInstances(server, key, NULL);
@@ -331 +392 @@
     char            *filename;
     int             fh;
+
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return -1;
+    }
 
     locations = nebFindInstances(server, key, NULL);
@@ -375 +444 @@
     nebObjectInstances *locations;
 
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return false;
+    }
+
     locations = nebFindInstances(server, key, NULL);
     if (!locations) {
@@ -401 +478 @@
     int             destFH;
 
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return false;
+    }
+
+    if (!newKey) {
+        nebSetErr(server, "parameter 'newKey' may not be NULL");
+
+        return false;
+    }
+
     sourceFH = nebOpen(server, (char *)key, NEB_READ);
     if (sourceFH < 0) {
@@ -434 +525 @@
 bool nebMove(nebServer *server, const char *key, const char *newKey)
 {
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return false;
+    }
+
+    if (!newKey) {
+        nebSetErr(server, "parameter 'newKey' may not be NULL");
+
+        return false;
+    }
+
     if (!nebCopy(server, key, newKey)) {
         return false;
@@ -450 +555 @@
     char            *filename;
     bool            status;
+
+    REQUIRE_SERVER;
+
+    if (!URI) {
+        nebSetErr(server, "parameter 'URI' may not be NULL");
+
+        return false;
+    }
 
     if (!nebParseURI(server, URI, &filename)) {
@@ -481 +594 @@
     int             resultElements = 0;
     char            **resultArray = NULL;
+
+    REQUIRE_SERVER;
+
+    if (!key) {
+        nebSetErr(server, "parameter 'key' may not be NULL");
+
+        return NULL;
+    }
 
     stat = xmalloc(sizeof(nebObjectStat));
@@ -576 +697 @@
     const char      **string;
 
+    REQUIRE_SERVER;
+
     code   = soap_faultcode(server->soap);
     string = soap_faultstring(server->soap);
@@ -587 +710 @@
     int             destFH; 
     off_t           bytesCopied;
+
+    REQUIRE_SERVER;
 
     sourceFH = open(source, O_RDONLY);
@@ -629 +754 @@
     char            writeBuf[64 * 1024];
     struct stat     sourceStat;
+
+    REQUIRE_SERVER;
 
     if(fstat(sourceFH, &sourceStat)) {
@@ -683 +810 @@
     size_t          filename_size;
 
+    REQUIRE_SERVER;
+
     if (!URI) {
         return 0;
@@ -723 +852 @@
 static bool nebNukeFile(nebServer *server, const char *filename)
 {
+    REQUIRE_SERVER;
+
+    if (!filename) {
+        nebSetErr(server, "parameter 'filename' may not be NULL");
+
+        return false;
+    }
+
     if (unlink(filename) < 0) {
         nebSetErr(server, "unlink: %s", strerror(errno));