Changeset 5504

Timestamp:

Nov 10, 2005, 12:07:53 PM (21 years ago)

Author:

jhoblitt

Message:

change Nebulous::Server->create_object() to validate comment length

Location:

trunk

Files:

• Nebulous-Server/lib/Nebulous/Server.pm (modified) (3 diffs)
• Nebulous-Server/t/03_server_create_object.t (modified) (2 diffs)
• Nebulous/lib/Nebulous/Server.pm (modified) (3 diffs)
• Nebulous/t/03_server_create_object.t (modified) (2 diffs)

trunk/Nebulous-Server/lib/Nebulous/Server.pm

@@ -1 +1 @@
 # Copyright (c) 2004  Joshua Hoblitt
 #
-# $Id: Server.pm,v 1.16 2005-11-10 21:57:15 jhoblitt Exp $
+# $Id: Server.pm,v 1.17 2005-11-10 22:07:53 jhoblitt Exp $
 
 package Nebulous::Server;
@@ -90 +90 @@
         {
             type        => SCALAR,
+            callbacks   => {
+                # check that the comment isn't too long
+                'comment length' => sub { length $_[0] < 256 },
+            },
             optional    => 1,
         },
@@ -99 +103 @@
     # add hooks to make this decision based on avaiable space
     $volume = _get_storage_volume( $volume );
-
-    # check that the comment isn't too long
 
     my $uri;

trunk/Nebulous-Server/t/03_server_create_object.t

@@ -3 +3 @@
 # Copryight (C) 2004-2005  Joshua Hoblitt
 #
-# $Id: 03_server_create_object.t,v 1.9 2005-11-10 21:53:56 jhoblitt Exp $
+# $Id: 03_server_create_object.t,v 1.10 2005-11-10 22:07:53 jhoblitt Exp $
 
 use strict;
 use warnings FATAL => qw( all );
 
-use Test::More tests => 13;
+use Test::More tests => 14;
 
 use lib qw( ./t ./lib );
@@ -90 +90 @@
 
 eval {
+    $neb->create_object( 1, 0, 'node01', 'x' x 256 );
+};
+like( $@, qr/comment length/, "comment is too long" );
+
+Test::Nebulous->setup;
+
+eval {
     $neb->create_object();
 };

trunk/Nebulous/lib/Nebulous/Server.pm

@@ -1 +1 @@
 # Copyright (c) 2004  Joshua Hoblitt
 #
-# $Id: Server.pm,v 1.16 2005-11-10 21:57:15 jhoblitt Exp $
+# $Id: Server.pm,v 1.17 2005-11-10 22:07:53 jhoblitt Exp $
 
 package Nebulous::Server;
@@ -90 +90 @@
         {
             type        => SCALAR,
+            callbacks   => {
+                # check that the comment isn't too long
+                'comment length' => sub { length $_[0] < 256 },
+            },
             optional    => 1,
         },
@@ -99 +103 @@
     # add hooks to make this decision based on avaiable space
     $volume = _get_storage_volume( $volume );
-
-    # check that the comment isn't too long
 
     my $uri;

trunk/Nebulous/t/03_server_create_object.t

@@ -3 +3 @@
 # Copryight (C) 2004-2005  Joshua Hoblitt
 #
-# $Id: 03_server_create_object.t,v 1.9 2005-11-10 21:53:56 jhoblitt Exp $
+# $Id: 03_server_create_object.t,v 1.10 2005-11-10 22:07:53 jhoblitt Exp $
 
 use strict;
 use warnings FATAL => qw( all );
 
-use Test::More tests => 13;
+use Test::More tests => 14;
 
 use lib qw( ./t ./lib );
@@ -90 +90 @@
 
 eval {
+    $neb->create_object( 1, 0, 'node01', 'x' x 256 );
+};
+like( $@, qr/comment length/, "comment is too long" );
+
+Test::Nebulous->setup;
+
+eval {
     $neb->create_object();
 };