Changeset 9910

Timestamp:

Nov 8, 2006, 10:19:08 AM (20 years ago)

Author:

Paul Price

Message:

Cleaning up --- isolating tests from each other.

File:

• trunk/psLib/test/types/tap_psMetadataConfig_input.c (modified) (13 diffs)

trunk/psLib/test/types/tap_psMetadataConfig_input.c

@@ -38 +38 @@
 {
     diag("  >>>Test 1:  psMetadataConfigRead");
-    psMetadata *md = NULL;
-    psMetadata *out = NULL;
-    unsigned int nfail = 0;
-    md = psMetadataAlloc();
-    psMetadataAddS32(md, PS_LIST_HEAD, "new_S32", 0, "", 666);
 
     //Return NULL for NULL filename input
     {
-        out = psMetadataConfigRead(out, &nfail, NULL, false);
+        unsigned int nfail = 0;
+        psMetadata *out = psMetadataConfigRead(NULL, &nfail, NULL, false);
         ok( out == NULL,
             "psMetadataConfigRead:           return NULL for NULL filename input.");
@@ -52 +48 @@
     //Return NULL for invalid filename input
     {
-        out = psMetadataConfigRead(out, &nfail, ".", false);
+        unsigned int nfail = 0;
+        psMetadata *out = psMetadataConfigRead(NULL, &nfail, ".", false);
         ok( out == NULL,
             "psMetadataConfigRead:           return NULL for invalid filename input.");
@@ -58 +55 @@
     //Return NULL for missing file input
     {
-        out = psMetadataConfigRead(out, &nfail, "table4.dat", false);
+        unsigned int nfail = 0;
+        psMetadata *out = psMetadataConfigRead(NULL, &nfail, "table4.dat", false);
         ok( out == NULL,
             "psMetadataConfigRead:           return NULL for missing file input.");
@@ -64 +62 @@
     //Return empty metadata for read-only file with invalid syntax
     {
-        out = psMetadataConfigRead(out, &nfail, "table3.dat", false);
+        unsigned int nfail = 0;
+        psMetadata *out = psMetadataConfigRead(NULL, &nfail, "table3.dat", false);
         ok( out != NULL && out->list->n == 0,
             "psMetadataConfigRead:           return empty metadata for file"
             " with invalid syntax.");
         psFree(out);
-        out = NULL;
     }
     //Return true for valid inputs - overwrite = false
     {
-        out = psMetadataConfigRead(out, &nfail, "metaconf.in", false);
+        unsigned int nfail = 0;
+        psMetadata *out = psMetadataConfigRead(NULL, &nfail, "metaconf.in", false);
         psMetadataItem *tempItem = psMetadataGet(out, PS_LIST_HEAD);
         ok( out != NULL && nfail == 25,
@@ -99 +98 @@
         skip_end();
         psMetadataConfigWrite(out, "mdc-overwrite_false.txt");
+        psFree(out);
     }
     //Return true for valid inputs - overwrite = true
     {
-        psFree(out);
-        out = NULL;
-        out = psMetadataConfigRead(out, &nfail, "metaconf.in", true);
+        unsigned int nfail = 0;
+        psMetadata *out = psMetadataConfigRead(NULL, &nfail, "metaconf.in", true);
         psMetadataItem *tempItem = psMetadataGet(out, PS_LIST_HEAD);
         ok( out != NULL  && nfail == 21,
@@ -130 +129 @@
         skip_end();
         psMetadataConfigWrite(out, "mdc-overwrite_true.txt");
+        psFree(out);
     }
 
     //Check for Memory leaks
-    {
-        psFree(out);
-        psFree(md);
-        checkMem();
-    }
+    checkMem();
 }
 
@@ -143 +139 @@
 {
     diag("  >>>Test 2:  psMetadataConfigParse");
-    psMetadata *out = NULL;
-    unsigned int nfail = 0;
     char str1[70];
     char str2[70];
@@ -166 +160 @@
     //Return NULL for NULL string input
     {
-        out = psMetadataConfigParse(out, &nfail, NULL, false);
+        unsigned int nfail = 0;
+        psMetadata *out = psMetadataConfigParse(NULL, &nfail, NULL, false);
         ok( out == NULL,
             "psMetadataConfigParse:         return NULL for NULL string input.");
@@ -172 +167 @@
     //Return empty metadata for incorrect string input
     {
-        psFree(out);
-        out = NULL;
-        out = psMetadataConfigParse(out, NULL, str1, false);
+        psMetadata *out = psMetadataConfigParse(NULL, NULL, str1, false);
         psMetadataItem *tempItem = psMetadataGet(out, PS_LIST_HEAD);
         ok( out != NULL && tempItem == NULL,
             "psMetadataConfigParse:         return empty metadata for invalid "
             "string input.");
-        if (tempItem != NULL)
-            printf("\n\n name=%s\n", tempItem->name);
+        psFree(out);
     }
     //Return correct metadata for correct string input - S32
     {
-        psFree(out);
-        out = NULL;
-        out = psMetadataConfigParse(out, NULL, str2, false);
+        psMetadata *out = psMetadataConfigParse(NULL, NULL, str2, false);
         psMetadataItem *tempItem = psMetadataGet(out, PS_LIST_HEAD);
         ok( out != NULL && tempItem != NULL,
@@ -198 +188 @@
                 "psMetadataConfigParse:         return correct metadataItem name (S32)");
         skip_end();
+        psFree(out);
     }
     //Return correct metadata for correct string input - F64
     {
-        psFree(out);
-        out = NULL;
-        out = psMetadataConfigParse(out, NULL, str3, false);
+        psMetadata *out = psMetadataConfigParse(NULL, NULL, str3, false);
         psMetadataItem *tempItem = psMetadataGet(out, PS_LIST_HEAD);
         ok( out != NULL && tempItem != NULL,
@@ -219 +208 @@
                 "psMetadataConfigParse:         return correct metadataItem name (F64)");
         skip_end();
+        psFree(out);
     }
     //Return correct metadata for string with duplicate entry - S8
     {
-        psFree(out);
-        out = NULL;
-        out = psMetadataConfigParse(out, &nfail, str4, false);
+        unsigned int nfail = 0;
+        psMetadata *out = psMetadataConfigParse(NULL, &nfail, str4, false);
         psMetadataItem *tempItem = psMetadataGet(out, PS_LIST_HEAD);
         ok( out != NULL && tempItem != NULL && out->list->n == 1  && nfail == 1,
@@ -236 +225 @@
                 "psMetadataConfigParse:         return correct metadataItem name (S8)");
         skip_end();
+        psFree(out);
     }
     //Return correct metadata for correct string input - Vector
     {
-        psFree(out);
-        out = NULL;
-        out = psMetadataConfigParse(out, NULL, str7, true);
+        psMetadata *out = psMetadataConfigParse(NULL, NULL, str7, true);
         psMetadataItem *tempItem = psMetadataGet(out, PS_LIST_HEAD);
         ok( out != NULL && tempItem != NULL,
@@ -254 +242 @@
                 "psMetadataConfigParse:         return correct metadataItem name (Vector)");
         skip_end();
+        psFree(out);
     }
     //Return empty metadata for incorrect string input
     {
-        psFree(out);
-        out = NULL;
-        out = psMetadataConfigParse(out, NULL, str9, false);
+        psMetadata *out = psMetadataConfigParse(NULL, NULL, str9, false);
         psMetadataItem *tempItem = psMetadataGet(out, PS_LIST_HEAD);
         ok( out != NULL && tempItem == NULL,
             "psMetadataConfigParse:         return empty metadata for invalid "
             "string input.");
-        if (tempItem != NULL)
-            printf("\n\n name=%s\n", tempItem->name);
-    }
-    //Check for Memory leaks
-    {
-        psFree(out);
-        checkMem();
-    }
+        psFree(out);
+    }
+    // Check for Memory leaks
+    checkMem();
 
 }