2013-10-23

Comparison of ipp-20130712 and eam-branch-XXX

CMF file	index	ipp-tag L	L_MOPS	difference	eam-branch L	L_MOPS	difference
./o6392g0238o.s0.fpa.cmf	0	25.5520420074	69.5	-43.9479579926	25.2005901337	69.5	-44.2994098663
./o6392g0238o.s0.fpa.cmf	1	3.18367624283	69.5	-66.3163237572	2.64567708969	69.5	-66.8543229103
./o6392g0238o.s0.fpa.cmf	2	25.1396484375	69.5	-44.3603515625	25.189573288	69.5	-44.310426712
./o6392g0238o.s0.fpa.cmf	3	4.92207574844	69.5	-64.5779242516	5.18088006973	69.5	-64.3191199303
./o6392g0238o.s1.fpa.cmf	0	24.3006839752	69.5	-45.1993160248	25.1601676941	69.5	-44.3398323059
./o6392g0238o.s1.fpa.cmf	1	34.5275001526	69.5	-34.9724998474	33.7674255371	69.5	-35.7325744629
./o6392g0238o.s1.fpa.cmf	2	3.02041530609	69.5	-66.4795846939	3.02506089211	69.5	-66.4749391079
./o6392g0258o.s0.fpa.cmf	0	45.983745575	69.5	-23.516254425	46.0084724426	69.5	-23.4915275574
./o6392g0278o.s0.fpa.cmf	0	3.1019051075	69.5	-66.3980948925	3.10278606415	69.5	-66.3972139359
./o6392g0278o.s0.fpa.cmf	1	39.2214813232	69.5	-30.2785186768	39.3013000488	69.5	-30.1986999512
./o6392g0278o.s0.fpa.cmf	2	43.3110542297	69.5	-26.1889457703	43.5664291382	69.5	-25.9335708618
./o6392g0275o.s0.fpa.cmf	0	38.3529281616	48.8	-10.4470718384	38.3323478699	48.8	-10.4676521301
./o6392g0295o.s0.fpa.cmf	0	3.11816740036	48.8	-45.6818325996	3.10649251938	48.8	-45.6935074806
./o6392g0295o.s0.fpa.cmf	1	3.54833292961	48.8	-45.2516670704	3.52356886864	48.8	-45.2764311314
./o6392g0295o.s0.fpa.cmf	2	42.474155426	48.8	-6.325844574	42.4663696289	48.8	-6.3336303711
./o6392g0295o.s0.fpa.cmf	3	3.51850223541	48.8	-45.2814977646	3.28675270081	48.8	-45.5132472992
./o6391g0270o.s0.fpa.cmf	0	6.88583469391	68.2	-61.3141653061	6.86001157761	68.2	-61.3399884224
./o6391g0270o.s1.fpa.cmf	0	6.94266891479	68.2	-61.2573310852	6.90459632874	68.2	-61.2954036713
./o6391g0292o.s0.fpa.cmf	0	46.8225631714	68.2	-21.3774368286	46.8168869019	68.2	-21.3831130981
./o6391g0314o.s0.fpa.cmf	0	49.1394805908	68.2	-19.0605194092	49.116607666	68.2	-19.083392334
./o6389g0193o.s0.fpa.cmf	0	10.2764625549	47.3	-37.0235374451	10.0571022034	47.3	-37.2428977966
./o6389g0193o.s0.fpa.cmf	1	17.5834236145	47.3	-29.7165763855	17.7657604218	47.3	-29.5342395782
./o6389g0215o.s0.fpa.cmf	0	36.3150405884	47.3	-10.9849594116	36.3397865295	47.3	-10.9602134705
./o6389g0215o.s0.fpa.cmf	1	7.93172502518	47.3	-39.3682749748	7.82549095154	47.3	-39.4745090485
./o6389g0259o.s0.fpa.cmf	0	11.1794672012	47.3	-36.1205327988	11.1941289902	47.3	-36.1058710098
./o6389g0259o.s0.fpa.cmf	1	7.39956760406	47.3	-39.9004323959	7.54179620743	47.3	-39.7582037926
./o6389g0259o.s0.fpa.cmf	2	5.88574028015	47.3	-41.4142597198	5.9170088768	47.3	-41.3829911232
./o6389g0259o.s0.fpa.cmf	3	38.5486068726	47.3	-8.7513931274	38.2509269714	47.3	-9.0490730286
./o6389g0259o.s0.fpa.cmf	4	11.5479698181	47.3	-35.7520301819	11.6650266647	47.3	-35.6349733353
./o6389g0259o.s0.fpa.cmf	5	9.03969860077	47.3	-38.2603013992	9.1590385437	47.3	-38.1409614563
./o6389g0205o.s0.fpa.cmf	0	25.7934494019	27.5	-1.7065505981	25.7746906281	27.5	-1.7253093719
./o6389g0227o.s0.fpa.cmf	0	24.7478179932	27.5	-2.7521820068	24.7023792267	27.5	-2.7976207733
./o6389g0249o.s0.fpa.cmf	0	25.8140125275	27.5	-1.6859874725	25.8200283051	27.5	-1.6799716949
./o6389g0249o.s1.fpa.cmf	0	25.8235092163	27.5	-1.6764907837	25.9838275909	27.5	-1.5161724091

ipp-20130712 trail test results

2013-10-21

The following table shows the results of fitting the MOPS test trail data set using three different runs. The left column shows the default "current tag" version of the code. The right column shows the comparison between the "czw" run (current trunk, with possible psStats errors I've introduced) and "ipp" run (current tag) with the appropriate LMM options toggled. Plotted are the angle, flux, and length (L1 and L2 being the two length values supplied by MOPS).

The trail window does appear to be updated in all runs, as messages like:

update window : 1144.585815 1019.293091 : 14.631915 -> 29.263830
update window : 1219.900879 1063.883179 : 5.000000 -> 10.000000
update window : 1219.900879 1063.883179 : 10.000000 -> 20.000000
update window : 1241.800659 1062.214478 : 47.373280 -> 94.746559

are printed.

psphot call	-recipe PSPHOT DIFF	-recipe PSPHOT DIFF -Db LMM_FIT_CHISQ_CONVERGENCE F -Di LMM_FIT_GAIN_FACTOR_MODE 2
Angle
Angle vs L
Flux
Flux vs L
L1
L2

2013-02-27

The initial guess for L is in general too large for point-like objects. First, there's an error in the code that chooses between the elliptical major axis and the first radial moment, resulting in a large initial guess. Fixing this doesn't completely work, so the idea was to introduce an offset, such that an object with a size similar to the width is probably point like, so we should normalize by subtracting that width off. This shrinks the length again, but insufficiently. Looking at large numbers of objects (click on full skycell tables in attachments below), it's clear that dL/dIteration is almost universally positive, suggesting an issue with the calculation (typo in the code?) or algorithm.

Example: Original:

    float size = (axes.major > source->moments->Mrf) ? axes.major : source->moments->Mrf;
    PAR[PM_PAR_LENGTH] = 1.5*2.35*size; // a tophat of length L has L = 1.5 * 2.35 * sigma                                  

#X         Y           ID    Mxx       Mxx      Myy       Mr1        EXT_F     EXT_L     EXT_W    EXT_Q     PSF_CHISQ   PSF_NDOF    EXT_CHISQ  EXT_NDOF
77.558716 2633.799072 -98 : 11.551100 1.738350 10.857200 6.066510 : 16.974348 32.950000 1.984060 0.725825 : 3286.150000 2600.000000 3207.900000 2892.000000
       #IT F         L         W        Q          oChi        nChi        delt     dlin      rho      lambda
         0 62.666386 21.384449 1.984059 0.686898 : 5817.757812 3362.864990 nan 1238.471436 1.982196 0.001000
         1 16.869297 22.949951 1.984059 0.686511 : 3362.864990 3327.216797 0.849738 22.782276 1.564734 0.000250
         2 16.829279 24.949951 1.984059 0.689350 : 3327.216797 3292.971436 0.012339 20.549458 1.666485 0.000063
         3 16.904570 26.949951 1.984059 0.697310 : 3292.971436 3260.270020 0.011854 18.246912 1.792162 0.000016
         4 16.923841 28.949951 1.984059 0.710121 : 3260.270020 3231.121338 0.011319 16.398548 1.777516 0.000004
         5 16.916101 30.949951 1.984059 0.721472 : 3231.121338 3207.896484 0.010090 12.160172 1.909912 0.000001
        XX 16.974512 32.949951 1.984059 0.725825 : 3207.896484

Sqrt:

    float size = (axes.major > sqrt(source->moments->Mrf)) ? axes.major : sqrt(source->moments->Mrf);                 
    PAR[PM_PAR_LENGTH] = 1.5*2.35*size; // a tophat of length L has L = 1.5 * 2.35 * sigma                                  

#X         Y           ID    Mxx       Mxx      Myy       Mr1        EXT_F     EXT_L     EXT_W    EXT_Q      PSF_CHISQ   PSF_NDOF    EXT_CHISQ  EXT_NDOF
77.559525 2633.799561 -103 : 11.602900 1.715950 10.896300 6.099250 : 17.214936 29.877100 1.992040 0.654534 : 3400.710000 2600.000000 3371.800000 2917.000000
       #IT F         L         W        Q          oChi        nChi        delt     dlin      rho      lambda
         0 62.998722 12.710316 1.992041 0.683864 : 4785.610352 3625.804443 nan 586.573059 1.977257 0.001000
         1 19.728992 13.877067 1.992041 0.690744 : 3625.804443 3593.194092 0.398012 14.094786 2.313647 0.000250
         2 19.357067 15.877067 1.992041 0.688212 : 3593.194092 3559.262207 0.011191 14.204083 2.388882 0.000063
         3 18.790325 17.877068 1.992041 0.654087 : 3559.262207 3522.943359 0.011644 17.820257 2.038065 0.000016
         4 18.215334 19.877068 1.992041 0.623698 : 3522.943359 3488.975830 0.012464 18.180664 1.868333 0.000004
         5 18.069387 21.877068 1.992041 0.611393 : 3488.975830 3458.826904 0.011657 14.959837 2.015325 0.000001
         6 18.013340 23.877068 1.992041 0.616009 : 3458.826904 3429.208984 0.010346 14.725613 2.011320 0.000000
         7 17.703453 25.877068 1.992041 0.629182 : 3429.208984 3399.503418 0.010164 16.940977 1.753474 0.000000
         8 17.366875 27.877068 1.992041 0.643639 : 3399.503418 3371.803467 0.010194 17.004745 1.628954 0.000000
        XX 17.215097 29.877068 1.992041 0.654534 : 3371.803467

Adjustment:

    float size = (axes.major > sqrt(source->moments->Mrf)) ? axes.major : sqrt(source->moments->Mrf);                 
    if (size > psfAxes.major) { size -= psfAxes.major; }                                                              
    else { size = psfAxes.major; }                                                                                        
    PAR[PM_PAR_LENGTH] = 1.5*2.35*size; // a tophat of length L has L = 1.5 * 2.35 * sigma                                  
#X         Y           ID    Mxx       Mxx      Myy       Mr1        EXT_F     EXT_L     EXT_W    EXT_Q   PSF_CHISQ   PSF_NDOF    EXT_CHISQ  EXT_NDOF
77.559189 2633.799561 -98 : 11.558200 1.736740 10.870700 6.072910 : 5.257746 7.728160 1.978440 0.787694 : 2631.840000 2600.000000 836.549000 824.000000
       #IT F         L         W        Q          oChi        nChi        delt     dlin      rho      lambda
         0 62.719723 5.728158 1.978445 0.687694 : 3845.604736 3837.298584 nan 124.292549 0.066827 0.001000
        XX 5.257778 7.728158 1.978445 0.787694 : 3837.298584