Changeset 10652 for trunk/Ohana/src/opihi/pcontrol/StackOps.c

Timestamp:

Dec 12, 2006, 1:17:11 AM (20 years ago)

Author:

eugene

Message:

adding ASSERTs all over

File:

• trunk/Ohana/src/opihi/pcontrol/StackOps.c (modified) (8 diffs)

trunk/Ohana/src/opihi/pcontrol/StackOps.c

@@ -39 +39 @@
   int i;
 
+  ASSERT (stack != NULL, "stack not set");
   LockStack (stack);
 
@@ -74 +75 @@
   void *object;
   
+  ASSERT (stack != NULL, "stack not set");
   LockStack (stack);
 
@@ -98 +100 @@
   void *object;
 
+  ASSERT (stack != NULL, "stack not set");
   LockStack (stack);
 
@@ -119 +122 @@
   void *object;
   
+  ASSERT (stack != NULL, "stack not set");
   LockStack (stack);
 
@@ -138 +142 @@
 
   int i;
+
+  ASSERT (stack != NULL, "stack not set");
 
   if (where < 0) abort();
@@ -159 +165 @@
   void *object;
   
+  ASSERT (stack != NULL, "stack not set");
+
   for (i = 0; i < stack[0].Nobject; i++) {
     if (stack[0].id[i] != id) continue;
@@ -170 +178 @@
 }
 
-/* the Find operations are not thread-safe */
-# if (0)
-/* get object from stack which matches name */
-void *FindStackByName (Stack *stack, char *name) {
-
-  int i, j;
-  void *object;
-
-  for (i = 0; i < stack[0].Nobject; i++) {
-    if (strcasecmp (stack[0].name[i], name)) continue;
-
-    /* here is the element of interest */
-    object = stack[0].object[i];
-    return (object);
-  }
-  return (NULL);
-}
-
-/* find object in stack, don't remove */
-void *FindStackByID (Stack *stack, int id) {
-
-  int i, j;
-  void *object;
-  
-  for (i = 0; i < stack[0].Nobject; i++) {
-    if (stack[0].id[i] != id) continue;
-
-    /* here is the element of interest */
-    object = stack[0].object[i];
-    return (object);
-  }
-  return (NULL);
-}
-# endif
-
 void LockStack (Stack *stack) {
 # ifdef THREADED
+  ASSERT (stack != NULL, "stack not set");
   pthread_mutex_lock (&stack[0].mutex);
 # endif
@@ -214 +188 @@
 void UnlockStack (Stack *stack) {
 # ifdef THREADED
+  ASSERT (stack != NULL, "stack not set");
   pthread_mutex_unlock (&stack[0].mutex);
 # endif