Changeset 12741 for trunk/psLib/src/imageops/psImageConvolve.c

Timestamp:

Apr 4, 2007, 12:42:02 PM (19 years ago)

Author:

Paul Price

Message:

Reworking image interpolation to work on mask and variance image
simultaneously with the proper image. Working in the idea of having
"good", "bad" and "poor" output mask pixels (taken from Andy Becker),
where "poor" pixels have at least one bad input pixel contributing to
the flux, but the contribution is small (where 'small' is defined by a
user option). To handle all the options, created a
psImageInterpolateOptions structure, which contains all the things
which are constant while looping over an image (including the input
image, variance and mask). Changed function name, and split code out
of psImage.[ch] into its own file. Function returns boolean error
status; output values for image, variance and mask come from pointers
to double. Added interpolation types (GAUSS, LANCZOS2, LANCZOS3,
LANCZOS4). Using a fairly general framework so that additional
interpolation methods might be easily added. Updated tests and other
dependent code. Tests pass (but only test BILINEAR and BICUBE), and
pswarp works (but currently only uses BILINEAR).

File:

• trunk/psLib/src/imageops/psImageConvolve.c (modified) (6 diffs)

trunk/psLib/src/imageops/psImageConvolve.c

@@ -7 +7 @@
 /// @author Eugene Magnier, IfA
 ///
-/// @version $Revision: 1.50 $ $Name: not supported by cvs2svn $
-/// @date $Date: 2007-03-02 22:19:21 $
+/// @version $Revision: 1.51 $ $Name: not supported by cvs2svn $
+/// @date $Date: 2007-04-04 22:42:02 $
 ///
 /// Copyright 2004-2007 Institute for Astronomy, University of Hawaii
@@ -102 +102 @@
                            const psVector *xShifts,
                            const psVector *yShifts,
-                           bool tRelative,
+                           float totalTime,
                            bool xyRelative)
 {
@@ -113 +113 @@
     PS_ASSERT_VECTOR_TYPE(xShifts, PS_TYPE_S32, NULL);
     PS_ASSERT_VECTOR_TYPE(yShifts, PS_TYPE_S32, NULL);
+
+    if (isnan(totalTime)) {
+        // It's more expensive to check for NAN than 0.0
+        totalTime = 0.0;
+    }
 
     // If there are no shifts, the kernel is just a 1 at 0,0
@@ -153 +158 @@
         }
 
-        if (tRelative) {
+        if (totalTime <= 0) {
             tSum += tShifts->data.F32[i];
         }
@@ -160 +165 @@
     psTrace("psLib.imageops", 5, "Kernel range: %d:%d,%d:%d\n", xMin, xMax, yMin, yMax);
 
-    if (!tRelative) {
+    if (totalTime > 0) {
         // Then the total time is simply the final value
         // NB: We assume the counter starts at zero!
-        tSum = tShifts->data.F32[tShifts->n - 1];
+        tSum = totalTime;
     }
 
@@ -181 +186 @@
         }
         float t = tShifts->data.F32[i];
-        if (!tRelative) {
+        if (totalTime > 0) {
             t -= tLast;
             tLast = tShifts->data.F32[i];