Changeset 15986 for trunk/psModules/test/concepts/tap_pmConceptsAverage.c

Timestamp:

Jan 2, 2008, 10:49:57 AM (19 years ago)

Author:

gusciora

Message:

Modified file reads to look for dataFiles and then ../dataFiles.

File:

• trunk/psModules/test/concepts/tap_pmConceptsAverage.c (modified) (10 diffs)

trunk/psModules/test/concepts/tap_pmConceptsAverage.c

@@ -82 +82 @@
     cell->hdu = pmHDUAlloc("cellExtName");
     for (int i = 0 ; i < NUM_READOUTS ; i++) {
-        cell->readouts->data[i] = generateSimpleReadout(cell);
+        cell->readouts->data[i] = psMemDecrRefCounter((psPtr) generateSimpleReadout(cell));
     }
 
@@ -129 +129 @@
     psArrayRealloc(chip->cells, NUM_CELLS);
     for (int i = 0 ; i < NUM_CELLS ; i++) {
-        chip->cells->data[i] = generateSimpleCell(chip);
-    }
-
-    // XXX: Add code to initialize chip pmConcepts
-
-
+        chip->cells->data[i] = psMemDecrRefCounter((psPtr) generateSimpleCell(chip));
+    }
     return(chip);
 }
@@ -153 +149 @@
     psArrayRealloc(fpa->chips, NUM_CHIPS);
     for (int i = 0 ; i < NUM_CHIPS ; i++) {
-        fpa->chips->data[i] = generateSimpleChip(fpa);
-    }
-
-    // XXX: Eventually, when you finish the pmConcepts tests, add full concept
-    // reading code from wherever.
+        fpa->chips->data[i] = psMemDecrRefCounter((psPtr) generateSimpleChip(fpa));
+    }
     pmConceptsBlankFPA(fpa);
-//    bool mdok;
-//    psMetadata *fileData = psMetadataLookupMetadata(&mdok, fpa->hdu->format, "FILE");
-//    char *fpaNameHdr = psMetadataLookupStr(&mdok, fileData, "FPA.NAME");
-//    psMetadataAddStr(fpa->concepts, PS_LIST_TAIL, "FPA.NAME", PS_META_REPLACE, NULL, fpaNameHdr);
-
     return(fpa);
 }
-
-// XXX: This should only be necessary until the psFree() functions for
-// FPA/chip/cell/readout correctly free all child chips/cells/readouts
-void myFreeCell(pmCell *cell)
-{
-    for (int k = 0 ; k < cell->readouts->n ; k++) {
-        psFree(cell->readouts->data[k]);
-    }
-    psFree(cell);
-}
-
-void myFreeChip(pmChip *chip) {
-    for (int j = 0 ; j < chip->cells->n ; j++) {
-        myFreeCell(chip->cells->data[j]);
-    }
-    psFree(chip);
-}
-
-void myFreeFPA(pmFPA *fpa)
-{
-    for (int i = 0 ; i < fpa->chips->n ; i++) {
-        myFreeChip(fpa->chips->data[i]);
-    }
-    psFree(fpa);
-}
-
 
 
@@ -219 +181 @@
 
         for (int fpaID = 0 ; fpaID < NUM_FPAS ; fpaID++) {
-            myFreeFPA(sourceFPA[fpaID]);
+            psFree(sourceFPA[fpaID]);
         }
         psFree(sources);
-        myFreeFPA(targetFPA);
+        psFree(targetFPA);
         psFree(camera);
         ok(!psMemCheckLeaks (id, NULL, NULL, false), "no memory leaks");
@@ -245 +207 @@
 
         for (int fpaID = 0 ; fpaID < NUM_FPAS ; fpaID++) {
-            myFreeFPA(sourceFPA[fpaID]);
+            psFree(sourceFPA[fpaID]);
         }
         psFree(sources);
-        myFreeFPA(targetFPA);
+        psFree(targetFPA);
         psFree(camera);
         ok(!psMemCheckLeaks (id, NULL, NULL, false), "no memory leaks");
@@ -261 +223 @@
         pmFPA *targetFPA = generateSimpleFPA(camera);
         pmFPA *sourceFPA[NUM_FPAS];
+        psMetadata *cameras[NUM_FPAS];
 
         // Ensure that the FPA.TIME average is computed correctly
@@ -266 +229 @@
         psF64 actualTime = 0.0;
         for (int fpaID = 0 ; fpaID < NUM_FPAS ; fpaID++) {
-            sourceFPA[fpaID] = generateSimpleFPA(camera);
+            cameras[fpaID] = psMetadataAlloc();
+            sourceFPA[fpaID] = generateSimpleFPA(cameras[fpaID]);
             psTime *fpaTime = psMetadataLookupPtr(NULL, (sourceFPA[fpaID])->concepts, "FPA.TIME");
             // Add a small value to the psTime so that we can test/ensure that pmConceptsAverageFPAs()
@@ -279 +243 @@
             }
         }
-        ok(pmConceptsAverageFPAs(targetFPA, sources), "pmConceptsAverage(NULL, sources) returned FALSE");
+        // XXX: The memory leak occurs during the following single call
+        ok(pmConceptsAverageFPAs(targetFPA, sources), "pmConceptsAverage(targetFPA, sources) returned TRUE");
         actualTime/= (float) NUM_FPAS;
         psTime *fpaTime = psMetadataLookupPtr(NULL, targetFPA->concepts, "FPA.TIME");
         ok(abs(actualTime - psTimeToMJD(fpaTime)) < 1e-4, "pmConceptsAverageFPAs() calculated the average time correctly");
 
-
-        // Replace the FPA.TIMESYS with a non-conforming value, verify that pmConceptsAverageFPAs() returnes an error        
+        // Replace the FPA.TIMESYS with a non-conforming value, verify that pmConceptsAverageFPAs() returns an error
+
         psTimeType timeSys = psMetadataLookupS32(NULL, sourceFPA[0]->concepts, "FPA.TIMESYS");
         psMetadataAddS32(sourceFPA[NUM_FPAS-1]->concepts, PS_LIST_HEAD, "FPA.TIMESYS", PS_META_REPLACE, NULL, timeSys+10);
@@ -302 +267 @@
         // Free data, check for memory leaks
         for (int fpaID = 0 ; fpaID < NUM_FPAS ; fpaID++) {
-            myFreeFPA(sourceFPA[fpaID]);
+            psFree(sourceFPA[fpaID]);
+            psFree(cameras[fpaID]);
         }
         psFree(sources);
-        myFreeFPA(targetFPA);
+//        psFree(filter);
+        psFree(targetFPA);
         psFree(camera);
         ok(!psMemCheckLeaks (id, NULL, NULL, false), "no memory leaks");
     }
-
-
 
     // ----------------------------------------------------------------------
@@ -461 +426 @@
         psMetadataAddS32(srcCell->concepts, PS_LIST_HEAD, "CELL.Y0", PS_META_REPLACE, NULL, tmpS32);
 
-        myFreeFPA(tgtFPA);
-        myFreeFPA(srcFPA);
+        psFree(tgtFPA);
+        psFree(srcFPA);
         psFree(tgtCamera);
         psFree(srcCamera);