Changeset 17476 for trunk/Ohana/src/opihi/pcontrol/PclientCommand.c

Timestamp:

Apr 23, 2008, 1:17:40 PM (18 years ago)

Author:

eugene

Message:

fixed up the pcontrol / pclient interactions

File:

• trunk/Ohana/src/opihi/pcontrol/PclientCommand.c (modified) (4 diffs)

trunk/Ohana/src/opihi/pcontrol/PclientCommand.c

@@ -6 +6 @@
 
   int status;
-  IOBuffer buffer;
 
   ASSERT (host != NULL, "host missing");
@@ -12 +11 @@
 
   // flush the stdout and stderr buffers here
-  ReadtoIOBuffer (&buffer, host[0].stdout_fd);
-  FlushIOBuffer (&buffer);
-  ReadtoIOBuffer (&buffer, host[0].stderr_fd);
-  FlushIOBuffer (&buffer);
+  // recycle comms_buffer to minimize page thrashing
+  ReadtoIOBuffer (&host[0].comms_buffer, host[0].stdout_fd);
+  FlushIOBuffer (&host[0].comms_buffer);
+  ReadtoIOBuffer (&host[0].comms_buffer, host[0].stderr_fd);
+  FlushIOBuffer (&host[0].comms_buffer);
 
   /* send command to client (adding on \n) */
@@ -30 +30 @@
   host[0].response = response;
   FlushIOBuffer (&host[0].comms_buffer);
+
+  // fprintf (stderr, "command: %s\n", command);
 
   return (PCLIENT_GOOD);
@@ -67 +69 @@
   if (status == -1) return (PCLIENT_HUNG);
 
-  // fprintf (stderr, "buffer.buffer: %s\n", buffer[0].buffer);
-
-  // we have detected a valid response, clear the response data
-  host[0].response_state = PCONTROL_RESP_NONE;
-  host[0].response = NULL;
+  // fprintf (stderr, "response: %s\n", buffer[0].buffer);
 
   return (PCLIENT_GOOD);