Changeset 26865 for branches/eam_branches/20091201/ippTools/src/magictool.c

Timestamp:

Feb 10, 2010, 4:05:44 PM (16 years ago)

Author:

eugene

Message:

updates from trunk

File:

• branches/eam_branches/20091201/ippTools/src/magictool.c (modified) (4 diffs)

branches/eam_branches/20091201/ippTools/src/magictool.c

@@ -619 +619 @@
         return false;
     }
+    psS32 numUpdated = psDBAffectedRows(config->dbh);
+    psLogMsg("magictool", PS_LOG_INFO, "Reverted %d magic runs", numUpdated);
+
     return true;
 }
@@ -874 +877 @@
 
     // look for tree nodes that need to be processed
+
+    // first find incomplete magicRuns
     query = pxDataGet("magictool_toprocess_runs.sql");
     if (!query) {
@@ -880 +885 @@
     }
 
+    // we limit the query even though it is cheap (only magic_id is selected)
+
+    // XXX: if the first 1000 unfinished magicRuns have no ready nodes
+    // that haven't faulted, later runs won't get returned even though
+    // they have work to do. When we used a limit of 100 we actually ran
+    // into this problem. Since we're using labels a limit of 1000 will
+    // probably be ok.
     {
-        psString limitString = psDBGenerateLimitSQL( 100 );
+        psString limitString = psDBGenerateLimitSQL( 1000 );
         psStringAppend(&query, " %s", limitString);
         psFree(limitString);
@@ -1074 +1086 @@
 
     psS32 numUpdated = psDBAffectedRows(config->dbh);
-    psLogMsg("magictool", PS_LOG_INFO, "Updated %d magic nodes", numUpdated);
+    psLogMsg("magictool", PS_LOG_INFO, "Reverted %d magic nodes", numUpdated);
 
     return true;