Changeset 40113 for branches/eam_branches/ohana.20170809/src/libfits/header/F_create_H.c

Timestamp:

Aug 9, 2017, 12:47:22 PM (9 years ago)

Author:

eugene

Message:

mostly harmless changes to track down dvopsps segfaults: watch out for Bzero,Bscale in F_set_column.c

File:

• branches/eam_branches/ohana.20170809/src/libfits/header/F_create_H.c (modified) (2 diffs)

branches/eam_branches/ohana.20170809/src/libfits/header/F_create_H.c

@@ -1 +1 @@
 # include <ohana.h>
 # include <gfitsio.h>
-# define NBYTES 2880
 
 /******************** fits create header ***********************************/
@@ -9 +8 @@
   char axis[10];
   
-  header[0].datasize = NBYTES;
+  header[0].datasize = FT_RECORD_SIZE;
 
-  ALLOCATE (header[0].buffer, char, NBYTES);
+  ALLOCATE (header[0].buffer, char, FT_RECORD_SIZE);
 
-  for (i = 0; i < NBYTES; i++) 
-    header[0].buffer[i] = ' ';
+  // XXX this is just slightly suspicious : I am not ending the buffer with a NULL.  if I
+  // use any string operations on it then they can run past the end.
+  for (i = 0; i < FT_RECORD_SIZE; i++) header[0].buffer[i] = ' ';
   strncpy (header[0].buffer, "END", 3);