Changeset 40944 for branches/ipp-259_genericise_backups/tools/backups/jira_backup_test.py

Timestamp:

Oct 14, 2019, 4:59:32 PM (7 years ago)

Author:

fairlamb

Message:

Tidy up tests, and removed now unused files

File:

• branches/ipp-259_genericise_backups/tools/backups/jira_backup_test.py (modified) (2 diffs)

branches/ipp-259_genericise_backups/tools/backups/jira_backup_test.py

@@ -116 +116 @@
         self.assert_defaults(jb)
 
-    def test_default_config_loads_with_no_args(self):
-        default_config = jbck_mod.DEFAULT_CONFIG_FILE
-        assert os.path.exists(default_config)
-        jb = JiraBackup()
-        self.assert_defaults(jb)
+    def test_default_config_fails_to_load_if_the_file_does_not_exist(self):
+        default_config = jbck_mod.EXPECTED_CONFIG_FILE
+        assert not os.path.exists(default_config)
+
+        with pytest.raises(errs.ValidationError) as e:
+            JiraBackup()
+        assert "ValidationError: Config filepath does not exist" in str(e)
 
     def test_default_arguments(self):
@@ -166 +168 @@
 
     def test_nonexistant_config_file_raises_error(self):
-        with pytest.raises(errs.ConfigError):
+        with pytest.raises(errs.ValidationError) as e:
             JiraBackup("not a real file path")
+        assert "ValidationError: Config filepath does not exist" in str(e)
 
     def test_main_loads_default_and_fails_due_to_missing_paths(self):
         with pytest.raises(errs.ValidationError) as e:
             jbck_mod.main()
-        assert "ValidationError: target path does not exist:" in str(e)
+        assert "ValidationError: Config filepath does not exist" in str(e)