Changeset 41499 for trunk/psastro/src/psastroMosaicAstrom.c

Timestamp:

Feb 18, 2021, 4:08:42 PM (5 years ago)

Author:

eugene

Message:

set bad data quality if too many chips fail in mosaic, but do not fail to write out the smf file

File:

• trunk/psastro/src/psastroMosaicAstrom.c (modified) (11 diffs)

trunk/psastro/src/psastroMosaicAstrom.c

@@ -14 +14 @@
 # define NONLIN_TOL 0.001 /* tolerance in pixels */
 
-bool psastroMosaicFit (pmFPA *fpa, psMetadata *recipe, const char *rootname, int pass);
+bool psastroMosaicFit (pmFPA *fpa, psMetadata *stats, psMetadata *recipe, const char *rootname, int pass);
 bool psastroProjectionRefit (pmFPA *fpa, psMetadata *recipe);
 
 // XXX require this fpa to have multiple chip extensions and a PHU?
-bool psastroMosaicAstrom (pmConfig *config) {
+// EAM 2021.02.18 : addings 'stats' to set bad quality as appropriate 
+bool psastroMosaicAstrom (pmConfig *config, psMetadata *stats) {
 
     bool status;
@@ -25 +26 @@
     psMetadata *recipe  = psMetadataLookupPtr (&status, config->recipes, PSASTRO_RECIPE);
     if (!recipe) {
+        // recipe or programming error
         psError(PSASTRO_ERR_CONFIG, false, "Can't find PSASTRO recipe!\n");
         return false;
@@ -32 +34 @@
     pmFPAfile *input = psMetadataLookupPtr (NULL, config->files, "PSASTRO.INPUT");
     if (!input) {
+        // recipe or programming error
         psError(PSASTRO_ERR_CONFIG, false, "Can't find input data!\n");
         return false;
@@ -53 +56 @@
     // this should be in a loop with nIter =
     for (int iter = 0; fitMosaicDistortion && (iter < nIter); iter++) {
-        if (!psastroMosaicFit (fpa, recipe, outroot, iter)) return false;
+        // NOTE: data quality (psastroMosaicDistortion) or recipe / config error
+        if (!psastroMosaicFit (fpa, stats, recipe, outroot, iter)) return false;
     }
 
@@ -59 +63 @@
     // first, re-perform the match with a slightly tighter circle
     if (!psastroMosaicSetMatch (fpa, recipe, nIter)) {
+      // recipe or alloc error
       psError(PSASTRO_ERR_UNKNOWN, false, "failed to match raw and ref stars for mosaic (pass %d)", nIter);
       return false;
     }
-    if (!psastroMosaicChipAstrom (fpa, recipe, nIter)) {
+    if (!psastroMosaicChipAstrom (fpa, stats, recipe, nIter)) {
+      // this cannot actually return false
       psError(PSASTRO_ERR_UNKNOWN, false, "failed to measure chip astrometry in mosaic mode (pass %d)", nIter);
       return false;
@@ -83 +89 @@
     }
     if (!pmAstromWriteBilevelMosaic (updates, fpa, NONLIN_TOL)) {
-        psError(psErrorCodeLast(), false, "Failed to save header terms");
-        return false;
+        // error here is a data quality problem (and too bad to write smf)
+        psWarning ("Failed to save header terms");
+        if (stats && psMetadataLookupS32(NULL, stats, "QUALITY") == 0) {
+            psMetadataAddS32(stats, PS_LIST_TAIL, "QUALITY", PS_META_REPLACE, "Mosaic astrometry failed", PSASTRO_ERR_DATA);
+        }
+        return false;
     }
 
@@ -109 +119 @@
 // 2: match 6,7
 // 3: match 8,9
-bool psastroMosaicFit (pmFPA *fpa, psMetadata *recipe, const char *rootname, int pass) {
+bool psastroMosaicFit (pmFPA *fpa, psMetadata *stats, psMetadata *recipe, const char *rootname, int pass) {
 
     char filename[256];
@@ -117 +127 @@
     if (!psastroMosaicSetMatch (fpa, recipe, pass)) {
         psError(PSASTRO_ERR_UNKNOWN, false, "failed to match raw and ref stars for mosaic (pass %d)", pass);
+        // this can only fail on alloc failure in pmAstromRadiusMatchUniq
         return false;
     }
@@ -129 +140 @@
     // then recalculate raw and ref positions
     if (!psastroMosaicCommonScale (fpa, recipe)) {
+        // this can only return false if the recipe value is not set
         psError(PSASTRO_ERR_UNKNOWN, false, "failed to set a common scale for the chips (pass %d)", pass);
         return false;
@@ -141 +153 @@
     // apply the new distortion terms up and down
     // refit the per-chip terms with linear fits only
+    // NOTE: failure here is a data quality problem
     if (!psastroMosaicDistortion (fpa, recipe, pass)) {
-        psError(PSASTRO_ERR_UNKNOWN, false, "failed to measure mosaic gradients (pass %d)", pass);
+        psWarning ("failed to measure mosaic gradients (pass %d)", pass);
+        if (stats && psMetadataLookupS32(NULL, stats, "QUALITY") == 0) {
+            psMetadataAddS32(stats, PS_LIST_TAIL, "QUALITY", PS_META_REPLACE, "Mosaic astrometry failed", PSASTRO_ERR_DATA);
+        }
         return false;
     }
@@ -150 +166 @@
 
     // measure the astrometry for the chips under the distortion term
-    if (!psastroMosaicChipAstrom (fpa, recipe, pass)) {
+    if (!psastroMosaicChipAstrom (fpa, stats, recipe, pass)) {
+        // this cannot actually return false
         psError(PSASTRO_ERR_UNKNOWN, false, "failed to measure chip astrometry in mosaic mode (pass %d)", pass);
         return false;