Changeset 41549 for trunk/ippTools/src/dqstatstool.c

Timestamp:

Apr 9, 2021, 4:44:03 PM (5 years ago)

Author:

eugene

Message:

disallow unrestricted queries and add -all option to definebyquery commands and others which would generate very long results if allowed: camtool, chiptool, difftool, dqstatstool, faketool, pubtool, warptool

File:

• trunk/ippTools/src/dqstatstool.c (modified) (2 diffs)

trunk/ippTools/src/dqstatstool.c

@@ -223 +223 @@
   PXOPT_COPY_S64(config->args, where, "-dqstats_id", "dqstatsRun.dqstats_id", "==");
   PXOPT_COPY_STR(config->args, where, "-label", "dqstatsRun.label", "==");
+  PXOPT_LOOKUP_BOOL(all, config->args, "-all", false);
 
   psString query = pxDataGet("dqstatstool_get_run.sql");           // query
@@ -230 +231 @@
   }
 
-  if (where && psListLength(where->list)) {
+  if (psListLength(where->list)) {
     psString whereClause = psDBGenerateWhereConditionSQL(where, NULL);
     psStringAppend(&query, " AND %s", whereClause);
     psFree(whereClause);
+  } else {
+    if (!all) {
+      psError(PXTOOLS_ERR_SYS, false, "unrestricted query not allowed (try -all)");
+      return false;
+    }
   }
   psFree(where);