Changeset 42289 for trunk/psastro/src/psastroUtils.c

Timestamp:

Sep 23, 2022, 5:57:17 AM (4 years ago)

Author:

eugene

Message:

psastroUpdateChiptoFPA can fail on the inversion leaving behind a NULL chip->fromFPA. I have added a warning message to the log in psastroUpdateChiptoFPA. In psastroOneChipFit and in psastroMosaicOneChip, I add this condition ( fromFPA is NULL ) to the failure conditions and set bad chip quality. In psastroAstromGuessCheck, the NULL was making the loop skip the entry in the list of corner vectors making this comparison invalid ( mismatch between corners ) . The code now warns on NULL fromFPA and the failed chip is handled like other failed chips. Comments added to psastroOneChipGrid.c

File:

• trunk/psastro/src/psastroUtils.c (modified) (2 diffs)

trunk/psastro/src/psastroUtils.c

@@ -109 +109 @@
 
     psRegion *region = pmChipPixels (chip);
-
     psFree (chip->fromFPA);
     chip->fromFPA = psPlaneTransformInvert (NULL, chip->toFPA, *region, 50, 4);
     psFree (region);
+
+    // XXX EAM 2022.09.22 : for a specific case, psPlaneTransformInvert fails.
+    // This probably means the solution was poor in any case.  
+    // Some options:
+    // 1) skip the chip in psastroAstromGuessCheck (supply bad corners)
+    // 2) mark this chip as bad (return an error here and trap in psastroMosaicOneChip)
+    // 3) warn of the failure:
+    if (!chip->fromFPA) {
+        char *name = psMetadataLookupStr (NULL, chip->concepts, "CHIP.NAME");
+        psLogMsg ("psastro", PS_LOG_INFO, "WARNING: failure to invert toFPA for %s", name);
+    }
 
     // loop over cells in this chip
@@ -150 +160 @@
                     pmAstromObj *ref = refstars->data[i];
                     psPlaneTransformApply (ref->chip, chip->fromFPA, ref->FP);
+                    // if chip->fromFPA is NULL (non-invertable), the action is skipped
                 }
             }